)]}'
{"functions":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"014886c304709f8b7c0d47227ada54233c33da80","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    timeout $timeout sh -c \"while ! curl -g -k --noproxy \u0027*\u0027 -s $url \u003e/dev/null; do sleep 1; done\""},{"line_number":335,"context_line":"}"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"function get_with_curl {"},{"line_number":338,"context_line":"    local url\u003d$1"},{"line_number":339,"context_line":"    curl -g $url 2\u003e/dev/null"},{"line_number":340,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba7be1f8_2492cb9f","line":337,"updated":"2015-02-27 15:01:35.000000000","message":"If we\u0027re going to wrap curl it should be a proper wrapper and be able to be used as a substitute, such as in line 334 above.  So at a minimum handle all arguments.  The stdout redirect should go.","commit_id":"1fe33012d7fbbac657724228538477e2e971f77e"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"b356b4cb67c479b46076f423012b752c5ec78f80","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    timeout $timeout sh -c \"while ! curl -g -k --noproxy \u0027*\u0027 -s $url \u003e/dev/null; do sleep 1; done\""},{"line_number":335,"context_line":"}"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"function get_with_curl {"},{"line_number":338,"context_line":"    local url\u003d$1"},{"line_number":339,"context_line":"    curl -g $url 2\u003e/dev/null"},{"line_number":340,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba7be1f8_8c02aeb2","line":337,"in_reply_to":"ba7be1f8_2492cb9f","updated":"2015-02-27 21:15:13.000000000","message":"@Dean, as we are invoking a shell in L334, I\u0027ll change it to a macro which can be used at all the places. \n\nThanks for reviewing the patch.","commit_id":"1fe33012d7fbbac657724228538477e2e971f77e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c191c13156d472b44ce24b7ebe916b1983a1bc50","unresolved":false,"context_lines":[{"line_number":326,"context_line":"}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"#Macro for curl statements with necessary options"},{"line_number":329,"context_line":"CURL_GET\u003d\"curl -g\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"# Wait for an HTTP server to start answering requests"},{"line_number":332,"context_line":"# wait_for_service timeout url"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba7be1f8_5783c4cb","line":329,"updated":"2015-03-01 23:25:08.000000000","message":"for mine i\u0027m fine with this in here (we had issues with $YUM in stackrc), but we should make it optional and mention in the comment the \"-g\" is for matching ipv6\n\nCURL_GET\u003d\"${CURL_GET:-curl -g}\"","commit_id":"302e159cb44d79b22592c1e277f009bf1a1076b1"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"9070a547b65c9809a8bf563ae628846a13fc0f27","unresolved":false,"context_lines":[{"line_number":326,"context_line":"}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"#Macro for curl statements with necessary options"},{"line_number":329,"context_line":"CURL_GET\u003d\"curl -g\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"# Wait for an HTTP server to start answering requests"},{"line_number":332,"context_line":"# wait_for_service timeout url"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba7be1f8_d30d0137","line":329,"in_reply_to":"ba7be1f8_5783c4cb","updated":"2015-03-02 07:43:07.000000000","message":"Sure @Ian, I\u0027ll update the patch accordingly. Thanks.","commit_id":"302e159cb44d79b22592c1e277f009bf1a1076b1"}]}