)]}'
{"lib/ironic":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4bf069b23884ab99f5700964035d858a6b1739d7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8088}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Use IPA when deploying with iSCSI"},{"line_number":125,"context_line":"IRONIC_ISCSI_DEPLOYMENT_WITH_IPA\u003d$(trueorfalse False IRONIC_ISCSI_DEPLOYMENT_WITH_IPA)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":128,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba7be1f8_ddb84413","line":125,"updated":"2015-02-25 18:38:09.000000000","message":"just a suggestion. Since we already have IRONIC_DEPLOY_* (eg IRONIC_DEPLOY_FLAVOR), how about either\n 1. IRONIC_DEPLOY_ISCSI_WITH_IPA \u003d true/false\n 2. IRONIC_DEPLOY_ISCSI \u003d \u0027ipa\u0027\n\nAlso wondering, I see we have \u0027is_deployed_by_agent\u0027. Is there a distinction between \u0027IPA\u0027 and \u0027agent\u0027 or do they mean the same thing? If the same thing, maybe we should use \u0027agent\u0027 here too? Although I like \u0027IPA\u0027 because it is more specific. I know, jroll doesn\u0027t want to think of another agent that isn\u0027t based on IPA ;)","commit_id":"f70f8ce34232c529193cf1c4aea0301cf7af5c07"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1d853c254d657c88037327441cf0ec473024c4b1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8088}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Use IPA when deploying with iSCSI"},{"line_number":125,"context_line":"IRONIC_ISCSI_DEPLOYMENT_WITH_IPA\u003d$(trueorfalse False IRONIC_ISCSI_DEPLOYMENT_WITH_IPA)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":128,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba7be1f8_51b8a229","line":125,"in_reply_to":"ba7be1f8_ddb84413","updated":"2015-02-26 10:17:39.000000000","message":"I like 1)... 2) is good but since we want to have ipa as default ramdisk I would rather not leave it open, because 2 ramdisks (bash and ipa) we have now is right now is already pretty hard to maintain, introducing a new one would be too much overhead.\n\nRe is_deployed_by_agent, it\u0027s has some overlaps, which we may want remove in the future once we have a unique ramdisk. But right now I like to think about \"agent\" as the methodology of deployment, that works for full disk images and do the partitioning of the disk in the ramdisk itself (not conductor) as we do for iSCSI.","commit_id":"f70f8ce34232c529193cf1c4aea0301cf7af5c07"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b121a7d54c07bdc8e1bad7d06b6941d48ee2a634","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8088}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Use IPA when deploying with iSCSI"},{"line_number":125,"context_line":"IRONIC_DEPLOY_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_ISCSI_WITH_IPA)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":128,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba7be1f8_d4971646","line":125,"updated":"2015-02-26 14:35:03.000000000","message":"I saw your reply to my question and Sean\u0027s, about is_deployed_by_agent. I think it would be helpful to put that information here, so people looking at this in the future will understand the rationale and don\u0027t eg think it is a bug that it wasn\u0027t combined with is_deployed_by_agent. (May be useful in the commit message too, but if I had to choose one place, I\u0027d choose here.)","commit_id":"636e19a20effd0e079e98af2887f94cfa28dd584"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2b69a9a8fa1874b2dd0c80807892a7d98b91be6","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8088}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Use IPA when deploying with iSCSI"},{"line_number":125,"context_line":"IRONIC_DEPLOY_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_ISCSI_WITH_IPA)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":128,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba7be1f8_0970b03e","line":125,"in_reply_to":"ba7be1f8_d4971646","updated":"2015-02-26 17:40:21.000000000","message":"Sure, makes sense. I will update it here","commit_id":"636e19a20effd0e079e98af2887f94cfa28dd584"}]}