)]}'
{"functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ffd14b0ce4c1d6b1d04164a9db599eb4a8c52a66","unresolved":false,"context_lines":[{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# copy default policy"},{"line_number":575,"context_line":"function copy_default_policy {"},{"line_number":576,"context_line":"    local src_policy\u003d${1}"},{"line_number":577,"context_line":"    local conf_dest\u003d${2}"},{"line_number":578,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_dd75d998","line":575,"updated":"2015-03-13 02:54:01.000000000","message":"i think the point of this should be to copy it into /etc/policy.d/$project/ ; not just a generic copy","commit_id":"8ba44f4a70af7506c958e038d755898b52db3e64"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"77bff01f9ae62e0ec68cef473baaee2c4c98fa74","unresolved":false,"context_lines":[{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# copy default policy"},{"line_number":575,"context_line":"function copy_default_policy {"},{"line_number":576,"context_line":"    local src_policy\u003d${1}"},{"line_number":577,"context_line":"    local conf_dest\u003d${2}"},{"line_number":578,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_87249060","line":575,"in_reply_to":"9a80dd14_2e2d86a8","updated":"2015-03-16 14:34:31.000000000","message":"There isn\u0027t any value-add to this function except the dir check, and I\u0027d argue that the dir check should result in creating the dest dir if it doesn\u0027t exist rather than just skipping the copy altogether.\n\nAn alternative to creating a new function would be to use install(1), which we should be doing more of anyway:\n\n    install -D $NOVA_DIR/etc/nova/policy.json $NOVA_CONF_DIR/policy.d/policy.json\n\ndoes it all in a single command including creating the directory if necessary.","commit_id":"8ba44f4a70af7506c958e038d755898b52db3e64"},{"author":{"_account_id":11189,"name":"yuntongjin","email":"yuntong.jin@intel.com","username":"yuntong"},"change_message_id":"bcfa0c8a548c373a45ca2d3170d332f825aeebb3","unresolved":false,"context_lines":[{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# copy default policy"},{"line_number":575,"context_line":"function copy_default_policy {"},{"line_number":576,"context_line":"    local src_policy\u003d${1}"},{"line_number":577,"context_line":"    local conf_dest\u003d${2}"},{"line_number":578,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_311bf974","line":575,"in_reply_to":"9a80dd14_87249060","updated":"2015-03-17 06:18:34.000000000","message":"Thanks, will update then.","commit_id":"8ba44f4a70af7506c958e038d755898b52db3e64"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c6f534d3cf0a5de0d071bfc1d94bba232b576cd3","unresolved":false,"context_lines":[{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# copy default policy"},{"line_number":575,"context_line":"function copy_default_policy {"},{"line_number":576,"context_line":"    local src_policy\u003d${1}"},{"line_number":577,"context_line":"    local conf_dest\u003d${2}"},{"line_number":578,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_f2fd67b2","line":575,"in_reply_to":"9a80dd14_dd75d998","updated":"2015-03-13 05:29:10.000000000","message":"Hi, Ian, the default config of oslo.policy is load policy files from \u0027/etc/$project/policy.d/\u0027. And for now, nova use that default config. If we want to all the projects put the policy files in \u0027/etc/policy.d\u0027, I think that need more generic agreement corss all the project first, so I think it\u0027s not the scope for currently.","commit_id":"8ba44f4a70af7506c958e038d755898b52db3e64"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"77a11f6103531b7cc01fdac893f18b2d4b808ef0","unresolved":false,"context_lines":[{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# copy default policy"},{"line_number":575,"context_line":"function copy_default_policy {"},{"line_number":576,"context_line":"    local src_policy\u003d${1}"},{"line_number":577,"context_line":"    local conf_dest\u003d${2}"},{"line_number":578,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_2e2d86a8","line":575,"in_reply_to":"9a80dd14_f2fd67b2","updated":"2015-03-16 12:17:12.000000000","message":"I think Ian meant /etc/$project/policy.d/\n\nBut the point is, you introduced this function copy_default_policy but all it does is a \u0027cp\u0027. You could have done the copy directly in lib/nova.","commit_id":"8ba44f4a70af7506c958e038d755898b52db3e64"}],"functions-common":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"f23f59feed455779e7790d28f1d45e940b43b8d3","unresolved":false,"context_lines":[{"line_number":805,"context_line":"    cp -p $sample_conf_dir/policy.json $conf_dir"},{"line_number":806,"context_line":"    # then optionally copy over policy.d"},{"line_number":807,"context_line":"    if [[ -d $sample_policy_dir ]]; then"},{"line_number":808,"context_line":"        cp -r $sample_policy_dir $conf_dir/policy.d"},{"line_number":809,"context_line":"    fi"},{"line_number":810,"context_line":"}"},{"line_number":811,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a80dd14_b6d03af8","line":808,"updated":"2015-03-19 13:24:28.000000000","message":"cp -r $sample_policy_dir $conf_dir/\nshould be ok.","commit_id":"f26deea6b1d7a91da44979d8c7feaf1ff8970b25"}]}