)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1e791ffc8744c637aee286bc5a5f129f4186e4aa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make it possible for someone to config"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  PIP_UPGRADE\u003dTrue"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"in local.conf and thus force pip_install calls to upgrade. In"},{"line_number":14,"context_line":"automated testing this is probably a bad idea, but in manual testing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_7e44b049","line":11,"updated":"2015-03-09 13:43:30.000000000","message":"nit: It\u0027s better to use following description this patch commits into configuration.rst\n\nPIP_UPGRADE\u003dyes","commit_id":"aea05e3d0b1713eb191660894f10629799c6f09f"}],"doc/source/configuration.rst":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"63f110ebcdf3e8429dae1e222b0522719d1ec909","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    | *Default: ``PIP_UPGRADE\u003d\"\"``*"},{"line_number":254,"context_line":"    |  By default ``stack.sh`` only installs Python packages if no version"},{"line_number":255,"context_line":"       is currently installed or the current version does not match a specified"},{"line_number":256,"context_line":"       requirement. If ``PIP_UPGRADE`` is set to ``yes`` then existing required"},{"line_number":257,"context_line":"       Python packages will be upgraded to the most recent version that"},{"line_number":258,"context_line":"       matches requirements."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a80dd14_640588c1","line":255,"updated":"2015-03-11 18:23:55.000000000","message":"Not sure about \"or the current version does not match a specified requirement\"\nthat\u0027s not what I\u0027ve seen with recent testtools 1.7.0 breakage where pip didn\u0027t upgrade distro provideded unittest2 0.5.1 and requirement was \u003e\u003d1.0.0 ?","commit_id":"713c58d77b8b1c31925c343e3e3eaf19168ae6bb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"c389f1a9a467541ffc3e6de5edea7f25859f8dd5","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    | *Default: ``PIP_UPGRADE\u003d\"\"``*"},{"line_number":254,"context_line":"    |  By default ``stack.sh`` only installs Python packages if no version"},{"line_number":255,"context_line":"       is currently installed or the current version does not match a specified"},{"line_number":256,"context_line":"       requirement. If ``PIP_UPGRADE`` is set to ``yes`` then existing required"},{"line_number":257,"context_line":"       Python packages will be upgraded to the most recent version that"},{"line_number":258,"context_line":"       matches requirements."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a80dd14_489dd258","line":255,"in_reply_to":"9a80dd14_640588c1","updated":"2015-03-12 12:24:14.000000000","message":"I think the use of the phrase \"distro provided\" breaks all expectations in this case. In my experience the distro installations will break _any_ kind of future pip installs if there are version requirements.  The easiest fix I\u0027ve found is to go back and remove any distro installed python packages _or_  pip install --force.\n\nThis patch isn\u0027t trying to fix the distro problem, merely the issue where you\u0027ve got a machine you\u0027ve run devstack on and would like it to upgrade the pip packages. Until this patch there was no straightforward way to do that.","commit_id":"713c58d77b8b1c31925c343e3e3eaf19168ae6bb"}],"inc/python":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b4f0c18eecc4efe0fbad5456a20e46c276b4fe4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"function pip_install {"},{"line_number":46,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":47,"context_line":"    set +o xtrace"},{"line_number":48,"context_line":"    local upgrade\u003d${PIP_UPGRADE:+--upgrade}"},{"line_number":49,"context_line":"    local offline\u003d${OFFLINE:-False}"},{"line_number":50,"context_line":"    if [[ \"$offline\" \u003d\u003d \"True\" || -z \"$@\" ]]; then"},{"line_number":51,"context_line":"        $xtrace"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a80dd14_bea79a4e","line":48,"updated":"2015-03-05 06:34:41.000000000","message":"Do you intend to set upgrade option as default? Then, the implement is different from your commit message \"PIP_UPGRADE\u003dTrue\".","commit_id":"ed1dcab3fc55d27dbc0f6717f35eb9dba8f4bc80"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3bf73daf75f5f2888a5436032496f82775d2a022","unresolved":false,"context_lines":[{"line_number":45,"context_line":"function pip_install {"},{"line_number":46,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":47,"context_line":"    set +o xtrace"},{"line_number":48,"context_line":"    local upgrade\u003d${PIP_UPGRADE:+--upgrade}"},{"line_number":49,"context_line":"    local offline\u003d${OFFLINE:-False}"},{"line_number":50,"context_line":"    if [[ \"$offline\" \u003d\u003d \"True\" || -z \"$@\" ]]; then"},{"line_number":51,"context_line":"        $xtrace"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a80dd14_f2e21e00","line":48,"in_reply_to":"9a80dd14_bea79a4e","updated":"2015-03-05 09:59:39.000000000","message":"The above line with set $upgrade to \u0027--upgrade\u0027 if PIP_UPGRADE has any value. If it is unset then the value of $upgrade will be \u0027\u0027.\n\nSo the intent here is for the existing behavior (not --upgrade) to be the default.","commit_id":"ed1dcab3fc55d27dbc0f6717f35eb9dba8f4bc80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e22360fb99097abec632b227f932b970e5363a2a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"function pip_install {"},{"line_number":46,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":47,"context_line":"    set +o xtrace"},{"line_number":48,"context_line":"    local upgrade\u003d${PIP_UPGRADE:+--upgrade}"},{"line_number":49,"context_line":"    local offline\u003d${OFFLINE:-False}"},{"line_number":50,"context_line":"    if [[ \"$offline\" \u003d\u003d \"True\" || -z \"$@\" ]]; then"},{"line_number":51,"context_line":"        $xtrace"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a80dd14_aeb11ae3","line":48,"in_reply_to":"9a80dd14_f2e21e00","updated":"2015-03-05 12:59:21.000000000","message":"You\u0027re right. I misunderstood.","commit_id":"ed1dcab3fc55d27dbc0f6717f35eb9dba8f4bc80"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1defcdbb44bd68ca6171a114ab6cb67f86fc3e6b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"function pip_install {"},{"line_number":60,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":61,"context_line":"    set +o xtrace"},{"line_number":62,"context_line":"    local upgrade\u003d${PIP_UPGRADE:+--upgrade}"},{"line_number":63,"context_line":"    local offline\u003d${OFFLINE:-False}"},{"line_number":64,"context_line":"    if [[ \"$offline\" \u003d\u003d \"True\" || -z \"$@\" ]]; then"},{"line_number":65,"context_line":"        $xtrace"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa963961_c808832b","line":62,"updated":"2015-03-26 14:02:40.000000000","message":"I would rather see True / False used for the value of PIP_UPGRADE to be consistent with our other config vars.","commit_id":"a1275df97cf1b3e4e25a69b3f842fce79d222780"}]}