)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"19aeaf52cfca4b94fedc1486431076d262149f18","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add the port_sec as default neutron/ml2 extension driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron ML2 plugin introduces the first extension driver port_security, this"},{"line_number":10,"context_line":"patch add it to be a default extension driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3035317c83d22804855517434bd8578719ce0436"},{"line_number":13,"context_line":"Depends-On: I2da53168e2529db7a8094ce90ef3a8a93fe55727"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_877a2275","line":10,"updated":"2015-03-06 23:39:55.000000000","message":"Please mention the corresponding patch of Neutron.\nand describe rationale on make it default. Not optional.","commit_id":"95304355b76701e22dffd3b44698b14222c94c60"}],"doc/source/guides/neutron.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d8750507a18503cbf875adeb56c2fe6434328f74","unresolved":false,"context_lines":[{"line_number":131,"context_line":"subnet that exists in the private RFC1918 address space - however in"},{"line_number":132,"context_line":"in a real setup FLOATING_RANGE would be a public IP address range."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Note extension driver of ML2 plugin is set by `Q_ML2_PLUGIN_EXT_DRIVERS`, and"},{"line_number":135,"context_line":"it includes \u0027port_security\u0027 by defalut. If you want to remove all the extension"},{"line_number":136,"context_line":"drivers even include the \u0027port_security\u0027, set `Q_ML2_PLUGIN_EXT_DRIVERS` to"},{"line_number":137,"context_line":"blank."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a016987_cf8feeca","line":134,"updated":"2015-05-18 04:57:14.000000000","message":"\"Note that extension drivers for the\"","commit_id":"e704217cdd7474c6cc9ee58d6d8418d4ae1d7647"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"8f3f84cd423184b155082ba297c8c3fd2174b17e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"subnet that exists in the private RFC1918 address space - however in"},{"line_number":132,"context_line":"in a real setup FLOATING_RANGE would be a public IP address range."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Note extension driver of ML2 plugin is set by `Q_ML2_PLUGIN_EXT_DRIVERS`, and"},{"line_number":135,"context_line":"it includes \u0027port_security\u0027 by defalut. If you want to remove all the extension"},{"line_number":136,"context_line":"drivers even include the \u0027port_security\u0027, set `Q_ML2_PLUGIN_EXT_DRIVERS` to"},{"line_number":137,"context_line":"blank."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a016987_b205397b","line":134,"in_reply_to":"7a016987_cf8feeca","updated":"2015-05-18 06:16:38.000000000","message":"Done","commit_id":"e704217cdd7474c6cc9ee58d6d8418d4ae1d7647"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d8750507a18503cbf875adeb56c2fe6434328f74","unresolved":false,"context_lines":[{"line_number":132,"context_line":"in a real setup FLOATING_RANGE would be a public IP address range."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Note extension driver of ML2 plugin is set by `Q_ML2_PLUGIN_EXT_DRIVERS`, and"},{"line_number":135,"context_line":"it includes \u0027port_security\u0027 by defalut. If you want to remove all the extension"},{"line_number":136,"context_line":"drivers even include the \u0027port_security\u0027, set `Q_ML2_PLUGIN_EXT_DRIVERS` to"},{"line_number":137,"context_line":"blank."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a016987_0f8626b9","line":135,"updated":"2015-05-18 04:57:14.000000000","message":"\"default\"","commit_id":"e704217cdd7474c6cc9ee58d6d8418d4ae1d7647"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"8f3f84cd423184b155082ba297c8c3fd2174b17e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"in a real setup FLOATING_RANGE would be a public IP address range."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Note extension driver of ML2 plugin is set by `Q_ML2_PLUGIN_EXT_DRIVERS`, and"},{"line_number":135,"context_line":"it includes \u0027port_security\u0027 by defalut. If you want to remove all the extension"},{"line_number":136,"context_line":"drivers even include the \u0027port_security\u0027, set `Q_ML2_PLUGIN_EXT_DRIVERS` to"},{"line_number":137,"context_line":"blank."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a016987_9208fd92","line":135,"in_reply_to":"7a016987_0f8626b9","updated":"2015-05-18 06:16:38.000000000","message":"Done","commit_id":"e704217cdd7474c6cc9ee58d6d8418d4ae1d7647"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d8750507a18503cbf875adeb56c2fe6434328f74","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Note extension driver of ML2 plugin is set by `Q_ML2_PLUGIN_EXT_DRIVERS`, and"},{"line_number":135,"context_line":"it includes \u0027port_security\u0027 by defalut. If you want to remove all the extension"},{"line_number":136,"context_line":"drivers even include the \u0027port_security\u0027, set `Q_ML2_PLUGIN_EXT_DRIVERS` to"},{"line_number":137,"context_line":"blank."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Neutron Networking with Open vSwitch and Provider Networks"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a016987_8fc0d6e1","line":136,"updated":"2015-05-18 04:57:14.000000000","message":"(even `port_security`),","commit_id":"e704217cdd7474c6cc9ee58d6d8418d4ae1d7647"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"8f3f84cd423184b155082ba297c8c3fd2174b17e","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Note extension driver of ML2 plugin is set by `Q_ML2_PLUGIN_EXT_DRIVERS`, and"},{"line_number":135,"context_line":"it includes \u0027port_security\u0027 by defalut. If you want to remove all the extension"},{"line_number":136,"context_line":"drivers even include the \u0027port_security\u0027, set `Q_ML2_PLUGIN_EXT_DRIVERS` to"},{"line_number":137,"context_line":"blank."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Neutron Networking with Open vSwitch and Provider Networks"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a016987_72ffc167","line":136,"in_reply_to":"7a016987_8fc0d6e1","updated":"2015-05-18 06:16:38.000000000","message":"Done","commit_id":"e704217cdd7474c6cc9ee58d6d8418d4ae1d7647"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"983271abdabebc2024891e420ce8840ac43f6609","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_85c2fe82","line":35,"updated":"2015-03-09 09:40:40.000000000","message":"can you provide a way to specify empty list?\neg. ${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}","commit_id":"32baca0d20781f1a30eb27578fecc8fe26bc0d68"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"79c0ac2d1d8783f451763c2ade2c22bdf1c444dc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a80dd14_12d6eec5","line":35,"in_reply_to":"9a80dd14_85c2fe82","updated":"2015-03-11 06:53:14.000000000","message":"Done","commit_id":"32baca0d20781f1a30eb27578fecc8fe26bc0d68"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"94a99eafaf97fecaa27ffdf5387438c15c95edd2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_34880722","line":35,"updated":"2015-03-12 06:09:32.000000000","message":"Are there clear reasons for port_security to be default? I guess default of the parameter is empty list. Even if users don\u0027t need port_security, the patch force the users to set Q_ML2_PLUGIN_EXT_DRIVERS\u003d\"\" to local.conf.","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cb2d2b983d6037044f76ac3bdc91ffa603a46ca6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aaa499b_bd10c24f","line":35,"in_reply_to":"1a6ced46_c5455618","updated":"2015-04-13 06:38:39.000000000","message":"sorry for late reply.\nas devstack is used for development and testing as well, it\u0027s better to have a way to specify empty.\non the other hand, i don\u0027t see any advantage of \":-\".","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"affaa516b185b1ca050f2f6b3de5b19771c24f6f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dac4157f_207a3525","line":35,"in_reply_to":"7aaa499b_bd10c24f","updated":"2015-04-21 04:23:46.000000000","message":"If you really want to remove your worry, port_security should not be default in devstack. Default value of extension_drivers is empty in ml2. So empty should be set .\n\nQ_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-}","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c7a6073131d125d5412bc13dfa2d7999a2c9397","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_d099576f","line":35,"in_reply_to":"9a80dd14_0a5912fe","updated":"2015-03-12 17:54:49.000000000","message":"With port security extension enabled the behavior keeps unchanged from the current existing one as long as the user doesn\u0027t set its property explicitly.\nThose who don\u0027t need the extension don\u0027t have to set the configuration value to \"\" explicitly. Just they use their local.conf as is.","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"4fad6b672b8cb398c2b04fe311f5d12eb0f99645","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a6ced46_c5455618","line":35,"in_reply_to":"9a80dd14_3251bf36","updated":"2015-03-24 08:28:02.000000000","message":"the previous way is like your advice, and it could not provide user a choice to make the ext driver list empty.","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"cc2a4f4865acfed03bdbfc8a2dc4cdcecab25f35","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_3251bf36","line":35,"in_reply_to":"9a80dd14_32f53f57","updated":"2015-03-13 05:53:24.000000000","message":"I know it. But I think the change was unnecessary.","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"2fdde8d1bb199af8d4d0f5a6fabaaadb6c26b585","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_9490c996","line":35,"in_reply_to":"9a80dd14_34880722","updated":"2015-03-12 10:41:02.000000000","message":"as the commit message described\n\n\"this will be a default extension driver as a example. And also, if not set it by default, networks like public/private which are created after the neutron-db-manage\u0027s update, will not include the port-sec value.\"\n\nThat setting it to deafault not only makes it as a example of extension driver, but also mean if leave ext driver empty as before, although the neutron-db-manage has upgrade the db  by using this file, the created public/private networks will not include the right value.\nThen when user want to add port-sec, besides add port-sec manually in conf file, they will also try to convert the public/private network db manually too.\n\nhttps://review.openstack.org/#/c/126552/15/neutron/db/migration/alembic_migrations/versions/35a0f3365720_add_port_security_in_ml2.py","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"118cd75a25e4ddf007b66a4252f2c6d0ecca0d36","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_0a5912fe","line":35,"in_reply_to":"9a80dd14_9490c996","updated":"2015-03-12 11:33:04.000000000","message":"I read the spec and the neutron patch. I don\u0027t understand completely the extension, but I guess the extension is needed for service vm. Could you show something describing the extension as default in ml2 or explain almost ml2 users use the extension? I apologize if my understand is wrong.","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"01454d561664e2bcd7622b09e0edb26066376fa8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_32f53f57","line":35,"in_reply_to":"9a80dd14_9e73574d","updated":"2015-03-13 05:43:27.000000000","message":"it reflect to the comments before.\n\nhttps://review.openstack.org/#/c/162063/3/lib/neutron_plugins/ml2","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d72c2f7a88306bbd1cbcfea49f61b140e8ce96","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a80dd14_9e73574d","line":35,"in_reply_to":"9a80dd14_d099576f","updated":"2015-03-13 04:56:58.000000000","message":"I got it clearly. Thank you, Yamahata. Why don\u0027t you use following configure if the users needn\u0027t use Q_ML2_PLUGIN_EXT_DRIVERS\u003d\"\"?\n\nQ_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security}","commit_id":"251d2c5f47c38cf54417b07e1be5ee8c7a4561a6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1a3280563001bd339d1945e88f846fbd26157e3b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7aaa499b_fdf76af3","line":35,"updated":"2015-04-13 06:40:27.000000000","message":"commented on PS4","commit_id":"ed0e24def9bf87d80e26df71db924e9c276a91f9"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"9eff93149dc5af60375839b616a899632a980070","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5aa745d1_3abcbf6b","line":35,"in_reply_to":"7aaa499b_fdf76af3","updated":"2015-04-16 09:32:11.000000000","message":"Done","commit_id":"ed0e24def9bf87d80e26df71db924e9c276a91f9"},{"author":{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},"change_message_id":"34b51e4ee50c4bacfb8d8aade3994840ee7b8f43","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"dac4157f_d8938df9","line":35,"updated":"2015-04-20 14:50:40.000000000","message":"Missed colon in ${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}.\nGuess this should be Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security}","commit_id":"01bcde3cac2f7a5f7786bb012c13d9289d2e9682"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c2e130071c2b013a991ed7240a0a6b475f389983","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"dac4157f_20a11595","line":35,"in_reply_to":"dac4157f_d8938df9","updated":"2015-04-21 04:24:24.000000000","message":"commented on PS4","commit_id":"01bcde3cac2f7a5f7786bb012c13d9289d2e9682"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2395511805b1e7acb5c349d369f1bac3c41be19a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Q_ML2_PLUGIN_VXLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VXLAN_TYPE_OPTIONS:-vni_ranges\u003d1001:2000}"},{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load, only ovs agent support it till now"},{"line_number":35,"context_line":"if [ \"$Q_AGENT\" \u003d\u003d \"openvswitch\" ]; then"},{"line_number":36,"context_line":"    Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":37,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a0c5dc1_3fbccd6b","line":34,"updated":"2015-05-12 11:51:35.000000000","message":"doesn\u0027t it work for LB?","commit_id":"1dcc8d7a9e8abf107f7bd02a19db746e1b100619"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"6433f7035b2803002bb9937ad667363343d0992d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Q_ML2_PLUGIN_VXLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VXLAN_TYPE_OPTIONS:-vni_ranges\u003d1001:2000}"},{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load, only ovs agent support it till now"},{"line_number":35,"context_line":"if [ \"$Q_AGENT\" \u003d\u003d \"openvswitch\" ]; then"},{"line_number":36,"context_line":"    Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":37,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a0c5dc1_0ae645b4","line":34,"in_reply_to":"9a0c5dc1_3fbccd6b","updated":"2015-05-13 03:35:48.000000000","message":"Thanks for pointing it out, LB is supported by iptables. \n\nemm... it\u0027s over protected it here. I thought the BP of the feature mentioned ovs, so... \n\nI will remove it.","commit_id":"1dcc8d7a9e8abf107f7bd02a19db746e1b100619"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"89581e86528213d1d2bddbd5ffe8723ea772d672","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Default VLAN TypeDriver options"},{"line_number":33,"context_line":"Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-}"},{"line_number":34,"context_line":"# List of extension drivers to load"},{"line_number":35,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS-port_security}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# L3 Plugin to load for ML2"},{"line_number":38,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a0c5dc1_41a423a5","line":35,"updated":"2015-05-13 05:49:11.000000000","message":"you really want \"-\" and not \":-\"?","commit_id":"876cb1aacbbf87242b27eed5a4dbe04206bc38ac"}]}