)]}'
{"tools/xen/install_os_domU.sh":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"08c97e3b7c2f6e70fa3097f9c109606b56a9163d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        -n \"$UBUNTU_INST_BRIDGE_OR_NET_NAME\" \\"},{"line_number":228,"context_line":"        -l \"$GUEST_NAME\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    set_vm_memory \"$GUEST_NAME\" \"1024\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    xe vm-start vm\u003d\"$GUEST_NAME\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_d3276110","line":230,"updated":"2015-03-09 08:03:29.000000000","message":"Please explaing why you did not changed the variable default,\nit is used only in this file.\n\nPlease explain why is it better change it in the local.conf.\n\nHard-coding looks like a bad idea, so -1.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"d4e6dc488366e9e9be1fe5e6a150cfdbd0294a0a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        -n \"$UBUNTU_INST_BRIDGE_OR_NET_NAME\" \\"},{"line_number":228,"context_line":"        -l \"$GUEST_NAME\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    set_vm_memory \"$GUEST_NAME\" \"1024\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    xe vm-start vm\u003d\"$GUEST_NAME\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_05c1ae53","line":230,"in_reply_to":"9a80dd14_537b71f4","updated":"2015-03-09 09:46:56.000000000","message":"The installation of the Ubuntu VM that houses devstack can take a substantial amount of time, so we added a shortcut so a JEOS can be created and used instead.\n\nThis 1024MB is the minimal amount of ram needed by the JEOS, and having it set to the default of 4096 means that you can\u0027t have both the JEOS and the final devstack vm running on an 8GB machine.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"9e320274f631b3ce9a5487c5339b122ad1ae40e0","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        -n \"$UBUNTU_INST_BRIDGE_OR_NET_NAME\" \\"},{"line_number":228,"context_line":"        -l \"$GUEST_NAME\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    set_vm_memory \"$GUEST_NAME\" \"1024\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    xe vm-start vm\u003d\"$GUEST_NAME\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_537b71f4","line":230,"in_reply_to":"9a80dd14_d3276110","updated":"2015-03-09 08:04:27.000000000","message":"Please explain why is it better than changeing it in the local.conf.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"d4e6dc488366e9e9be1fe5e6a150cfdbd0294a0a","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    vm_uuid\u003d$(xe vm-install template\u003d\"$TNAME\" new-name-label\u003d\"$GUEST_NAME\")"},{"line_number":249,"context_line":"fi"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"if [ -n \"${EXIT_AFTER_JEOS_INSTALLATION:-}\" ]; then"},{"line_number":252,"context_line":"    echo \"User requested to quit after JEOS instalation\""},{"line_number":253,"context_line":"    exit 0"},{"line_number":254,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_25b4f2f0","line":251,"updated":"2015-03-09 09:46:56.000000000","message":"Execution can indeed stop at the EXIT_AFTER_JEOS_INSTALLATION stage specifically so an export can be made of the JEOS for re-importing at a later time for other devstack runs.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"08c97e3b7c2f6e70fa3097f9c109606b56a9163d","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    vm_uuid\u003d$(xe vm-install template\u003d\"$TNAME\" new-name-label\u003d\"$GUEST_NAME\")"},{"line_number":249,"context_line":"fi"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"if [ -n \"${EXIT_AFTER_JEOS_INSTALLATION:-}\" ]; then"},{"line_number":252,"context_line":"    echo \"User requested to quit after JEOS instalation\""},{"line_number":253,"context_line":"    exit 0"},{"line_number":254,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_b3010d6c","line":251,"updated":"2015-03-09 08:03:29.000000000","message":"The execution may stop here.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"08c97e3b7c2f6e70fa3097f9c109606b56a9163d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"$THIS_DIR/prepare_guest_template.sh \"$GUEST_NAME\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"# Set virtual machine parameters"},{"line_number":265,"context_line":"set_vm_memory \"$GUEST_NAME\" \"$OSDOMU_MEM_MB\""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Max out VCPU count for better performance"},{"line_number":268,"context_line":"max_vcpus \"$GUEST_NAME\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_730b158e","line":265,"updated":"2015-03-09 08:03:29.000000000","message":"This will override the previous settings.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"d4e6dc488366e9e9be1fe5e6a150cfdbd0294a0a","unresolved":false,"context_lines":[{"line_number":262,"context_line":"$THIS_DIR/prepare_guest_template.sh \"$GUEST_NAME\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"# Set virtual machine parameters"},{"line_number":265,"context_line":"set_vm_memory \"$GUEST_NAME\" \"$OSDOMU_MEM_MB\""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Max out VCPU count for better performance"},{"line_number":268,"context_line":"max_vcpus \"$GUEST_NAME\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_45856605","line":265,"in_reply_to":"9a80dd14_730b158e","updated":"2015-03-09 09:46:56.000000000","message":"This is intentional; after the JEOS has been imported (the else block at line 244) we always need to ensure that the correct amount of RAM is set.\nBecause the JEOS could have been created with an earlier version of devstack a different amount of RAM cound be required, so we need to set the amount of memory we\u0027re actually going to use on this run here.","commit_id":"1340ee72bfefa5a4fd0930cb90987275301280c8"}]}