)]}'
{"id":"openstack%2Fdevstack~164938","triplet_id":"openstack%2Fdevstack~master~I6e202e01e627a161208b4c3745cfe5b8ef2ebe90","project":"openstack/devstack","branch":"master","topic":"bug/1373513","hashtags":[],"change_id":"I6e202e01e627a161208b4c3745cfe5b8ef2ebe90","subject":"Use global_filter to avoid scan of missing devs","status":"ABANDONED","created":"2015-03-17 03:32:25.000000000","updated":"2015-03-17 05:36:14.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3c72a373b2c57f9a2d702354ab72bce5b532ddf9","_number":164938,"virtual_id_number":164938,"owner":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2015-03-17 04:32:22.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-03-17 04:55:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-03-17 04:23:47.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-17 04:32:22.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-03-17 04:55:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"918c9fb2c963244e860239f970fa623fce525ce8","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-03-17 03:32:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff5629a52a6d74faf9f49611707e0a287a0351ef","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-03-17 04:23:47.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"8af44f5d13c424999afa56cb864cf95ad27a6df6","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-03-17 04:32:22.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/38/164938/1/13552/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"dcd2e451a009fc5d16e2c4e1fd5bc73d8450fa9e","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-03-17 04:51:19.000000000","message":"Patch Set 1:\n\nWell this is disappointing, the global as it\u0027s name implies only works in a global capacity.  In other words putting it in the local version of the lvm.conf doesn\u0027t seem to work, it must be in the base /etc/lvm/lvm.conf.\n\nUnless my custom lvm conf isn\u0027t working at all... sigh","accounts_in_message":[],"_revision_number":1},{"id":"60b7e301101b600ff0515847e9d37d372d27a603","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 04:55:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/38/164938/1/check/check-tempest-dsvm-full/b9c348c/ : SUCCESS in 38m 00s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/38/164938/1/check/check-tempest-dsvm-postgres-full/3e97818/ : SUCCESS in 46m 34s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/38/164938/1/check/check-tempest-dsvm-neutron-full/893e5c8/ : SUCCESS in 47m 47s\n- check-grenade-dsvm http://logs.openstack.org/38/164938/1/check/check-grenade-dsvm/e760cdc/ : SUCCESS in 46m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/38/164938/1/check/gate-tempest-dsvm-large-ops/211e3f0/ : SUCCESS in 22m 24s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/38/164938/1/check/gate-tempest-dsvm-neutron-large-ops/07d1af9/ : SUCCESS in 25m 37s\n- gate-devstack-bashate http://logs.openstack.org/38/164938/1/check/gate-devstack-bashate/84d4efc/ : SUCCESS in 15s\n- gate-devstack-unit-tests http://logs.openstack.org/38/164938/1/check/gate-devstack-unit-tests/276c1bf/ : SUCCESS in 18s\n- check-devstack-dsvm-cells http://logs.openstack.org/38/164938/1/check/check-devstack-dsvm-cells/26154f7/ : SUCCESS in 20m 51s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/38/164938/1/check/check-grenade-dsvm-partial-ncpu/23e5989/ : SUCCESS in 43m 52s\n- check-swift-dsvm-functional http://logs.openstack.org/38/164938/1/check/check-swift-dsvm-functional/3d0be52/ : SUCCESS in 25m 18s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/38/164938/1/check/check-tempest-dsvm-ironic-pxe_ssh/d1319d5/ : SUCCESS in 36m 28s\n- check-devstack-dsvm-updown http://logs.openstack.org/38/164938/1/check/check-devstack-dsvm-updown/236893d/ : SUCCESS in 21m 02s\n- check-tempest-dsvm-f21 http://logs.openstack.org/38/164938/1/check/check-tempest-dsvm-f21/bb1a014/ : SUCCESS in 44m 05s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/38/164938/1/check/check-tempest-dsvm-centos7/6d5bb46/ : SUCCESS in 56m 36s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/38/164938/1/check/gate-devstack-publish-docs/c4193b4//doc/build/html/ : SUCCESS in 2m 21s\n- check-grenade-dsvm-neutron http://logs.openstack.org/38/164938/1/check/check-grenade-dsvm-neutron/1aa4e4c/ : SUCCESS in 1h 11m 07s","accounts_in_message":[],"_revision_number":1},{"id":"bab389ac9df829a4f43e936a4fcc824125987867","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-03-17 05:36:14.000000000","message":"Abandoned\n\nSummary here:\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-March/059231.html","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0c70ad4c520367e16762d4e161e5b96af9c28414","revisions":{"0c70ad4c520367e16762d4e161e5b96af9c28414":{"kind":"REWORK","_number":1,"created":"2015-03-17 03:32:25.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/38/164938/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/38/164938/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/164938/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/164938/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/164938/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/38/164938/1"}}},"commit":{"parents":[{"commit":"5c619b43dbd9a649cc7bad3f8527c8b9ded1d631","subject":"Merge \"Install rsync-daemon on f22\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5c619b43dbd9a649cc7bad3f8527c8b9ded1d631"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2015-03-17 03:20:21.000000000","tz":-360},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2015-03-17 03:20:21.000000000","tz":-360},"subject":"Use global_filter to avoid scan of missing devs","message":"Use global_filter to avoid scan of missing devs\n\nA while back I added an lvm.conf file with a device filter setting\nto try and clean up the LVM hangs in the gate:\n  (commit 0b9e76f280208b5b5ad54bb6fbc4133e63037286)\n\nIt turns out this was only part of the problem, the other problem\nis that on an LVS/VGS command LVM will always poke at block devices\non the system to see if they belong to it.  There are a number of\nsituations in gate tests where /dev/sdX devices are created and\ndeleted and the result is that we hit situations where LVM tries\nto open up devices to check them even if they\u0027ve been removed.\n\nThis typically happens because udev hasn\u0027t updated yet, but the end\nresult is we have a blocking open call from LVM that takes approx\n60 seconds to time out and fail.\n\nThe filter\u003d only tells LVM to return devices from it\u0027s list that pass\nthe filter, but sadly it doesn\u0027t tell LVM that what it should or\nshouldn\u0027t try to query via open calls. For that we need the global_filter.\n\nThis does in fact seem to eliminate our super long LVS/VGS command times\non several runs against my local setup.\n\nThis patch just adds an additional sed command to the cinder_backend lvm\nsetup script and makes the filter we already set global.\n\nNOTE:\nAnother possible solution is to enable the lvmetad in our lvm.conf file.\nThis essentially tells LVM to store the device data when VG\u0027s or PV\u0027s are\nadded, this means we don\u0027t do the open at all which is likely a good\nimprovement that should be looked at.\n\nThere\u0027s some concern here though because it modifies the behavior of activate,\nso I\u0027d like to spend some time looking at that more closely and test things\nout before considering using that instead of filters.\n\nChange-Id: I6e202e01e627a161208b4c3745cfe5b8ef2ebe90\nCloses-Bug: #1373513\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0c70ad4c520367e16762d4e161e5b96af9c28414"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0c70ad4c520367e16762d4e161e5b96af9c28414"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}