)]}'
{"lib/swift":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"5f0dde5f25595943af5de785dd1e1c845df710c5","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    # Create SWIFT_DATA_DIR if does not exist and chmod to STACK_USER"},{"line_number":517,"context_line":"    if [ ! -d ${SWIFT_DATA_DIR} ]; then"},{"line_number":518,"context_line":"        sudo mkdir ${SWIFT_DATA_DIR}"},{"line_number":519,"context_line":"        sudo chown ${STACK_USER}: ${SWIFT_DATA_DIR}"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"9a80dd14_02c7e945","line":518,"updated":"2015-03-19 21:59:54.000000000","message":"mkdir -p ?","commit_id":"28464b138aabadbc1355c26960748b85b636a4bd"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"05027ad7cb5524dbc5652832ccbd689842989a34","unresolved":false,"context_lines":[{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    local swift_log_dir\u003d${SWIFT_DATA_DIR}/logs"},{"line_number":523,"context_line":"    rm -rf ${swift_log_dir}"},{"line_number":524,"context_line":"    mkdir -p ${swift_log_dir}/hourly"},{"line_number":525,"context_line":"    sudo chown -R ${STACK_USER}:adm ${swift_log_dir}"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    if [[ $SYSLOG !\u003d \"False\" ]]; then"}],"source_content_type":"text/x-swift","patch_set":1,"id":"9a80dd14_c2ff9164","line":524,"updated":"2015-03-19 22:01:31.000000000","message":"oops sorry forget about what i said earlier that mkdir -p here would already take care of creating SWIFT_DATA_DIR so i believe that patch is not needed","commit_id":"28464b138aabadbc1355c26960748b85b636a4bd"},{"author":{"_account_id":6672,"name":"Geronimo Orozco","email":"geronimo.orozco@intel.com","username":"gorozco"},"change_message_id":"533e6ad63b7a4ea586f3b48595410494472252ee","unresolved":false,"context_lines":[{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    local swift_log_dir\u003d${SWIFT_DATA_DIR}/logs"},{"line_number":523,"context_line":"    rm -rf ${swift_log_dir}"},{"line_number":524,"context_line":"    mkdir -p ${swift_log_dir}/hourly"},{"line_number":525,"context_line":"    sudo chown -R ${STACK_USER}:adm ${swift_log_dir}"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    if [[ $SYSLOG !\u003d \"False\" ]]; then"}],"source_content_type":"text/x-swift","patch_set":1,"id":"9a80dd14_c2e95180","line":524,"in_reply_to":"9a80dd14_c2ff9164","updated":"2015-03-19 22:46:05.000000000","message":"If you take a look at https://bugs.launchpad.net/devstack/+bug/1302893\n\nThere might be a problem if SWIFT_DATA_DIR is defined on local.conf to point to a location where the STACK_USER does not have permissions.\n\nie:\ncat local.conf\n\nSWIFT_DATA_DIR\u003d/data\n\nThen we need to make sure SWIFT_DATA_DIR exists before the logs tries to create the logs.","commit_id":"28464b138aabadbc1355c26960748b85b636a4bd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8174e1629f3b87c32bb2c2ca2e6772ad0b89ecc3","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    # Create SWIFT_DATA_DIR if does not exist and chmod to STACK_USER"},{"line_number":517,"context_line":"    if [ ! -d ${SWIFT_DATA_DIR} ]; then"},{"line_number":518,"context_line":"        sudo mkdir -p ${SWIFT_DATA_DIR}"},{"line_number":519,"context_line":"        sudo chown ${STACK_USER}: ${SWIFT_DATA_DIR}"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    local swift_log_dir\u003d${SWIFT_DATA_DIR}/logs"}],"source_content_type":"text/x-swift","patch_set":2,"id":"9a80dd14_4e0ae320","line":519,"updated":"2015-03-20 03:31:17.000000000","message":"please use isntall(1) like in I9c8f48854d5bc443cc187df0948c28b82c4d2838","commit_id":"41bf52aeb9be4d04d73d71a82ee7cd3cacdeb68e"},{"author":{"_account_id":6672,"name":"Geronimo Orozco","email":"geronimo.orozco@intel.com","username":"gorozco"},"change_message_id":"16be8bc8e641fa98e101dd60c728edc3e73fba7d","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    # Create SWIFT_DATA_DIR if does not exist and chmod to STACK_USER"},{"line_number":517,"context_line":"    if [ ! -d ${SWIFT_DATA_DIR} ]; then"},{"line_number":518,"context_line":"        sudo mkdir -p ${SWIFT_DATA_DIR}"},{"line_number":519,"context_line":"        sudo chown ${STACK_USER}: ${SWIFT_DATA_DIR}"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    local swift_log_dir\u003d${SWIFT_DATA_DIR}/logs"}],"source_content_type":"text/x-swift","patch_set":2,"id":"9a80dd14_89691e8e","line":519,"in_reply_to":"9a80dd14_4e0ae320","updated":"2015-03-20 15:43:16.000000000","message":"thanks for the suggestion :-) will do","commit_id":"41bf52aeb9be4d04d73d71a82ee7cd3cacdeb68e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"288bb5c156f0b262ff9ca1617dcb983206cb92d1","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        fi"},{"line_number":507,"context_line":"    fi"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    local user_group\u003d$(id -g ${STACK_USER})"},{"line_number":510,"context_line":"    sudo install -d -o ${STACK_USER} -g ${user_group} ${SWIFT_DATA_DIR}"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    local swift_log_dir\u003d${SWIFT_DATA_DIR}/logs"}],"source_content_type":"text/x-swift","patch_set":3,"id":"9aa53dc9_e687e6d5","line":509,"updated":"2015-04-06 23:16:50.000000000","message":"we don\u0027t really need this, or the adm group ownership below, but not worth another review","commit_id":"2f6576bfaf7f43d9bf820e3e5ecc0b7fd136ce3c"}]}