)]}'
{"extras.d/70-trove.sh":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"97067d69bbea2af41b4e6792af314d3a85f17d02","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # finish the last step in trove network configuration"},{"line_number":25,"context_line":"        echo_summary \"Finalizing Trove Network Configuration\""},{"line_number":26,"context_line":"        finalize_trove_network"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # Start the trove API and trove taskmgr components"},{"line_number":29,"context_line":"        echo_summary \"Starting Trove\""},{"line_number":30,"context_line":"        start_trove"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9aa53dc9_870d6a39","line":27,"updated":"2015-04-08 13:11:41.000000000","message":"if is_service_enabled neutron; then\n    finalize_trove_network\nelse\n    echo \"finalize_trove_network: Neutron is not enabled. Nothing to do.\"\nfi","commit_id":"a17c95180cac449624a9bdd6bde921f42ddfce2d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bb87074dfec1cf4d7741fa84a380bc0583904b7e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # finish the last step in trove network configuration"},{"line_number":25,"context_line":"        echo_summary \"Finalizing Trove Network Configuration\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\tif is_service_enabled neutron; then"},{"line_number":28,"context_line":"            echo \"finalize_trove_network: Neutron is enabled.\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"            finalize_trove_network"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9aa53dc9_5121499e","line":27,"updated":"2015-04-08 20:26:20.000000000","message":"Replace tab with spaces","commit_id":"28223355671070beee20e0f7063f2a599610c31f"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bb87074dfec1cf4d7741fa84a380bc0583904b7e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            echo \"finalize_trove_network: Neutron is enabled.\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"            finalize_trove_network"},{"line_number":31,"context_line":"\telse"},{"line_number":32,"context_line":"            echo \"finalize_trove_network: Neutron is not enabled. Nothing to do.\""},{"line_number":33,"context_line":"\tfi"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9aa53dc9_d13559da","line":31,"updated":"2015-04-08 20:26:20.000000000","message":"ditto","commit_id":"28223355671070beee20e0f7063f2a599610c31f"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bb87074dfec1cf4d7741fa84a380bc0583904b7e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            finalize_trove_network"},{"line_number":31,"context_line":"\telse"},{"line_number":32,"context_line":"            echo \"finalize_trove_network: Neutron is not enabled. Nothing to do.\""},{"line_number":33,"context_line":"\tfi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Start the trove API and trove taskmgr components"},{"line_number":36,"context_line":"        echo_summary \"Starting Trove\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9aa53dc9_7151ed0d","line":33,"updated":"2015-04-08 20:26:20.000000000","message":"ditto","commit_id":"28223355671070beee20e0f7063f2a599610c31f"}],"lib/trove":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bce0d1a4f338fa0580b526e5963d8f62df6a2a54","unresolved":false,"context_lines":[{"line_number":241,"context_line":"\tiniset $TROVE_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"\tiniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":244,"context_line":"\tiniset $TROVE_TASKMANAGER_CONF mysql tcp_ports 22,3306"},{"line_number":245,"context_line":"    else"},{"line_number":246,"context_line":"\techo \"finalize_trove_network: Neutron is not enabled. Nothing to do.\""},{"line_number":247,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a6ced46_ecbf8da8","line":244,"updated":"2015-03-24 14:24:12.000000000","message":"This doesn\u0027t seem Neutron specific; should we put this outside the entire \u0027if\u0027 statement?","commit_id":"87d05bd5289ccdbf7a9102a8ea54314331c46d9a"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"15afd12353f5c467d0dd67d36df9143c0e3afc43","unresolved":false,"context_lines":[{"line_number":241,"context_line":"\tiniset $TROVE_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"\tiniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":244,"context_line":"\tiniset $TROVE_TASKMANAGER_CONF mysql tcp_ports 22,3306"},{"line_number":245,"context_line":"    else"},{"line_number":246,"context_line":"\techo \"finalize_trove_network: Neutron is not enabled. Nothing to do.\""},{"line_number":247,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a6ced46_97af02e3","line":244,"in_reply_to":"1a6ced46_ecbf8da8","updated":"2015-03-24 14:31:22.000000000","message":"Just spoke with Amrith, this *is* only needed for Neutron","commit_id":"87d05bd5289ccdbf7a9102a8ea54314331c46d9a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"97067d69bbea2af41b4e6792af314d3a85f17d02","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# finalize_trove_network() - do the last thing(s) before starting Trove"},{"line_number":232,"context_line":"function finalize_trove_network {"},{"line_number":233,"context_line":"    if is_service_enabled neutron; then"},{"line_number":234,"context_line":"        echo \"finalize_trove_network: Neutron is enabled.\""},{"line_number":235,"context_line":"        management_network_id\u003d$(neutron --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD net-list | grep \u0027private\u0027 | awk \u0027{print $2}\u0027)"},{"line_number":236,"context_line":"        echo \"finalize_trove_network: found network id $management_network_id\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9aa53dc9_071a7a6e","line":233,"updated":"2015-04-08 13:11:41.000000000","message":"It\u0027s better to move this if-statement to 70-trove.sh","commit_id":"a17c95180cac449624a9bdd6bde921f42ddfce2d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"97067d69bbea2af41b4e6792af314d3a85f17d02","unresolved":false,"context_lines":[{"line_number":232,"context_line":"function finalize_trove_network {"},{"line_number":233,"context_line":"    if is_service_enabled neutron; then"},{"line_number":234,"context_line":"        echo \"finalize_trove_network: Neutron is enabled.\""},{"line_number":235,"context_line":"        management_network_id\u003d$(neutron --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD net-list | grep \u0027private\u0027 | awk \u0027{print $2}\u0027)"},{"line_number":236,"context_line":"        echo \"finalize_trove_network: found network id $management_network_id\""},{"line_number":237,"context_line":"        iniset $TROVE_CONF DEFAULT network_label_regex .*"},{"line_number":238,"context_line":"        iniset $TROVE_CONF DEFAULT ip_regex .*"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9aa53dc9_c72a527e","line":235,"updated":"2015-04-08 13:11:41.000000000","message":"Why does you use admin account? It also isn\u0027t good using \u0027private\u0027. You can use $PRIVATE_NETWORK_NAME.","commit_id":"a17c95180cac449624a9bdd6bde921f42ddfce2d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3f9dc3ce1bc5d311146cefb16a4fabfd2038ad77","unresolved":false,"context_lines":[{"line_number":232,"context_line":"function finalize_trove_network {"},{"line_number":233,"context_line":"    if is_service_enabled neutron; then"},{"line_number":234,"context_line":"        echo \"finalize_trove_network: Neutron is enabled.\""},{"line_number":235,"context_line":"        management_network_id\u003d$(neutron --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD net-list | grep \u0027private\u0027 | awk \u0027{print $2}\u0027)"},{"line_number":236,"context_line":"        echo \"finalize_trove_network: found network id $management_network_id\""},{"line_number":237,"context_line":"        iniset $TROVE_CONF DEFAULT network_label_regex .*"},{"line_number":238,"context_line":"        iniset $TROVE_CONF DEFAULT ip_regex .*"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9aa53dc9_5f6f15c5","line":235,"in_reply_to":"9aa53dc9_c72a527e","updated":"2015-04-08 19:01:23.000000000","message":"I\u0027m just doing the same thing that the current trove setup (in trove-integration) does.\n\nWhat do you recommend?","commit_id":"a17c95180cac449624a9bdd6bde921f42ddfce2d"}]}