)]}'
{"doc/source/plugins.rst":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b4432c0bbff7e8a8ed89bed068fc5892a751b683","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  Be careful to allow users to override global-variables for"},{"line_number":117,"context_line":"  customizing their environment.  Usually it is best to provide a"},{"line_number":118,"context_line":"  default value only if the variable is unset;"},{"line_number":119,"context_line":"  e.g. in bash syntax ``FOO\u003d${FOO:-default}``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- ``plugin.sh`` - the actual plugin. It will be executed by devstack"},{"line_number":122,"context_line":"  during it\u0027s run. The run order will be done in the registration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_76e8a810","line":119,"updated":"2015-03-25 05:44:08.000000000","message":"this description seems confusing.\n\n* FOO\u003d${FOO:-default} actually means \"only if the variable is unset or empty\"\n* \"only if the variable is unset\" is FOO\u003d${FOO-default}","commit_id":"94dd40ed27abaf9ddeb9aed001aad61f566cd33e"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"ae9d6ba230891ba5ff1362452c6855105a3f8c4f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  Be careful to allow users to override global-variables for"},{"line_number":117,"context_line":"  customizing their environment.  Usually it is best to provide a"},{"line_number":118,"context_line":"  default value only if the variable is unset;"},{"line_number":119,"context_line":"  e.g. in bash syntax ``FOO\u003d${FOO:-default}``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- ``plugin.sh`` - the actual plugin. It will be executed by devstack"},{"line_number":122,"context_line":"  during it\u0027s run. The run order will be done in the registration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_f6de583e","line":119,"in_reply_to":"1a6ced46_76e8a810","updated":"2015-03-25 05:53:24.000000000","message":"I think unset and empty should be the right thing. Since these vars are needed to configure the backend (either in the CI or in the local setup) having the vars empty doesn\u0027t make much sense. With that logic :- is the right thing, but I agree the desc needs to change, good catch by YAMAMOTO","commit_id":"94dd40ed27abaf9ddeb9aed001aad61f566cd33e"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"dfaf38d71c214625e72df1cddfcbcd8a7cbacc8b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  customizing their environment.  Usually it is best to provide a"},{"line_number":118,"context_line":"  default value only if the variable is unset or empty; e.g. in bash"},{"line_number":119,"context_line":"  syntax ``FOO\u003d${FOO:-default}``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- ``plugin.sh`` - the actual plugin. It will be executed by devstack"},{"line_number":122,"context_line":"  during it\u0027s run. The run order will be done in the registration"},{"line_number":123,"context_line":"  order for these plugins, and will occur immediately after all in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a6ced46_93be0c64","line":120,"updated":"2015-03-25 11:10:44.000000000","message":"Per the discussion happenign @ http://lists.openstack.org/pipermail/openstack-dev/2015-March/059861.html i think the above is incorrect. FOO if being a cinder var will be set by lib/cinder and hence the plugin will never be able to set the default value","commit_id":"51c48d4c801fecce9d2486ce956a2602eb8a0ea9"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"c88d5b17516d6ca59fcd0756863a2c6bfcdc3d55","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  customizing their environment.  Usually it is best to provide a"},{"line_number":118,"context_line":"  default value only if the variable is unset or empty; e.g. in bash"},{"line_number":119,"context_line":"  syntax ``FOO\u003d${FOO:-default}``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- ``plugin.sh`` - the actual plugin. It will be executed by devstack"},{"line_number":122,"context_line":"  during it\u0027s run. The run order will be done in the registration"},{"line_number":123,"context_line":"  order for these plugins, and will occur immediately after all in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a6ced46_1604ca48","line":120,"in_reply_to":"1a6ced46_73019005","updated":"2015-03-25 11:37:49.000000000","message":"Hmm agree with you, But maybe we should put a warning not to use the bash default syntax for variables that are set by cinder ? Otherwise folks blindly following this will result in what I resulted @ https://review.openstack.org/167494, what say ?","commit_id":"51c48d4c801fecce9d2486ce956a2602eb8a0ea9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d093c0f00aebb28e257fb126eb7734475cfebc20","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  customizing their environment.  Usually it is best to provide a"},{"line_number":118,"context_line":"  default value only if the variable is unset or empty; e.g. in bash"},{"line_number":119,"context_line":"  syntax ``FOO\u003d${FOO:-default}``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- ``plugin.sh`` - the actual plugin. It will be executed by devstack"},{"line_number":122,"context_line":"  during it\u0027s run. The run order will be done in the registration"},{"line_number":123,"context_line":"  order for these plugins, and will occur immediately after all in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a6ced46_73019005","line":120,"in_reply_to":"1a6ced46_93be0c64","updated":"2015-03-25 11:16:47.000000000","message":"That is really a separate issue to do with ordering.  As a general rule, however, I think you want \u0027settings\u0027 to be over-ridable","commit_id":"51c48d4c801fecce9d2486ce956a2602eb8a0ea9"}]}