)]}'
{"extras.d/99-cpu_map.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8e5300a33becd75d44b742372b49f19b385584ed","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                model\u003d\"done\""},{"line_number":48,"context_line":"            fi"},{"line_number":49,"context_line":"        done \u003c /usr/share/libvirt/cpu_map.xml \u003e tmp_cpu_map.xml"},{"line_number":50,"context_line":"        sudo cp tmp_cpu_map.xml /usr/share/libvirt/cpu_map.xml"},{"line_number":51,"context_line":"        # Do a stop then start as a restart does not appear to be sufficient."},{"line_number":52,"context_line":"        stop_service libvirt-bin"},{"line_number":53,"context_line":"        start_service libvirt-bin"}],"source_content_type":"text/x-sh","patch_set":7,"id":"da9b358b_037853f1","line":50,"updated":"2015-03-30 22:43:28.000000000","message":"use install here","commit_id":"0d942f5515a98ba7cc7226e8417074376fa42a74"}],"tools/cpu_map_update.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c41edbc4040a34a8ab6cacfb48d86f27925a8d75","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def update_cpu_map(tree):"},{"line_number":25,"context_line":"    root \u003d tree.getroot()"},{"line_number":26,"context_line":"    cpus \u003d root#.find(\"cpus\")"},{"line_number":27,"context_line":"    x86 \u003d None"},{"line_number":28,"context_line":"    for arch in cpus.findall(\"arch\"):"},{"line_number":29,"context_line":"        if arch.get(\"name\") \u003d\u003d \"x86\":"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_75ec79c7","line":26,"updated":"2015-04-02 17:40:31.000000000","message":"is the find bit really needed? Also you could just do cpus \u003d tree.getroot()","commit_id":"edd60481682bf2cca061f94f113835922cd79709"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c41edbc4040a34a8ab6cacfb48d86f27925a8d75","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def main():"},{"line_number":74,"context_line":"    if len(sys.argv) !\u003d 2:"},{"line_number":75,"context_line":"        raise Exception(\"Must pass path to cpu_map.xml to update\")"},{"line_number":76,"context_line":"    cpu_map \u003d sys.argv[1]"},{"line_number":77,"context_line":"    tree \u003d ET.parse(cpu_map)"},{"line_number":78,"context_line":"    for model in tree.getroot().iter(\"model\"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_5596154d","line":75,"updated":"2015-04-02 17:40:31.000000000","message":"Well I can be a bit pedantic if you pass in an extra arg by accident this error message doesn\u0027t really apply.\n\nAlso personally I would probably just print the error msg and exit with a non-zero code. Raising an unhandled exception for something like this seems less than ideal to me","commit_id":"edd60481682bf2cca061f94f113835922cd79709"}]}
