)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d24464f5c9d969804364f27e3ee2b49a1a650d56","unresolved":false,"context_lines":[{"line_number":151,"context_line":"# Use namespace or not"},{"line_number":152,"context_line":"Q_USE_NAMESPACE\u003d${Q_USE_NAMESPACE:-True}"},{"line_number":153,"context_line":"# Router ID"},{"line_number":154,"context_line":"Q_ROUTER_ID\u003d${Q_ROUTER_ID:-1064ad16-36b7-4c2f-86f0-daa2bcbd6b2a}"},{"line_number":155,"context_line":"# RHEL\u0027s support for namespaces requires using veths with ovs"},{"line_number":156,"context_line":"Q_OVS_USE_VETH\u003d${Q_OVS_USE_VETH:-False}"},{"line_number":157,"context_line":"Q_USE_ROOTWRAP\u003d${Q_USE_ROOTWRAP:-True}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_f5d552b9","line":154,"updated":"2015-03-29 14:46:11.000000000","message":"The default value is meaningless. You need to retrieve router ID dynamically.","commit_id":"0b02fdfddb01deadb640e752b2203477871eec5b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d24464f5c9d969804364f27e3ee2b49a1a650d56","unresolved":false,"context_lines":[{"line_number":982,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT verbose True"},{"line_number":983,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":984,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":985,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT router_id $Q_ROUTER_ID"},{"line_number":986,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT root_helper \"$Q_RR_COMMAND\""},{"line_number":987,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" \u003d\u003d \"True\" ]]; then"},{"line_number":988,"context_line":"        iniset $Q_L3_CONF_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_95e5e6a9","line":985,"updated":"2015-03-29 14:46:11.000000000","message":"Q_ROUTER_ID is required only for non-namespace case. If Q_ROUTER_ID is required for namespace use case, we should fix Neutorn rather than devstack.","commit_id":"0b02fdfddb01deadb640e752b2203477871eec5b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5aaa63c8231fb1f633affb0ee15a343ce4f27562","unresolved":false,"context_lines":[{"line_number":151,"context_line":"# Use namespace or not"},{"line_number":152,"context_line":"Q_USE_NAMESPACE\u003d${Q_USE_NAMESPACE:-True}"},{"line_number":153,"context_line":"# Default Router ID"},{"line_number":154,"context_line":"Q_ROUTER_ID\u003d${Q_ROUTER_ID:-00000000-0000-0000-0000-000000000000}"},{"line_number":155,"context_line":"# RHEL\u0027s support for namespaces requires using veths with ovs"},{"line_number":156,"context_line":"Q_OVS_USE_VETH\u003d${Q_OVS_USE_VETH:-False}"},{"line_number":157,"context_line":"Q_USE_ROOTWRAP\u003d${Q_USE_ROOTWRAP:-True}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baa041b7_4fb40bd0","line":154,"updated":"2015-04-05 18:16:38.000000000","message":"I still cannot understand why it works. Router ID will change every time devstack runs, so we cannot know the default router ID. The meaningless value leads to a confusion and we should avoid it as possible as we can.","commit_id":"165afc23e9c7df6dec79c51242af6bae83b0e1fd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5aaa63c8231fb1f633affb0ee15a343ce4f27562","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"function _neutron_set_router_id {"},{"line_number":1357,"context_line":"    if [[ \"$Q_USE_NAMESPACE\" \u003d\u003d \"False\" ]]; then"},{"line_number":1358,"context_line":"        iniset $Q_L3_CONF_FILE DEFAULT router_id $ROUTER_ID"},{"line_number":1359,"context_line":"        # we need to restart neutron L3 agent since the agent was already started"},{"line_number":1360,"context_line":"        if is_service_enabled q-vpn; then"},{"line_number":1361,"context_line":"            stop_process q-vpn"},{"line_number":1362,"context_line":"            run_process q-vpn \"$AGENT_VPN_BINARY $(determine_config_files neutron-vpn-agent)\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baa041b7_afdef70e","line":1359,"updated":"2015-04-05 18:16:38.000000000","message":"How about not starting vpn/l3-agent in start_neutron_agents when Q_USE_NAMESPACE is False rather than restarting vpn/l3-agent here?\nIs there any problem?","commit_id":"165afc23e9c7df6dec79c51242af6bae83b0e1fd"}]}