)]}'
{"lib/glance":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ad296108347b65785a84ba782fa1a7e106a22409","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh install"},{"line_number":356,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":"\t"},{"line_number":359,"context_line":"    setup_develop $GLANCE_DIR"},{"line_number":360,"context_line":"}"},{"line_number":361,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baa041b7_5394d4e0","line":358,"updated":"2015-04-03 12:43:16.000000000","message":"can we clean up the gorpy whitespace here?","commit_id":"9fdc80879bc63858a1721906e0a772e65710ca0e"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"ab5ea72145e300202ef3608e843f63d6187da94c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh install"},{"line_number":356,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":"\t"},{"line_number":359,"context_line":"    setup_develop $GLANCE_DIR"},{"line_number":360,"context_line":"}"},{"line_number":361,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baa041b7_d4320010","line":358,"in_reply_to":"baa041b7_5394d4e0","updated":"2015-04-03 18:35:24.000000000","message":"Done - Sorry about that.","commit_id":"9fdc80879bc63858a1721906e0a772e65710ca0e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"717d72c4234d01f9288c78003a8df19f19836584","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    if is_service_enabled g-search; then"},{"line_number":354,"context_line":"        if [ ! `grep -i ^elasticsearch ${GLANCE_DIR}/requirements.txt` ] ; then"},{"line_number":355,"context_line":"            echo \"elasticsearch\u003e\u003d1.3.0\" \u003e\u003e ${GLANCE_DIR}/requirements.txt"},{"line_number":356,"context_line":"        fi"},{"line_number":357,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh download"},{"line_number":358,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aaa499b_2a51df0e","line":355,"updated":"2015-04-14 03:09:14.000000000","message":"I suppose devstack should not edit the source code. If glance needs elasticsearch, you can pip_install.","commit_id":"df7176f7a2831856c4d188c79bb9836304f4d620"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"0109c962a8e1f46a19125ccab41dc44c5e711efd","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    if is_service_enabled g-search; then"},{"line_number":354,"context_line":"        if [ ! `grep -i ^elasticsearch ${GLANCE_DIR}/requirements.txt` ] ; then"},{"line_number":355,"context_line":"            echo \"elasticsearch\u003e\u003d1.3.0\" \u003e\u003e ${GLANCE_DIR}/requirements.txt"},{"line_number":356,"context_line":"        fi"},{"line_number":357,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh download"},{"line_number":358,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aaa499b_53050378","line":355,"in_reply_to":"7aaa499b_2a51df0e","updated":"2015-04-14 08:02:13.000000000","message":"Thanks Hirofumi for reminding me...the \"elasticsearch.sh install\" below, will do a  \"pip_install_gr elasticsearch\", so no need to do it again here. I\u0027ve removed this code in patch set 5 and g-search still works.","commit_id":"df7176f7a2831856c4d188c79bb9836304f4d620"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5cf0d654c6b5b6c134d8114c9ef4246991f51381","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    if is_service_enabled g-search; then"},{"line_number":354,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh download"},{"line_number":355,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh install"},{"line_number":356,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    setup_develop $GLANCE_DIR"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5aa745d1_5eb088dd","line":356,"updated":"2015-04-16 17:49:20.000000000","message":"This must not be started here, the install_*() functions are for installing and preparing the source directories.\n\nAlso, there should be a corresponding stop in glance_cleanup().","commit_id":"ef626688ede86da71844bc0b78aee743cefe8ca2"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"365fe35a166b2aa68115785e03af6db31511134a","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    if is_service_enabled g-search; then"},{"line_number":354,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh download"},{"line_number":355,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh install"},{"line_number":356,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    setup_develop $GLANCE_DIR"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3ab451fb_8541483c","line":356,"in_reply_to":"5aa745d1_5eb088dd","updated":"2015-04-16 22:37:14.000000000","message":"I\u0027ve moved the elasticsearch start into the init_glance() function, just before the glance-index process is run. The glance-index process creates a glance index in elasticsearch with two types - image and metadef. I also added elasticsearch stop to glance_cleanup().","commit_id":"ef626688ede86da71844bc0b78aee743cefe8ca2"}]}
