)]}'
{"id":"openstack%2Fdevstack~169679","triplet_id":"openstack%2Fdevstack~master~I5e0b35446075b419fe473e1db8d0bfedd7009741","project":"openstack/devstack","branch":"master","topic":"enable_debug_libvirt","hashtags":[],"change_id":"I5e0b35446075b419fe473e1db8d0bfedd7009741","subject":"functions-libvirt: Enable DEBUG_LIBVIRT config attribute by default","status":"MERGED","created":"2015-04-01 10:08:58.000000000","updated":"2015-04-03 14:29:09.000000000","submitted":"2015-04-03 14:29:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cdf2f97a4b1cd25aae818eed508f296788defea9","_number":169679,"virtual_id_number":169679,"owner":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-04-01 15:23:49.000000000","_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2015-04-03 14:29:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":1,"date":"2015-04-01 15:35:50.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-04-03 11:39:01.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-04-03 11:39:01.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-01 15:35:50.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2015-04-03 11:39:01.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-04-03 14:29:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"96387d309bdb53ad755be2a8296e6752353bb61c","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2015-04-01 10:08:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"75ac3dac65f96e7a18936ffa2d9c0cdcf941fe17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-01 11:25:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/79/169679/1/check/check-tempest-dsvm-full/bb78b79/ : SUCCESS in 42m 13s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/79/169679/1/check/check-tempest-dsvm-postgres-full/77e02a5/ : SUCCESS in 46m 36s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/79/169679/1/check/check-tempest-dsvm-neutron-full/9793ea7/ : SUCCESS in 54m 13s\n- check-grenade-dsvm http://logs.openstack.org/79/169679/1/check/check-grenade-dsvm/308a3ef/ : SUCCESS in 41m 20s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/79/169679/1/check/gate-tempest-dsvm-large-ops/a5ca007/ : SUCCESS in 27m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/79/169679/1/check/gate-tempest-dsvm-neutron-large-ops/bf66d87/ : SUCCESS in 21m 22s\n- gate-devstack-bashate http://logs.openstack.org/79/169679/1/check/gate-devstack-bashate/359d269/ : SUCCESS in 17s\n- gate-devstack-unit-tests http://logs.openstack.org/79/169679/1/check/gate-devstack-unit-tests/0d25616/ : SUCCESS in 25s\n- check-devstack-dsvm-cells http://logs.openstack.org/79/169679/1/check/check-devstack-dsvm-cells/bc8f535/ : SUCCESS in 19m 35s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/79/169679/1/check/check-grenade-dsvm-partial-ncpu/37a332f/ : SUCCESS in 45m 17s\n- check-swift-dsvm-functional http://logs.openstack.org/79/169679/1/check/check-swift-dsvm-functional/b755bcc/ : SUCCESS in 21m 06s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/79/169679/1/check/check-tempest-dsvm-ironic-pxe_ssh/f9518da/ : SUCCESS in 31m 39s\n- check-devstack-dsvm-updown http://logs.openstack.org/79/169679/1/check/check-devstack-dsvm-updown/f3bd572/ : SUCCESS in 20m 24s\n- check-tempest-dsvm-f21 http://logs.openstack.org/79/169679/1/check/check-tempest-dsvm-f21/f9aabb6/ : FAILURE in 55m 31s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/79/169679/1/check/gate-devstack-publish-docs/792dc3a//doc/build/html/ : SUCCESS in 1m 41s\n- check-grenade-dsvm-neutron http://logs.openstack.org/79/169679/1/check/check-grenade-dsvm-neutron/7fc4e4e/ : SUCCESS in 1h 16m 28s","accounts_in_message":[],"_revision_number":1},{"id":"7368a89f4146baa5d712a35e8199b8695167d392","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2015-04-01 15:23:49.000000000","message":"Patch Set 1:\n\nFrom the Gate \u0027check\u0027 job, the log file size is 2MB with the specific filters enabled:\n \n    libvirtd.txt.gz\t01-Apr-2015 10:51 \t2.0M\n\n\nSean/Clark,is this size acceptable for libvirtd log file to have it enabled by default on Gate?","accounts_in_message":[],"_revision_number":1},{"id":"5effa5918934c50c369997643cf781cca45ba5a7","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-04-01 15:35:50.000000000","message":"Patch Set 1: Code-Review+1\n\nI am ok with this, we just can\u0027t attempt to index this file with elasticsearch again or the cluster will fall behind and no one will be happy. Should be fine to copy this to the log servers/swift though.","accounts_in_message":[],"_revision_number":1},{"id":"715496592dae733efc88d26f259cb2f8a06555a8","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-04-03 11:39:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4f739d15a9db69ea34cd331b4a24c8527a3e0ede","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-03 11:39:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c9c4c7e3f5dc17fdf76d10f1e4d39ad144910fd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-03 14:29:08.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/79/169679/1/gate/gate-tempest-dsvm-full/f52bd9b/ : SUCCESS in 45m 43s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/79/169679/1/gate/gate-tempest-dsvm-postgres-full/3494422/ : SUCCESS in 41m 21s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/79/169679/1/gate/gate-tempest-dsvm-neutron-full/c79728b/ : SUCCESS in 50m 16s\n- gate-grenade-dsvm http://logs.openstack.org/79/169679/1/gate/gate-grenade-dsvm/852a9e4/ : SUCCESS in 38m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/79/169679/1/gate/gate-tempest-dsvm-large-ops/edae516/ : SUCCESS in 21m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/79/169679/1/gate/gate-tempest-dsvm-neutron-large-ops/b9d22a9/ : SUCCESS in 21m 33s\n- gate-devstack-bashate http://logs.openstack.org/79/169679/1/gate/gate-devstack-bashate/1d2a51e/ : SUCCESS in 19s\n- gate-devstack-dsvm-cells http://logs.openstack.org/79/169679/1/gate/gate-devstack-dsvm-cells/6963243/ : SUCCESS in 18m 26s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/79/169679/1/gate/gate-grenade-dsvm-partial-ncpu/e388b96/ : SUCCESS in 38m 44s\n- gate-swift-dsvm-functional http://logs.openstack.org/79/169679/1/gate/gate-swift-dsvm-functional/fd67719/ : SUCCESS in 21m 36s","accounts_in_message":[],"_revision_number":1},{"id":"a5ff0182e9faf8b69d1c230355ca2adc2878338a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-03 14:29:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d3cfb82c65ae7f85b9d92e1245b1d81792a5641b","revisions":{"d3cfb82c65ae7f85b9d92e1245b1d81792a5641b":{"kind":"REWORK","_number":1,"created":"2015-04-01 10:08:58.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/79/169679/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/79/169679/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/169679/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/169679/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/169679/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/79/169679/1"}}},"commit":{"parents":[{"commit":"b0e3733cb3543c371df4831717b45738542fb91a","subject":"Merge \"functions-libvirt: Enable \u0027qemu_monitor\u0027 logging filter for libvirt\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b0e3733cb3543c371df4831717b45738542fb91a"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2015-04-01 09:30:57.000000000","tz":120},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2015-04-01 10:05:07.000000000","tz":120},"subject":"functions-libvirt: Enable DEBUG_LIBVIRT config attribute by default","message":"functions-libvirt: Enable DEBUG_LIBVIRT config attribute by default\n\nEnabling it by default because:\n\n  - This allows you to get the relevant logs right away when something\n    in the libvirt code path fails, without having to submit another\n    change and keep doing a \u0027recheck\u0027 to re-run the CI check/gate jobs\n    until you hit the bug.\n\n  - The libvirt log filters specified in the function\n    \u0027configure_libvirt\u0027 are much more _selective_ and not a catch-all\n    debug option where you end up with the unhelpful situation of having\n    to find a \"specific piece of hay in a haystack\"[1].\n\nFWIW, I always have it enabled in local test environments, and I don\u0027t\nsee the resulting libvirtd.log growing beyond a couple of MB for\nthree-four days of usage.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2014-January/024414.html\n\nChange-Id: I5e0b35446075b419fe473e1db8d0bfedd7009741\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d3cfb82c65ae7f85b9d92e1245b1d81792a5641b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d3cfb82c65ae7f85b9d92e1245b1d81792a5641b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}