)]}'
{"functions-common":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"eb614608097d98e873314067fd6dec1940f25d27","unresolved":false,"context_lines":[{"line_number":772,"context_line":"# Usage: get_or_add_group_project_role \u003crole\u003e \u003cgroup\u003e \u003cproject\u003e"},{"line_number":773,"context_line":"function get_or_add_group_project_role {"},{"line_number":774,"context_line":"    local os_url\u003d\"$KEYSTONE_SERVICE_URI_V3\""},{"line_number":775,"context_line":"    # Gets group role id"},{"line_number":776,"context_line":"    local group_role_id\u003d$(openstack --os-token\u003d$OS_TOKEN --os-url\u003d$os_url \\"},{"line_number":777,"context_line":"        --os-identity-api-version\u003d3 \\"},{"line_number":778,"context_line":"        role list \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7aaa499b_7fe31206","line":775,"updated":"2015-04-14 14:55:01.000000000","message":"could have\n\n  os_cmd \u003d\" openstack --os-url\u003d$os_url --os-identity-api-version\u003d3\"\n\nand simplify the below","commit_id":"6b1763666c454a8981ffb4bb34ab0b5ccfcd08e2"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"fa66a5805bc6c0283bb23eaaae3600c7e332785f","unresolved":false,"context_lines":[{"line_number":662,"context_line":"    # Gets domain id"},{"line_number":663,"context_line":"    local domain_id\u003d$("},{"line_number":664,"context_line":"        # Gets domain id"},{"line_number":665,"context_line":"        openstack $OS_V3_API domain show $1 \\"},{"line_number":666,"context_line":"            -f value -c id 2\u003e/dev/null ||"},{"line_number":667,"context_line":"        # Creates new domain"},{"line_number":668,"context_line":"        openstack $OS_V3_API domain create $1 \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a016987_6d13620e","line":665,"updated":"2015-05-18 07:26:51.000000000","message":"I think \"OS_V3_API\" may be misleading since it is actually a group of command option. How about \"OS_V3_AUTH_OPTS\", \"OS_V3_AUTH_PARAMS\" or \"OS_V3_AUTH_FLAGS\"?","commit_id":"6c2069845fc5125b03c0ca09afff6658caea60e1"}],"stack.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d38d1577d54bd113b5e177033b82071efdcdfd64","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    # Setup OpenStackClient token-endpoint auth and API V3 command line"},{"line_number":986,"context_line":"    export OS_TOKEN\u003d$SERVICE_TOKEN"},{"line_number":987,"context_line":"    export OS_URL\u003d$SERVICE_ENDPOINT"},{"line_number":988,"context_line":"    export OS_CMD_V3\u003d\"openstack --os-token\u003d$OS_TOKEN --os-url\u003d$KEYSTONE_SERVICE_URI_V3 --os-identity-api-version\u003d3\""},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    create_keystone_accounts"},{"line_number":991,"context_line":"    create_nova_accounts"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5aa745d1_89371ce3","line":988,"updated":"2015-04-15 23:49:40.000000000","message":"i don\u0027t want to bikeshed on this too much, but it feels weird to have bare \"openstack foo bar\" commands in a bunch of places, and \"OS_CMD_V3 foo bar\" in others.\n\nI\u0027d prefer to see OS_V3_API\u003d\"--os-token ...\" and then use \"openstack $OS_V3_API foo bar\"","commit_id":"2190b7350abc07b3c00eb2a86911ad82877255c2"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"51ab99769ae85627e3c6e8fb69b6623aa8863844","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    # Setup OpenStackClient token-endpoint auth and V3 API options"},{"line_number":986,"context_line":"    export OS_TOKEN\u003d$SERVICE_TOKEN"},{"line_number":987,"context_line":"    export OS_URL\u003d$SERVICE_ENDPOINT"},{"line_number":988,"context_line":"    export OS_V3_API\u003d\"--os-token\u003d$OS_TOKEN --os-url\u003d$KEYSTONE_SERVICE_URI_V3 --os-identity-api-version\u003d3\""},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    create_keystone_accounts"},{"line_number":991,"context_line":"    create_nova_accounts"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5aa745d1_83c7d911","line":988,"updated":"2015-04-16 17:29:18.000000000","message":"--os-token and --os-url do not need to be included in OS_V3_API, osc will pick them up.","commit_id":"6c2069845fc5125b03c0ca09afff6658caea60e1"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"fa66a5805bc6c0283bb23eaaae3600c7e332785f","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    # Setup OpenStackClient token-endpoint auth and V3 API options"},{"line_number":986,"context_line":"    export OS_TOKEN\u003d$SERVICE_TOKEN"},{"line_number":987,"context_line":"    export OS_URL\u003d$SERVICE_ENDPOINT"},{"line_number":988,"context_line":"    export OS_V3_API\u003d\"--os-token\u003d$OS_TOKEN --os-url\u003d$KEYSTONE_SERVICE_URI_V3 --os-identity-api-version\u003d3\""},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    create_keystone_accounts"},{"line_number":991,"context_line":"    create_nova_accounts"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a016987_2d51ea62","line":988,"in_reply_to":"1aca2d91_41c5338c","updated":"2015-05-18 07:26:51.000000000","message":"IMHO, if you put \"--os-token\" into it, how about change the name from \"OS_V3_API\" to \"OS_V3_AUTH_XXX\"?","commit_id":"6c2069845fc5125b03c0ca09afff6658caea60e1"},{"author":{"_account_id":13790,"name":"Zhenzan Zhou","email":"linuxosa@gmail.com","username":"zhenzanzhou"},"change_message_id":"3bb50276858f3b940a50522a95bff68b740f7706","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    # Setup OpenStackClient token-endpoint auth and V3 API options"},{"line_number":986,"context_line":"    export OS_TOKEN\u003d$SERVICE_TOKEN"},{"line_number":987,"context_line":"    export OS_URL\u003d$SERVICE_ENDPOINT"},{"line_number":988,"context_line":"    export OS_V3_API\u003d\"--os-token\u003d$OS_TOKEN --os-url\u003d$KEYSTONE_SERVICE_URI_V3 --os-identity-api-version\u003d3\""},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    create_keystone_accounts"},{"line_number":991,"context_line":"    create_nova_accounts"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1aca2d91_41c5338c","line":988,"in_reply_to":"5aa745d1_83c7d911","updated":"2015-05-07 08:31:36.000000000","message":"The default OS_URL is for V2 API. So we have to specify os_url for V3 API explicitly. But it doesn\u0027t matter specify OS_TOKEN or not. I prefer to keep \u0027--os-token\u0027 so people know the difference between V2 and V3 API options. As OS_TOKEN and OS_URL are not listed as dependent variables in functions-common, is it ok to not add OS_V3_API either? Thanks.","commit_id":"6c2069845fc5125b03c0ca09afff6658caea60e1"}]}