)]}'
{"id":"openstack%2Fdevstack~172768","triplet_id":"openstack%2Fdevstack~master~Ic854ebd029aef93bfee620d92d244f2c78766d18","project":"openstack/devstack","branch":"master","topic":"run_process-quote","hashtags":[],"change_id":"Ic854ebd029aef93bfee620d92d244f2c78766d18","subject":"Fix non group-set $command for _run_process","status":"ABANDONED","created":"2015-04-13 00:32:22.000000000","updated":"2017-09-19 01:09:56.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4e6134baaa27312bbed36bece894a737a524fc3b","_number":172768,"virtual_id_number":172768,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2017-09-07 13:49:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-04-16 18:03:04.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2017-01-05 14:18:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-16 18:03:04.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-01-05 14:18:52.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2017-09-07 13:49:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"00e703ee749878710eef0631e5a2fe9b04d9deac","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-04-13 00:32:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a0b5e7bd73345b9c6b634bafb599de6253841ba3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-13 01:08:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/68/172768/1/check/check-tempest-dsvm-full/31b94cb/ : FAILURE in 17m 21s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/172768/1/check/check-tempest-dsvm-postgres-full/5ab016c/ : FAILURE in 14m 26s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/172768/1/check/check-tempest-dsvm-neutron-full/eb11d9b/ : FAILURE in 17m 14s\n- check-grenade-dsvm http://logs.openstack.org/68/172768/1/check/check-grenade-dsvm/56bc438/ : FAILURE in 31m 21s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/172768/1/check/gate-tempest-dsvm-large-ops/786bf84/ : FAILURE in 12m 32s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/172768/1/check/gate-tempest-dsvm-neutron-large-ops/2e8e14a/ : FAILURE in 12m 55s\n- gate-devstack-bashate http://logs.openstack.org/68/172768/1/check/gate-devstack-bashate/10750b0/ : SUCCESS in 15s\n- gate-devstack-unit-tests http://logs.openstack.org/68/172768/1/check/gate-devstack-unit-tests/aed73cb/ : SUCCESS in 21s\n- check-devstack-dsvm-cells http://logs.openstack.org/68/172768/1/check/check-devstack-dsvm-cells/d87c151/ : FAILURE in 17m 59s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/68/172768/1/check/check-grenade-dsvm-partial-ncpu/d9d81db/ : FAILURE in 26m 31s\n- check-swift-dsvm-functional http://logs.openstack.org/68/172768/1/check/check-swift-dsvm-functional/e36df44/ : FAILURE in 16m 54s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/68/172768/1/check/check-tempest-dsvm-ironic-pxe_ssh/aecd3bc/ : FAILURE in 16m 45s\n- check-devstack-dsvm-updown http://logs.openstack.org/68/172768/1/check/check-devstack-dsvm-updown/1ca72af/ : FAILURE in 18m 33s\n- check-tempest-dsvm-f21 http://logs.openstack.org/68/172768/1/check/check-tempest-dsvm-f21/0dc9f03/ : FAILURE in 20m 18s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/68/172768/1/check/check-tempest-dsvm-centos7/aea7b51/ : FAILURE in 22m 48s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/68/172768/1/check/gate-devstack-publish-docs/08927a3//doc/build/html/ : SUCCESS in 1m 08s\n- check-grenade-dsvm-neutron http://logs.openstack.org/68/172768/1/check/check-grenade-dsvm-neutron/346de25/ : FAILURE in 36m 25s","accounts_in_message":[],"_revision_number":1},{"id":"2073c7998365ecc387ef9238c8727862a47b0435","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-04-13 05:15:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ccd6e395880a775225acda73d3747c6d588a2c1b","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-04-13 05:32:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"48e1371c8010ab9ec4fae9aeba405efbff829ba0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-13 06:36:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/68/172768/3/check/check-tempest-dsvm-full/ea16127/ : SUCCESS in 42m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/172768/3/check/check-tempest-dsvm-postgres-full/25aac71/ : SUCCESS in 44m 38s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/172768/3/check/check-tempest-dsvm-neutron-full/79be5dc/ : SUCCESS in 59m 40s\n- check-grenade-dsvm http://logs.openstack.org/68/172768/3/check/check-grenade-dsvm/670564b/ : SUCCESS in 39m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/172768/3/check/gate-tempest-dsvm-large-ops/153a43d/ : SUCCESS in 21m 48s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/172768/3/check/gate-tempest-dsvm-neutron-large-ops/f3f374b/ : SUCCESS in 19m 23s\n- gate-devstack-bashate http://logs.openstack.org/68/172768/3/check/gate-devstack-bashate/a7d1eac/ : SUCCESS in 16s\n- gate-devstack-unit-tests http://logs.openstack.org/68/172768/3/check/gate-devstack-unit-tests/348e625/ : SUCCESS in 29s\n- check-devstack-dsvm-cells http://logs.openstack.org/68/172768/3/check/check-devstack-dsvm-cells/2e73243/ : SUCCESS in 18m 33s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/68/172768/3/check/check-grenade-dsvm-partial-ncpu/3d0f092/ : SUCCESS in 43m 12s\n- check-swift-dsvm-functional http://logs.openstack.org/68/172768/3/check/check-swift-dsvm-functional/f642a4d/ : SUCCESS in 23m 10s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/68/172768/3/check/check-tempest-dsvm-ironic-pxe_ssh/a3d7148/ : SUCCESS in 29m 41s\n- check-devstack-dsvm-updown http://logs.openstack.org/68/172768/3/check/check-devstack-dsvm-updown/99b3a0e/ : SUCCESS in 20m 03s\n- check-tempest-dsvm-f21 http://logs.openstack.org/68/172768/3/check/check-tempest-dsvm-f21/48e1392/ : FAILURE in 54m 56s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/68/172768/3/check/check-tempest-dsvm-centos7/c95aabd/ : SUCCESS in 39m 52s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/68/172768/3/check/gate-devstack-publish-docs/db6114c//doc/build/html/ : SUCCESS in 1m 11s\n- check-grenade-dsvm-neutron http://logs.openstack.org/68/172768/3/check/check-grenade-dsvm-neutron/7b5eb18/ : SUCCESS in 56m 24s","accounts_in_message":[],"_revision_number":3},{"id":"c7f651e756e471dd02af180db6947891b386fe44","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-04-16 18:03:04.000000000","message":"Patch Set 3:\n\nThis is a very fiddly function and this will affect how the session leader is set possibly making it hard to properly kill processes, which is what made it hard to get right in the first place.  I consider the loss of shell commands here a livable consequence.  If services need to have a particular cwd they should be taking care of that themselves.\n\nI\u0027m going to need to spend a good bit more time testing this before voting either way...","accounts_in_message":[],"_revision_number":3},{"id":"4f407d574c4ae6bd3f2b19bb099a4b2743b0d8bf","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-06-16 18:00:47.000000000","message":"Patch Set 3: Code-Review-1\n\nI\u0027m with Dean on this one, and I think we need to be really careful about it. The only time a cwd is really needed should be with non console_entrypoint commands, which should be a deprecated model.","accounts_in_message":[],"_revision_number":3},{"id":"85b4074b8dc732d9d74c6b529569bef01f629930","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-02-10 15:48:14.000000000","message":"Removed the following votes:\n\n* Code-Review-1 by Sean Dague \u003csean@dague.net\u003e\n","accounts_in_message":[],"_revision_number":3},{"id":"023a7e64f3ec3223779673f290078e3874b7a21b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-01-05 14:18:52.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"aca1cc95880018bc7aea33a60982300ea75f268a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-07 13:49:45.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"c796d402a5d83b6046f66b48197d5a60507f8aff","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-09-19 01:09:56.000000000","message":"Abandoned\n\nthis has all gone away","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"74b2d053a22b5fbf0d661abbc0c7df1c251babff","revisions":{"c2b6b04a5064ba354beb80e79345ce739825b2f0":{"kind":"REWORK","_number":1,"created":"2015-04-13 00:32:22.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/68/172768/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/68/172768/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/68/172768/1"}}},"commit":{"parents":[{"commit":"156244df1cf444de212140a1c16e8e989b4be611","subject":"Merge \"Avoid flushing br-ex during stacking\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/156244df1cf444de212140a1c16e8e989b4be611"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-04-13 00:29:40.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-04-13 00:29:40.000000000","tz":600},"subject":"Quote $command for _run_process","message":"Quote $command for _run_process\n\nThe non-group path doesn\u0027t quote $command, so if you need to \"cd\" etc\nthis breaks things\n\nChange-Id: Ic854ebd029aef93bfee620d92d244f2c78766d18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c2b6b04a5064ba354beb80e79345ce739825b2f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c2b6b04a5064ba354beb80e79345ce739825b2f0"}]},"branch":"refs/heads/master"},"cee5d9ff3afb4af32e35a76a2d07baba9c377834":{"kind":"REWORK","_number":2,"created":"2015-04-13 05:15:19.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/68/172768/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/68/172768/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/68/172768/2"}}},"commit":{"parents":[{"commit":"156244df1cf444de212140a1c16e8e989b4be611","subject":"Merge \"Avoid flushing br-ex during stacking\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/156244df1cf444de212140a1c16e8e989b4be611"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-04-13 00:29:40.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-04-13 05:15:04.000000000","tz":600},"subject":"Fix non group-set $command for _run_process","message":"Fix non group-set $command for _run_process\n\nThe \"sg\" command takes a quoted string and runs it in a shell, while\nthe non-group path isn\u0027t doing this.  This means the function behaves\ndifferently depending on if you specify a group or not -- \"cd /blah;\ncmd\" works with a group set but not otherwise.  Bring into line by\nrunning with bash -c\n\nChange-Id: Ic854ebd029aef93bfee620d92d244f2c78766d18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cee5d9ff3afb4af32e35a76a2d07baba9c377834"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cee5d9ff3afb4af32e35a76a2d07baba9c377834"}]},"branch":"refs/heads/master"},"74b2d053a22b5fbf0d661abbc0c7df1c251babff":{"kind":"REWORK","_number":3,"created":"2015-04-13 05:32:46.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/68/172768/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/68/172768/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/172768/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/68/172768/3"}}},"commit":{"parents":[{"commit":"156244df1cf444de212140a1c16e8e989b4be611","subject":"Merge \"Avoid flushing br-ex during stacking\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/156244df1cf444de212140a1c16e8e989b4be611"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-04-13 00:29:40.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-04-13 05:32:31.000000000","tz":600},"subject":"Fix non group-set $command for _run_process","message":"Fix non group-set $command for _run_process\n\nThe \"sg\" command takes a quoted string and runs it in a shell, while\nthe non-group path isn\u0027t doing this.  This means the function behaves\ndifferently depending on if you specify a group or not -- \"cd /blah;\ncmd\" works with a group set but not otherwise.  Bring into line by\nrunning with bash -c\n\nChange-Id: Ic854ebd029aef93bfee620d92d244f2c78766d18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/74b2d053a22b5fbf0d661abbc0c7df1c251babff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/74b2d053a22b5fbf0d661abbc0c7df1c251babff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}