)]}'
{"functions-common":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d8e52db8ccbeda69b82a5d27b72cc32c1e4cc2b2","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"# remove specified list from the input string"},{"line_number":1616,"context_line":"# remove_disable_services service-list remove-list"},{"line_number":1617,"context_line":"function remove_disable_services {"},{"line_number":1618,"context_line":"    local service_list\u003d$1"},{"line_number":1619,"context_line":"    local remove_list\u003d$2"},{"line_number":1620,"context_line":"    local enabled\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_b33ffbb2","line":1617,"updated":"2015-05-23 17:04:14.000000000","message":"This should be named remove_disabled_services.\n\nAlso the functiosn should be sorted in this section, so this function fits between is_service_enabled() and use_exclusive_service().","commit_id":"01f4cf0e1b7a64aa8228c6fcdc0cdb41cd9d5516"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"1feba9109ba903ccbfe1e334327a5b4165c4d4d5","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"# remove specified list from the input string"},{"line_number":1616,"context_line":"# remove_disable_services service-list remove-list"},{"line_number":1617,"context_line":"function remove_disable_services {"},{"line_number":1618,"context_line":"    local service_list\u003d$1"},{"line_number":1619,"context_line":"    local remove_list\u003d$2"},{"line_number":1620,"context_line":"    local enabled\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_ae52f064","line":1617,"in_reply_to":"7a016987_b33ffbb2","updated":"2015-05-23 23:24:25.000000000","message":"Sure, I was not aware it. I will fix it.","commit_id":"01f4cf0e1b7a64aa8228c6fcdc0cdb41cd9d5516"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"41b62b15a564d1e77886f9bd0239216370f0cfd5","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"            enabled\u003d\"${enabled},$service\""},{"line_number":1771,"context_line":"        fi"},{"line_number":1772,"context_line":"    done"},{"line_number":1773,"context_line":"    echo $enabled"},{"line_number":1774,"context_line":"}"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"# Toggle enable/disable_service for services that must run exclusive of each other"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a016987_64577426","line":1773,"updated":"2015-05-25 03:30:03.000000000","message":"it\u0027s better to call _cleanup_service_list here rather than the callers","commit_id":"8a3d6091b92d6af5f8d1f76b0dc87b3936a9592a"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"34f1f6c04cc917792906cfc6d69dfa6e77b06493","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"            enabled\u003d\"${enabled},$service\""},{"line_number":1771,"context_line":"        fi"},{"line_number":1772,"context_line":"    done"},{"line_number":1773,"context_line":"    echo $enabled"},{"line_number":1774,"context_line":"}"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"# Toggle enable/disable_service for services that must run exclusive of each other"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a016987_3043f3b0","line":1773,"in_reply_to":"7a016987_64577426","updated":"2015-05-25 11:00:27.000000000","message":"Done","commit_id":"8a3d6091b92d6af5f8d1f76b0dc87b3936a9592a"}],"lib/tempest":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7bcd7257f29235cfd8e8f58113485e8b5c04567","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            extensions_list\u003d${extensions_list/\",\"$ext_to_remove}"},{"line_number":105,"context_line":"        else"},{"line_number":106,"context_line":"            extensions_list\u003d$extensions_list_tmp"},{"line_number":107,"context_line":"        fi"},{"line_number":108,"context_line":"    done"},{"line_number":109,"context_line":"    echo $extensions_list"},{"line_number":110,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5aa745d1_daeb9baf","line":107,"updated":"2015-04-16 09:22:14.000000000","message":"seems too complex for a shell script.\ncan you consider to use a better tool like sed?","commit_id":"6dc7a48f91daece7922b2cb3af610698f55bc909"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"2bdd82b08829c1223d4671a790aeddcec3d8dbe3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            extensions_list\u003d${extensions_list/\",\"$ext_to_remove}"},{"line_number":105,"context_line":"        else"},{"line_number":106,"context_line":"            extensions_list\u003d$extensions_list_tmp"},{"line_number":107,"context_line":"        fi"},{"line_number":108,"context_line":"    done"},{"line_number":109,"context_line":"    echo $extensions_list"},{"line_number":110,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3ab451fb_e89d715a","line":107,"in_reply_to":"5aa745d1_daeb9baf","updated":"2015-04-17 10:42:39.000000000","message":"Done. yes, it is good idea.","commit_id":"6dc7a48f91daece7922b2cb3af610698f55bc909"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c935f991f204059cbb49c36d84c9d87cb476fde","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    shift"},{"line_number":93,"context_line":"    local disabled_exts\u003d$*"},{"line_number":94,"context_line":"    for ext_to_remove in ${disabled_exts//,/ } ; do"},{"line_number":95,"context_line":"        extensions_list\u003d`echo $extensions_list | sed -e \"s/,${ext_to_remove}//\" -e \"s/${ext_to_remove},//\" -e \"s/$ext_to_remove//\"`"},{"line_number":96,"context_line":"    done"},{"line_number":97,"context_line":"    echo $extensions_list"},{"line_number":98,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dac4157f_628835e8","line":95,"updated":"2015-04-21 02:25:13.000000000","message":"I suppose a new line is bad. Does this command run properly?\n\nYou might want to use variables like the following or effort to shorten the line with other method.\n\nlocal abc\u003d\"s/,${ext_to_remove}//\"\n\nlocal def\u003d\"s/${ext_to_remove},//\"\n\nlocal ghi\u003d\"s/$ext_to_remove//\"\n\nextensions_list\u003d`echo $extensions_list | sed -e $abc -e $def -e $ghi\n\nThe variable names are meaningless.","commit_id":"02b336d1b5a73ca1b707b2832e34faab6b39d81b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"54e01dd44fd53586c2b0614d56e4ab5d0c26383b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    shift"},{"line_number":93,"context_line":"    local disabled_exts\u003d$*"},{"line_number":94,"context_line":"    for ext_to_remove in ${disabled_exts//,/ } ; do"},{"line_number":95,"context_line":"        extensions_list\u003d`echo $extensions_list | sed -e \"s/,${ext_to_remove}//\" -e \"s/${ext_to_remove},//\" -e \"s/$ext_to_remove//\"`"},{"line_number":96,"context_line":"    done"},{"line_number":97,"context_line":"    echo $extensions_list"},{"line_number":98,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab921fb_47656343","line":95,"in_reply_to":"bab921fb_e413580c","updated":"2015-04-23 08:31:23.000000000","message":"Sorry, when I confirm the patch in my environment, I looked a error. But the cause was other problem.\n\nI confirmed the patch is good. I don\u0027t like the line is too long but it\u0027s not be reason for my -1.","commit_id":"02b336d1b5a73ca1b707b2832e34faab6b39d81b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6973924fc100cd91e3e8adae1036751c78211f0d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    shift"},{"line_number":93,"context_line":"    local disabled_exts\u003d$*"},{"line_number":94,"context_line":"    for ext_to_remove in ${disabled_exts//,/ } ; do"},{"line_number":95,"context_line":"        extensions_list\u003d`echo $extensions_list | sed -e \"s/,${ext_to_remove}//\" -e \"s/${ext_to_remove},//\" -e \"s/$ext_to_remove//\"`"},{"line_number":96,"context_line":"    done"},{"line_number":97,"context_line":"    echo $extensions_list"},{"line_number":98,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab921fb_e413580c","line":95,"in_reply_to":"dac4157f_628835e8","updated":"2015-04-23 06:03:01.000000000","message":"are you complaining that the line is too long?","commit_id":"02b336d1b5a73ca1b707b2832e34faab6b39d81b"}],"tests/test_functions.sh":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8299bf2d8289f63420cb842b619d02c1fba0bc2c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"test_remove_disabled_services \u0027a,b,c\u0027 \u0027\u0027 \u0027a,b,c\u0027"},{"line_number":161,"context_line":"test_remove_disabled_services \u0027\u0027 \u0027a,b,c\u0027 \u0027\u0027"},{"line_number":162,"context_line":"test_remove_disabled_services \u0027\u0027 \u0027\u0027 \u0027\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"echo \"Testing is_package_installed()\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"if [[ -z \"$os_PACKAGE\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7a016987_cd6bdaf0","line":163,"updated":"2015-05-25 23:54:57.000000000","message":"The test cases lack a case which removes non-existence service from some services.\n\ne.g. test_remove_disabled_services \u0027a,b,c\u0027 \u0027d\u0027 \u0027a,b,c\u0027","commit_id":"bea305bd84b56673ce1871b20f7d3de175cb195e"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"81d7ccf6807ae017311e38c8c019cc022c31c9ff","unresolved":false,"context_lines":[{"line_number":160,"context_line":"test_remove_disabled_services \u0027a,b,c\u0027 \u0027\u0027 \u0027a,b,c\u0027"},{"line_number":161,"context_line":"test_remove_disabled_services \u0027\u0027 \u0027a,b,c\u0027 \u0027\u0027"},{"line_number":162,"context_line":"test_remove_disabled_services \u0027\u0027 \u0027\u0027 \u0027\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"echo \"Testing is_package_installed()\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"if [[ -z \"$os_PACKAGE\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7a016987_0662ef16","line":163,"in_reply_to":"7a016987_cd6bdaf0","updated":"2015-05-26 03:51:18.000000000","message":"Done","commit_id":"bea305bd84b56673ce1871b20f7d3de175cb195e"},{"author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"change_message_id":"c868458b56a948ec42317f72d3a6849c42680559","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    local expected\u003d\"$3\""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    results\u003d$(remove_disabled_services \"$service_list\" \"$remove_list\")"},{"line_number":148,"context_line":"    if [ \"$results\" \u003d \"$expected\" ]; then"},{"line_number":149,"context_line":"        passed \"OK: \u0027$service_list\u0027 - \u0027$remove_list\u0027 -\u003e \u0027$results\u0027\""},{"line_number":150,"context_line":"    else"},{"line_number":151,"context_line":"        failed \"getting \u0027$expected\u0027 from \u0027$service_list\u0027 - \u0027$remove_list\u0027 failed: \u0027$results\u0027\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"7a016987_97dccb75","line":148,"updated":"2015-05-26 06:52:56.000000000","message":"If you want to get simple code, I seem that you should use `assert_equal`.","commit_id":"8606c98c53722f425525fa06eee554b7d30f62f6"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"cc6127ea8239688d93c1e584bf75e1d32102226e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    local expected\u003d\"$3\""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    results\u003d$(remove_disabled_services \"$service_list\" \"$remove_list\")"},{"line_number":148,"context_line":"    if [ \"$results\" \u003d \"$expected\" ]; then"},{"line_number":149,"context_line":"        passed \"OK: \u0027$service_list\u0027 - \u0027$remove_list\u0027 -\u003e \u0027$results\u0027\""},{"line_number":150,"context_line":"    else"},{"line_number":151,"context_line":"        failed \"getting \u0027$expected\u0027 from \u0027$service_list\u0027 - \u0027$remove_list\u0027 failed: \u0027$results\u0027\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"7a016987_a87641d6","line":148,"in_reply_to":"7a016987_97dccb75","updated":"2015-05-26 10:19:20.000000000","message":"Thank you for suggestion. I didn\u0027t know the function.\nBut I think that output of assert_equal doesn\u0027t fit those of other tests as assert_equal doesn\u0027t put message in a case of result OK.","commit_id":"8606c98c53722f425525fa06eee554b7d30f62f6"}]}