)]}'
{"id":"openstack%2Fdevstack~1748","triplet_id":"openstack%2Fdevstack~master~Iff1791bcd95e69d2e5a95179cbf55aafa4bdb307","project":"openstack/devstack","branch":"master","topic":"conditional-pip","hashtags":[],"change_id":"Iff1791bcd95e69d2e5a95179cbf55aafa4bdb307","subject":"Only install needed pip dependencies.","status":"ABANDONED","created":"2011-11-18 01:21:10.000000000","updated":"2012-02-10 06:03:08.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c674de18163cb3c8b92189ab51d4dfed28a798f6","_number":1748,"virtual_id_number":1748,"owner":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"date":"2011-12-10 22:14:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"date":"2011-12-09 21:07:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":1,"date":"2012-01-03 15:41:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"date":"2011-11-18 01:21:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"date":"2011-12-09 22:16:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"date":"2011-12-09 21:54:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"date":"2012-01-26 15:47:12.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-11-18 01:21:40.000000000","updated_by":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"reviewer":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"state":"REVIEWER"},{"updated":"2011-12-09 22:16:23.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2011-12-10 22:14:21.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2012-01-03 15:41:22.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2012-01-26 15:47:12.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"9807332bc5621d3cc5418bbb3dfb33c3c880b7d2","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-11-21 16:55:55.000000000","message":"Patch Set 1:\n\nI like the idea but I\u0027m worried that it might cause breakages in diablo.  Perhaps we should push this against the essex branch once we open it?","accounts_in_message":[],"_revision_number":1},{"id":"2ebc7f7edfe72b926ed8daf933a6f8f095b902bc","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-11-23 17:00:16.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nnow that we are in devstack essex, lgtm","accounts_in_message":[],"_revision_number":1},{"id":"8156452316d6ecbb9cd2706dd9a65efa46f16d6e","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2011-12-09 18:37:21.000000000","message":"Patch Set 1:\n\nCurious if you think it would be a good idea to make a generic fname-based pip install mechanism, kinda like the apts.  So if files/pips/key existed, those pips would be installed if key in ENABLED_SERVICES","accounts_in_message":[],"_revision_number":1},{"id":"0a6e42f331923bf617c77c00296cfaf69fe71e72","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2011-12-09 21:07:31.000000000","message":"Patch Set 1:\n\nThat sounds reasonable.  While we\u0027re on the subject, why not use pip-requires from the projects themselves?","accounts_in_message":[],"_revision_number":1},{"id":"c597a725df1892022127e93084aaa88f0d89c266","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-09 21:54:26.000000000","message":"Patch Set 1:\n\nAs we are seeing with nova now that it is using pip-requires, there is overlap between pip-requires and devstack\u0027s files/pips/* and  files/apts/python-*.  Is it reasonable to try and detect the duplication and not install from pip-requires if the module is already available?","accounts_in_message":[],"_revision_number":1},{"id":"afcb355927e631e78074af41644d09a67c602f34","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-12-09 22:16:23.000000000","message":"Patch Set 1:\n\nHi Dean,\n\nI think that pip does that anyway... if a module is already available on the system or in the pip cache, it won\u0027t try to re-install it... so I think it may be a moot point, right?\n\n-jay","accounts_in_message":[],"_revision_number":1},{"id":"d56e3be603d441fa37eb03673e51d70ff4b73fb5","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-10 22:14:21.000000000","message":"Patch Set 1: No score\n\nThe reason for not including pip-requires from the projects is that they sometimes aren\u0027t sane for development.\n\nEach project takes a difference stance on what it means to be in tools/pip-requires.  Sometimes it includes things that are useful for dev - like nose - sometimes there are pips that are optional...  Sometimes projects have (or had) a tools/pip-requires-dev for dev and the normal pip-requires is for running it","accounts_in_message":[],"_revision_number":1},{"id":"f74a96c3e6fe027ae6049f37ac7f87951bc2af88","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2012-01-03 15:41:22.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI like if we can as suggested by Ant the same mechanism done for APT as this may be a bit more elegant although a bit more magic other than that the patch LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"37d77a71770d60f7b718c938e2e989230321f4d7","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:13.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"8ea1d9b80cf1f457ba3082019e9230f728473430","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:13.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"4ea7641b607fe67d8363cb72d2dca6a273bfb00e","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2012-01-24 21:32:11.000000000","message":"Patch Set 1: Restored\n\nI\u0027d still like this to be considered.","accounts_in_message":[],"_revision_number":1},{"id":"0991f3ecc0f7011a82218bfe427ce76089222fb8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-01-26 15:47:12.000000000","message":"Patch Set 1:\n\nI would like it too, but as Anthony suggested, something that uses EMBEDDED_SERVICES to look for files in files/pips without requiring maintenance.  We just added another pip file today...\n\nOh, and we also changed to use a function (pip_install) to perform the installs.","accounts_in_message":[],"_revision_number":1},{"id":"1c75314f688d1b94377049b360ebad9b03cc7e68","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-02-10 06:03:08.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"755e22a97a5f659cb29d4f9738074f4948e12527","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-02-10 06:03:08.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ccd55c15a83b807e63a4be41dc16b1285dd10f52","revisions":{"ccd55c15a83b807e63a4be41dc16b1285dd10f52":{"kind":"REWORK","_number":1,"created":"2011-11-18 01:21:10.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/48/1748/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/48/1748/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/1748/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/1748/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/1748/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/48/1748/1"}}},"commit":{"parents":[{"commit":"f6c09edf25a6da0fcdb7c2997dbddfaf90b33e21","subject":"pause is admin-api, we shouldn\u0027t be testing it","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f6c09edf25a6da0fcdb7c2997dbddfaf90b33e21"}]}],"author":{"name":"James E. Blair","email":"james.blair@rackspace.com","date":"2011-11-18 01:18:30.000000000","tz":-480},"committer":{"name":"James E. Blair","email":"james.blair@rackspace.com","date":"2011-11-18 01:18:30.000000000","tz":-480},"subject":"Only install needed pip dependencies.","message":"Only install needed pip dependencies.\n\nOnly install pip dependencies that are needed by services\nselected in ENABLED_SERVICES.  This is already the case for debs.\n\nChange-Id: Iff1791bcd95e69d2e5a95179cbf55aafa4bdb307\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ccd55c15a83b807e63a4be41dc16b1285dd10f52"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ccd55c15a83b807e63a4be41dc16b1285dd10f52"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}