)]}'
{"lib/lvm":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c9f5d0720e45378d4ec7ce47eba7b324c272182f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    filter_string\u003d$filter_string$filter_suffix"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    sudo sed -i -r \u0027s/^\\s*(global_filter.*)$/    #\\1/g\u0027 /etc/lvm/lvm.conf"},{"line_number":171,"context_line":"    sudo sed -i \"/# global_filter \u003d \\[*\\]/a\\    $global_filter$filter_string\" /etc/lvm/lvm.conf"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    #remove any duplicate comment lines "},{"line_number":174,"context_line":"    sudo sed -i \u0027$!N; /^\\(.*\\)\\n\\1$/!P; D\u0027 /etc/lvm/lvm.conf"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bab921fb_59ef8db0","line":171,"updated":"2015-04-23 05:33:28.000000000","message":"i don\u0027t get how this adds a duplicate?  this only matches on commented-out \"# global_filter\" lines ... if you\u0027re running it again, it won\u0027t match?","commit_id":"52b674b7ffa8db09734148d7b240f486f088f8d1"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"17f4b011e5975203b98986983033021e2063faf0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    filter_string\u003d$filter_string$filter_suffix"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    sudo sed -i -r \u0027s/^\\s*(global_filter.*)$/    #\\1/g\u0027 /etc/lvm/lvm.conf"},{"line_number":171,"context_line":"    sudo sed -i \"/# global_filter \u003d \\[*\\]/a\\    $global_filter$filter_string\" /etc/lvm/lvm.conf"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    #remove any duplicate comment lines "},{"line_number":174,"context_line":"    sudo sed -i \u0027$!N; /^\\(.*\\)\\n\\1$/!P; D\u0027 /etc/lvm/lvm.conf"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bab921fb_e4b478d2","line":171,"in_reply_to":"bab921fb_59ef8db0","updated":"2015-04-23 06:31:55.000000000","message":"Hi Ian,\n\n This definitely adds a duplicate line of \u0027global_filter\u0027 each time when CI runs devstack because it just appends  without considering there\u0027s one.\n\n please check an example at  http://publiclogs.emc.com/vnx_ostack/EMC_VNX_ISCSI/1870/logs/devstacklog.txt.gz","commit_id":"52b674b7ffa8db09734148d7b240f486f088f8d1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c9f5d0720e45378d4ec7ce47eba7b324c272182f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    sudo sed -i \"/# global_filter \u003d \\[*\\]/a\\    $global_filter$filter_string\" /etc/lvm/lvm.conf"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    #remove any duplicate comment lines "},{"line_number":174,"context_line":"    sudo sed -i \u0027$!N; /^\\(.*\\)\\n\\1$/!P; D\u0027 /etc/lvm/lvm.conf"},{"line_number":175,"context_line":"    echo_summary \"set lvm.conf device global_filter to: $filter_string\""},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bab921fb_794931d0","line":174,"updated":"2015-04-23 05:33:28.000000000","message":"doesn\u0027t this remove *all* duplicates; blank lines, etc included?","commit_id":"52b674b7ffa8db09734148d7b240f486f088f8d1"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"17f4b011e5975203b98986983033021e2063faf0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    sudo sed -i \"/# global_filter \u003d \\[*\\]/a\\    $global_filter$filter_string\" /etc/lvm/lvm.conf"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    #remove any duplicate comment lines "},{"line_number":174,"context_line":"    sudo sed -i \u0027$!N; /^\\(.*\\)\\n\\1$/!P; D\u0027 /etc/lvm/lvm.conf"},{"line_number":175,"context_line":"    echo_summary \"set lvm.conf device global_filter to: $filter_string\""},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bab921fb_64d8681e","line":174,"in_reply_to":"bab921fb_794931d0","updated":"2015-04-23 06:31:55.000000000","message":"Yes this does remove *all* duplicates.\nBut why should there be any duplicates at the first place?\nIf you talk about the blank lines, I can change this to only remove duplicate comment lines starting with \u0027#global_filter...\u0027","commit_id":"52b674b7ffa8db09734148d7b240f486f088f8d1"}]}