)]}'
{"lib/rpc_backend":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1f51e0b867aaa9f829352db597905aa688796ea7","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            sleep 3"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            rabbit_setuser \"$RABBIT_USERID\" \"$RABBIT_PASSWORD\" || rc\u003d$?"},{"line_number":207,"context_line":"            if [ $rc -ne 0 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ad32947_6b9b90ca","line":204,"updated":"2015-04-28 01:28:58.000000000","message":"Why 3sec?","commit_id":"b76122d3bfc8384f0aaa4ac8ec440ab019cbcbd6"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"a3a4ad6dc518fa4b07d52e5efbb76deddd417b5a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            sleep 3"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            rabbit_setuser \"$RABBIT_USERID\" \"$RABBIT_PASSWORD\" || rc\u003d$?"},{"line_number":207,"context_line":"            if [ $rc -ne 0 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ad32947_709c9769","line":204,"in_reply_to":"7ad32947_6b9b90ca","updated":"2015-04-28 08:19:17.000000000","message":"It\u0027s a totally arbitrary value :(. It may not work in other envs....","commit_id":"b76122d3bfc8384f0aaa4ac8ec440ab019cbcbd6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"62edaae59a243ab6de8389d8f3027e2280a2cec5","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            sleep 3"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            rabbit_setuser \"$RABBIT_USERID\" \"$RABBIT_PASSWORD\" || rc\u003d$?"},{"line_number":207,"context_line":"            if [ $rc -ne 0 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ad32947_ae5536c7","line":204,"in_reply_to":"7ad32947_6b9b90ca","updated":"2015-04-28 02:34:47.000000000","message":"isn\u0027t there a nicer way to wait?  eg. rabbitmqctl wait","commit_id":"b76122d3bfc8384f0aaa4ac8ec440ab019cbcbd6"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"a3a4ad6dc518fa4b07d52e5efbb76deddd417b5a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            sleep 3"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            rabbit_setuser \"$RABBIT_USERID\" \"$RABBIT_PASSWORD\" || rc\u003d$?"},{"line_number":207,"context_line":"            if [ $rc -ne 0 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ad32947_90adf38a","line":204,"in_reply_to":"7ad32947_ae5536c7","updated":"2015-04-28 08:19:17.000000000","message":"thanks for the idea, it would be cleaner! I\u0027ll dig into that","commit_id":"b76122d3bfc8384f0aaa4ac8ec440ab019cbcbd6"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"c912f2e4f5992bc1d812e20a1683c9007fbc7c1f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            RABBIT_PID\u003d/var/lib/rabbitmq/mnesia/rabbit@$LOCAL_HOSTNAME.pid"},{"line_number":205,"context_line":"            if [ -e $RABBIT_PID ]; then"},{"line_number":206,"context_line":"                sudo rabbitmqctl wait $RABBIT_PID"},{"line_number":207,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7ad32947_4e2577a9","line":204,"updated":"2015-04-28 10:22:18.000000000","message":"@Rohan, the RABBIT_PID path may not be same on all the platforms. This code may work fine on platforms where the pid file exists at the path you mentioned. However, for platforms where the pid file is stored at a different path, it may not even execute. \n\nI think RABBIT_PID file is an optional parameter. Did you check the behavior without specifying the pid file.","commit_id":"3e11e28475c779638f94f3ae8ec89e5b46c5fb3e"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"38471758ef1d03222b29de0b80042e737c75cc0d","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            RABBIT_PID\u003d/var/lib/rabbitmq/mnesia/rabbit@$LOCAL_HOSTNAME.pid"},{"line_number":205,"context_line":"            if [ -e $RABBIT_PID ]; then"},{"line_number":206,"context_line":"                sudo rabbitmqctl wait $RABBIT_PID"},{"line_number":207,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3acd31a7_326a52b4","line":204,"in_reply_to":"3acd31a7_fa29648a","updated":"2015-05-04 16:11:46.000000000","message":"Unfortunately, this function doesn\u0027t work with no pid file on my plateform (debian stable/jessie)","commit_id":"3e11e28475c779638f94f3ae8ec89e5b46c5fb3e"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e1e5104fe1470838cc2b38e1eef36594b8716ab5","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            RABBIT_PID\u003d/var/lib/rabbitmq/mnesia/rabbit@$LOCAL_HOSTNAME.pid"},{"line_number":205,"context_line":"            if [ -e $RABBIT_PID ]; then"},{"line_number":206,"context_line":"                sudo rabbitmqctl wait $RABBIT_PID"},{"line_number":207,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7ad32947_6f0cad94","line":204,"in_reply_to":"7ad32947_4e2577a9","updated":"2015-04-28 11:53:36.000000000","message":"@Sridhar, thanks for the review.\nthe path configured in the RABBIT_PID variable is the default location of a rabbitmq configuration, as mentioned here : https://www.rabbitmq.com/relocate.html\n\nHowever, I check that the pid file exists before using it, in the line below. So even if on another platform, the path is not the same, it would be harmless.","commit_id":"3e11e28475c779638f94f3ae8ec89e5b46c5fb3e"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"e613e4425c9e2dd9355326fa682a88f362adda68","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            restart_service rabbitmq-server"},{"line_number":204,"context_line":"            RABBIT_PID\u003d/var/lib/rabbitmq/mnesia/rabbit@$LOCAL_HOSTNAME.pid"},{"line_number":205,"context_line":"            if [ -e $RABBIT_PID ]; then"},{"line_number":206,"context_line":"                sudo rabbitmqctl wait $RABBIT_PID"},{"line_number":207,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3acd31a7_fa29648a","line":204,"in_reply_to":"7ad32947_6f0cad94","updated":"2015-05-02 15:26:44.000000000","message":"Atleast on the Ubuntu platform, I do not see the PID file at the path RABBIT_PID eventhough rabbitmq is running on the platform. \n\nSo my suggestion is to simply invoke \"sudo rabbitmqctl wait\" as the PID file seems to be an optional argument.","commit_id":"3e11e28475c779638f94f3ae8ec89e5b46c5fb3e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f0705f482272003d992f6ee29d234acc8af56204","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            # change the rabbit password since the default is \"guest\""},{"line_number":211,"context_line":"            sudo rabbitmqctl change_password \\"},{"line_number":212,"context_line":"                $RABBIT_USERID $RABBIT_PASSWORD || rc\u003d$?"},{"line_number":213,"context_line":"            if [ $rc -ne 0 ]; then"},{"line_number":214,"context_line":"                continue;"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a016987_78873061","side":"PARENT","line":211,"updated":"2015-06-01 14:53:37.000000000","message":"So now we don\u0027t call rabbitmqctl change_password anymore. Was this call useless ?","commit_id":"c9197f6c72039b6029dbe3858b78373d7f3aa96d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70b05e978cfe1e0db291fcbff670ff7b6495efe6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            # change the rabbit password since the default is \"guest\""},{"line_number":211,"context_line":"            sudo rabbitmqctl change_password \\"},{"line_number":212,"context_line":"                $RABBIT_USERID $RABBIT_PASSWORD || rc\u003d$?"},{"line_number":213,"context_line":"            if [ $rc -ne 0 ]; then"},{"line_number":214,"context_line":"                continue;"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a016987_f85b2052","side":"PARENT","line":211,"in_reply_to":"7a016987_78873061","updated":"2015-06-01 15:05:50.000000000","message":"Yes, commit d5b74c68 introduced the function rabbit_setuser called above, which makes exactly the same call (among others), so this code should already have been dropped then. Probably this should be a separate patch even, but it was quite convenient to be able to change the loop logic once this block is gone.","commit_id":"c9197f6c72039b6029dbe3858b78373d7f3aa96d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af8d7546d182e3a1de62e20591f0f81b982d9df7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            rabbit_setuser \"$RABBIT_USERID\" \"$RABBIT_PASSWORD\" \u0026\u0026 break"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            restart_service rabbitmq-server"},{"line_number":206,"context_line":"            RABBIT_PID\u003d/var/lib/rabbitmq/mnesia/rabbit@$LOCAL_HOSTNAME.pid"},{"line_number":207,"context_line":"            if [ -e $RABBIT_PID ]; then"},{"line_number":208,"context_line":"                sudo rabbitmqctl wait $RABBIT_PID"},{"line_number":209,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5afe65bd_b32a3b2b","line":206,"updated":"2015-06-01 22:15:50.000000000","message":"This is a nice idea but as I see it the problem here is that the path to the PID file is in admin control.  That essentially means we need to:\na) guess at the path (and fail if we get it wrong) ; or\nb) source the rabbitmq-server envionments (plural) to get the correct path.\n(Option 2: is what I have reccomended to the debian/ubuntu packagers)","commit_id":"b43fbc13e609daeacd9f0b15243fa06ceaacfc24"}]}