)]}'
{"lib/cinder":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"bfb5f2bfcb37b25b08f72acf64e881fd5d367902","unresolved":false,"context_lines":[{"line_number":79,"context_line":"# Should cinder perform secure deletion of volumes?"},{"line_number":80,"context_line":"# Defaults to true, can be set to False to avoid this bug when testing:"},{"line_number":81,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1023755"},{"line_number":82,"context_line":"CINDER_SECURE_DELETE\u003d$(trueorfalse True CINDER_SECURE_DELETE)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Cinder reports allocations back to the scheduler on periodic intervals"},{"line_number":85,"context_line":"# it turns out we can get an \"out of space\" issue when we run tests too"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3acd31a7_7c3538f5","side":"PARENT","line":82,"updated":"2015-05-04 17:03:36.000000000","message":"I think this line should stay for as long as CINDER_SECURE_DELETE is around, it handles the normalization into True or False values.\n\n  if [[ -n $CINDER_SECURE_DELETE ]]; then\n    CINDER_SECURE_DELETE\u003d$(trueorfalse True CINDER_SECURE_DELETE)\n    if [[ $CINDER_SECURE_DELETE \u003d\u003d \"False\" ]]; then\n      # True (or zero) is already the default for CINDER_VOLUME_CLEAR so don\u0027t bother here\n      CINDER_VOLUME_CLEAR_DEFAULT\u003dnone\n    fi\n    # set DEPRECATED_TEXT\n  fi","commit_id":"459c793060113e06e258a3a4ae76a9cda6aa1f4d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"bfb5f2bfcb37b25b08f72acf64e881fd5d367902","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# Equivalents using CINDER_VOLUME_CLEAR are zero and none, respectively."},{"line_number":83,"context_line":"# Set to none to avoid this bug when testing:"},{"line_number":84,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1023755"},{"line_number":85,"context_line":"CINDER_VOLUME_CLEAR\u003d${CINDER_VOLUME_CLEAR:-zero}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Cinder reports allocations back to the scheduler on periodic intervals"},{"line_number":88,"context_line":"# it turns out we can get an \"out of space\" issue when we run tests too"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3acd31a7_6f9fbcb4","line":85,"updated":"2015-05-04 17:03:36.000000000","message":"CINDER_VOLUME_CLEAR\u003d${CINDER_VOLUME_CLEAR:-${CINDER_VOLUME_CLEAR_DEFAULT:-zero}}","commit_id":"f5a074fd1c638c7e7bd57ca35a68319571c65dcb"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"dfad7b3b93398862d6cdc46ec9c3337b2ca87e58","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# Equivalents using CINDER_VOLUME_CLEAR are zero and none, respectively."},{"line_number":83,"context_line":"# Set to none to avoid this bug when testing:"},{"line_number":84,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1023755"},{"line_number":85,"context_line":"CINDER_VOLUME_CLEAR\u003d${CINDER_VOLUME_CLEAR:-zero}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Cinder reports allocations back to the scheduler on periodic intervals"},{"line_number":88,"context_line":"# it turns out we can get an \"out of space\" issue when we run tests too"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3acd31a7_4f13e066","line":85,"in_reply_to":"3acd31a7_6f9fbcb4","updated":"2015-05-04 17:06:36.000000000","message":"There\u0027s a default area? So there is. :)","commit_id":"f5a074fd1c638c7e7bd57ca35a68319571c65dcb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"bfb5f2bfcb37b25b08f72acf64e881fd5d367902","unresolved":false,"context_lines":[{"line_number":267,"context_line":"\t    CINDER_VOLUME_CLEAR\u003d\u0027none\u0027"},{"line_number":268,"context_line":"        fi"},{"line_number":269,"context_line":"        DEPRECATED_TEXT\u003d\"$DEPRECATED_TEXT\\nConfigure secure Cinder volume deletion using CINDER_VOLUME_CLEAR instead of CINDER_SECURE_DELETE.\\n\""},{"line_number":270,"context_line":"    fi"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    # Was previously CINDER_SECURE_DELETE (True or False)"},{"line_number":273,"context_line":"    # Equivalents using CINDER_VOLUME_CLEAR are zero and none, respectively"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3acd31a7_cfaed084","line":270,"updated":"2015-05-04 17:03:36.000000000","message":"You can simplify this slightly and should keep the trueorfalse function call to normalize the values properly.  And move it up to where the defaults are set around line 80.","commit_id":"f5a074fd1c638c7e7bd57ca35a68319571c65dcb"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"dfad7b3b93398862d6cdc46ec9c3337b2ca87e58","unresolved":false,"context_lines":[{"line_number":267,"context_line":"\t    CINDER_VOLUME_CLEAR\u003d\u0027none\u0027"},{"line_number":268,"context_line":"        fi"},{"line_number":269,"context_line":"        DEPRECATED_TEXT\u003d\"$DEPRECATED_TEXT\\nConfigure secure Cinder volume deletion using CINDER_VOLUME_CLEAR instead of CINDER_SECURE_DELETE.\\n\""},{"line_number":270,"context_line":"    fi"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    # Was previously CINDER_SECURE_DELETE (True or False)"},{"line_number":273,"context_line":"    # Equivalents using CINDER_VOLUME_CLEAR are zero and none, respectively"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3acd31a7_cf301004","line":270,"in_reply_to":"3acd31a7_cfaed084","updated":"2015-05-04 17:06:36.000000000","message":"Ah, I should have caught that. Yes, I\u0027ll keep that.","commit_id":"f5a074fd1c638c7e7bd57ca35a68319571c65dcb"}]}