)]}'
{"lib/quantum_plugins/ryu":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d0d1069b457b9076f0a45e0a521684094a66341b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _quantum_ovs_base_install_agent_packages"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # quantum_ryu_agent requires ryu module"},{"line_number":20,"context_line":"    if ! is_service_enabled ryu; then"},{"line_number":21,"context_line":"        install_ryu"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FFiI%3D","line":20,"updated":"2013-02-07 15:37:11.000000000","message":"Is this test reversed?","commit_id":"a1678b36f4c38f9406e553475d267dc51b8b1cad"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1b0d8bca5c5206db656f679b3da2a28b2e45c74b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _quantum_ovs_base_install_agent_packages"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # quantum_ryu_agent requires ryu module"},{"line_number":20,"context_line":"    if ! is_service_enabled ryu; then"},{"line_number":21,"context_line":"        install_ryu"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FEME%3D","line":20,"in_reply_to":"AAAAM3%2F%2FEcc%3D","updated":"2013-02-08 08:28:56.000000000","message":"@dean Thanks for your followup. I forgot to comment it. Isaku\u0027s new patch set treats it well.","commit_id":"a1678b36f4c38f9406e553475d267dc51b8b1cad"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"82e802ed4f7ed5662c1a999d8de5d7d50f348680","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _quantum_ovs_base_install_agent_packages"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # quantum_ryu_agent requires ryu module"},{"line_number":20,"context_line":"    if ! is_service_enabled ryu; then"},{"line_number":21,"context_line":"        install_ryu"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FFRo%3D","line":20,"in_reply_to":"AAAAM3%2F%2FFZ4%3D","updated":"2013-02-07 18:11:41.000000000","message":"@isaku: thanks, it wasn\u0027t clear from the comment that this was the case.\n\n@akihiro: keep in mind that git_clone() does re-checkout the repo if RECLONE\u003dyes.  I don\u0027t know if that matters here but it isn\u0027t always obvious.","commit_id":"a1678b36f4c38f9406e553475d267dc51b8b1cad"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"665662d2d102f8852f6235ccc30d077d0ccd3591","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _quantum_ovs_base_install_agent_packages"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # quantum_ryu_agent requires ryu module"},{"line_number":20,"context_line":"    if ! is_service_enabled ryu; then"},{"line_number":21,"context_line":"        install_ryu"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FEcc%3D","line":20,"in_reply_to":"AAAAM3%2F%2FFZ4%3D","updated":"2013-02-08 03:29:54.000000000","message":"Done","commit_id":"a1678b36f4c38f9406e553475d267dc51b8b1cad"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"76fcb8da1b5fba2ee3802d31dc3d35c6e79f2849","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _quantum_ovs_base_install_agent_packages"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # quantum_ryu_agent requires ryu module"},{"line_number":20,"context_line":"    if ! is_service_enabled ryu; then"},{"line_number":21,"context_line":"        install_ryu"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FFZ4%3D","line":20,"in_reply_to":"AAAAM3%2F%2FFf4%3D","updated":"2013-02-07 16:57:28.000000000","message":"It would be better to change install_ryu so that it can be called multiple times. If so this if clause is no longer required.\n\nIn addition, now install_ryu() just calls git_clone. As git_clone checks if the directory exists, git_clone can be calls multiple times safely I believe.","commit_id":"a1678b36f4c38f9406e553475d267dc51b8b1cad"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c6e3b77b59e7edf0c62914e54458e09633768f79","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _quantum_ovs_base_install_agent_packages"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # quantum_ryu_agent requires ryu module"},{"line_number":20,"context_line":"    if ! is_service_enabled ryu; then"},{"line_number":21,"context_line":"        install_ryu"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FFf4%3D","line":20,"in_reply_to":"AAAAM3%2F%2FFiI%3D","updated":"2013-02-07 16:14:41.000000000","message":"No.\nEven if ryu service is disabled, quantum_ryu_agent needs ryu module.\nIf ryu service is enabled, ryu is already installed, so it is not necessary to install ryu again.","commit_id":"a1678b36f4c38f9406e553475d267dc51b8b1cad"}]}
