)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ac9e6479ee3b99fcd3c6308212f21c31388ffb34","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Xenserver and Ironic were both unconditionally tacking on an additional image"},{"line_number":10,"context_line":"to the `IMAGE_URLS` list. If the user specified that image themselves (as"},{"line_number":11,"context_line":"directed by current documentation), then devstack would attempt to upload the"},{"line_number":12,"context_line":"image to Glance twice, resulting in a 409 error, and devstack failing."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The fix is to only tack on that additional image if `IMAGE_URLS` has not been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3acd31a7_aeedc8b8","line":11,"updated":"2015-05-05 02:15:54.000000000","message":"if the defaults are correct, why not remove this bit from tools/xen/README.md?","commit_id":"cd82fe2c50978cc314895428284404e483eb415b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4b5af7e39f4b1941335cd5fa78096af2d24179fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Xenserver and Ironic were both unconditionally tacking on an additional image"},{"line_number":10,"context_line":"to the `IMAGE_URLS` list. If the user specified that image themselves (as"},{"line_number":11,"context_line":"directed by current documentation), then devstack would attempt to upload the"},{"line_number":12,"context_line":"image to Glance twice, resulting in a 409 error, and devstack failing."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The fix is to only tack on that additional image if `IMAGE_URLS` has not been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3acd31a7_c30f9937","line":11,"in_reply_to":"3acd31a7_27ce6782","updated":"2015-05-06 00:06:50.000000000","message":"Not sure we\u0027re talking about the same thing -- I think this should include removal of the IMAGE_URLS bit of tools/xen/README.md, because why is that necessary?  If you just leave it alone, it seems stackrc gets the right images","commit_id":"cd82fe2c50978cc314895428284404e483eb415b"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"98b468206df264c3335b945ee8abb4cb56caaccb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Xenserver and Ironic were both unconditionally tacking on an additional image"},{"line_number":10,"context_line":"to the `IMAGE_URLS` list. If the user specified that image themselves (as"},{"line_number":11,"context_line":"directed by current documentation), then devstack would attempt to upload the"},{"line_number":12,"context_line":"image to Glance twice, resulting in a 409 error, and devstack failing."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The fix is to only tack on that additional image if `IMAGE_URLS` has not been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3acd31a7_27ce6782","line":11,"in_reply_to":"3acd31a7_aeedc8b8","updated":"2015-05-05 15:16:40.000000000","message":"The defaults aren\u0027t correct though, IMHO.\n\nIf I provide IMAGE_URLS, then by principle of least-surprise, I expect those (and only those) images to be downloaded. The documentation--I think correctly--reflects that.\n\nThe code, however, is using a broken pattern for adding defaults, and so is violating that principle.\n\nIf you go back and do a git-blame, you can actually see how this bug developed from Jun 30th 2014 to Aug 2014.\n\nTrove introduced the IMAGE_URLS+\u003d\u003coption\u003e pattern in June. This was okay because Trove uses a separate environment variable to specify it\u0027s image, so what it\u0027s doing is tacking on that separate config option to the list of images to be downloaded.\n\nIn July and August, though, it appears as if the Trove code was copy and pasted into the xenserver and ironic handlers.\n\nIt doesn\u0027t make sense here because IMAGE_URLS is the environment variable the user interacts with and so should have full control over.\n\nWhat I think the xenserver and ironic devs really wanted to do was just provide a sensible default in case IMAGE_URLS wasn\u0027t supplied, as is common with tempest tests.","commit_id":"cd82fe2c50978cc314895428284404e483eb415b"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"67fca19f5430efed1babe8df8cbe9daf13e5293a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Xenserver and Ironic were both unconditionally tacking on an additional image"},{"line_number":10,"context_line":"to the `IMAGE_URLS` list. If the user specified that image themselves (as"},{"line_number":11,"context_line":"directed by current documentation), then devstack would attempt to upload the"},{"line_number":12,"context_line":"image to Glance twice, resulting in a 409 error, and devstack failing."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The fix is to only tack on that additional image if `IMAGE_URLS` has not been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aca2d91_dd6824bd","line":11,"in_reply_to":"3acd31a7_c30f9937","updated":"2015-05-06 14:57:20.000000000","message":"Yeah entirely possible I misunderstood your comment, allergies + Claratin-D had me pretty loopy yesterday.\n\nHmm, I don\u0027t really have an opinion either way of whether the README should have it; it\u0027s nice that the code has a sensible default now so we don\u0027t need it, but it\u0027s also nice to demonstrate how to override with your own custom set of images.\n\nI guess nuking it\u0027s fine though, so I\u0027ll just do it...","commit_id":"cd82fe2c50978cc314895428284404e483eb415b"}]}