)]}'
{"openrc":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0564c9bccf4f344b8ce532dae6fff691b45869d6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_AUTH_PROTOCOL://$KEYSTONE_AUTH_HOST:5000/v${OS_IDENTITY_API_VERSION}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Set the pointer to our CA certificate chain.  Harmless if TLS is not used."},{"line_number":82,"context_line":"export OS_CACERT\u003d${OS_CACERT:-$INT_CA_DIR/ca-chain.pem}"},{"line_number":83,"context_line":"# If the file does not exist, we should not try to use it."},{"line_number":84,"context_line":"[[ -e $OS_CACERT ]] || unset OS_CACERT"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3acd31a7_9e59f637","line":81,"updated":"2015-05-06 00:22:59.000000000","message":"so in fact this is not harmless?  wrapping this in an if statement seems like it would make this clearer (I get that you\u0027re trying to let bash expand it), or at least fix what this is saying","commit_id":"ffb3b85921a13340056e2e65e6f08d7a0049bb08"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5b4f717e6f67607386bcb489f40ec5ede0a56734","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_AUTH_PROTOCOL://$KEYSTONE_AUTH_HOST:5000/v${OS_IDENTITY_API_VERSION}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Set the pointer to our CA certificate chain.  Harmless if TLS is not used."},{"line_number":82,"context_line":"export OS_CACERT\u003d${OS_CACERT:-$INT_CA_DIR/ca-chain.pem}"},{"line_number":83,"context_line":"# If the file does not exist, we should not try to use it."},{"line_number":84,"context_line":"[[ -e $OS_CACERT ]] || unset OS_CACERT"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1aca2d91_549f4103","line":81,"in_reply_to":"1aca2d91_39095e2d","updated":"2015-05-06 20:57:27.000000000","message":"So, I have pushed a second patch which uses if\u0027s and is far more explicit. IMO though, that one is far harder to read. That said, patch 2 will allow an externally set OS_CACERT to fall through even if it doesn\u0027t exist, which is actually a good thing I think.","commit_id":"ffb3b85921a13340056e2e65e6f08d7a0049bb08"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0a608e7f5bc64b83091388f3b4efd8b0bb8653dd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_AUTH_PROTOCOL://$KEYSTONE_AUTH_HOST:5000/v${OS_IDENTITY_API_VERSION}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Set the pointer to our CA certificate chain.  Harmless if TLS is not used."},{"line_number":82,"context_line":"export OS_CACERT\u003d${OS_CACERT:-$INT_CA_DIR/ca-chain.pem}"},{"line_number":83,"context_line":"# If the file does not exist, we should not try to use it."},{"line_number":84,"context_line":"[[ -e $OS_CACERT ]] || unset OS_CACERT"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1aca2d91_39095e2d","line":81,"in_reply_to":"3acd31a7_9e59f637","updated":"2015-05-06 20:15:44.000000000","message":"I think it would be clearer to just not set it in the first place, even if it takes a few more lines.","commit_id":"ffb3b85921a13340056e2e65e6f08d7a0049bb08"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f028e5b800f4bb8e87d12593775274ba1a2e57b5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_AUTH_PROTOCOL://$KEYSTONE_AUTH_HOST:5000/v${OS_IDENTITY_API_VERSION}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Set OS_CACERT to a default CA certificate chain if it exists."},{"line_number":82,"context_line":"if [[ ! -v OS_CACERT ]] ; then"},{"line_number":83,"context_line":"    DEFAULT_OS_CACERT\u003d$INT_CA_DIR/ca-chain.pem"},{"line_number":84,"context_line":"    # If the file does not exist, this may confuse preflight sanity checks"},{"line_number":85,"context_line":"    if [ -e $DEFAULT_OS_CACERT ] ; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1aca2d91_0f740f33","line":82,"updated":"2015-05-07 00:04:00.000000000","message":"i\u0027m not sure if this is zsh safe, but i think we decided this file was bash only anyway...","commit_id":"52a3bebcfcb09ec2b78d0357f1a074458ab04053"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"df7ff80b0244680a0f2e1093cc7f1d6bf89f3563","unresolved":false,"context_lines":[{"line_number":79,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_AUTH_PROTOCOL://$KEYSTONE_AUTH_HOST:5000/v${OS_IDENTITY_API_VERSION}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Set OS_CACERT to a default CA certificate chain if it exists."},{"line_number":82,"context_line":"if [[ ! -v OS_CACERT ]] ; then"},{"line_number":83,"context_line":"    DEFAULT_OS_CACERT\u003d$INT_CA_DIR/ca-chain.pem"},{"line_number":84,"context_line":"    # If the file does not exist, this may confuse preflight sanity checks"},{"line_number":85,"context_line":"    if [ -e $DEFAULT_OS_CACERT ] ; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1aca2d91_b84c2871","line":82,"in_reply_to":"1aca2d91_0f740f33","updated":"2015-05-07 14:16:23.000000000","message":"This file may be the unwritten exception to bash 4+ only...it is useful as an example because it is used interactively.  -z should also work ok here?\n\nActually, can this be simplified a bit by just doing both conditionals together?\n\n  if [[ -z $OS_CACERT ]] \u0026\u0026 [[ -e $INT_CA_DIR/ca-chain.pem ]]; then\n  ...","commit_id":"52a3bebcfcb09ec2b78d0357f1a074458ab04053"}]}