)]}'
{"lib/nova":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"36ef9b98d58c5eb9fdef715ecbb96eaa7adaef58","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    install_default_policy nova"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    configure_rootwrap nova $NOVA_BIN_DIR/nova-rootwrap $NOVA_DIR/etc/nova"},{"line_number":302,"context_line":"    configure_rootwrap nova $NOVA_BIN_DIR/nova-rootwrap-daemon $NOVA_DIR/etc/nova"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \"n-api\" ]]; then"},{"line_number":305,"context_line":"        # Get the sample configuration file in place"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a0c5dc1_7e7227e7","line":302,"updated":"2015-05-12 23:43:27.000000000","message":"this function doesn\u0027t look like it\u0027s designed to be idempotent, and doing this for every service seems a bit weird.  \n\nis the only difference that one has the argument and the other doesn\u0027t?  do they both need to be configured?\n\nif anything, I think you could reorganise the arguments to configure_rootwrap so the bin is last, then you could specify multiple bin\u0027s and just have the function consume as many as are there; avoiding multiple calls and all the duplicate work","commit_id":"df7fe3b3fee4cb0059a835ebf2813ecd63e16127"}]}