)]}'
{"id":"openstack%2Fdevstack~181833","triplet_id":"openstack%2Fdevstack~master~Ie48a859476faff22a4dfef466516e2d7d62ef0c0","project":"openstack/devstack","branch":"master","topic":"bug/1453687","hashtags":[],"change_id":"Ie48a859476faff22a4dfef466516e2d7d62ef0c0","subject":"Fix function and test for \u0027trueorfalse\u0027.","status":"MERGED","created":"2015-05-11 09:06:03.000000000","updated":"2015-05-21 01:14:34.000000000","submitted":"2015-05-12 21:34:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"baca5c3d916bcddcc2ce1c7e772508cb9b32ffb5","_number":181833,"virtual_id_number":181833,"owner":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-05-21 01:14:34.000000000","post_submit":true,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":2,"date":"2015-05-12 21:34:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-05-11 23:46:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-05-12 01:57:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":2,"date":"2015-05-11 20:17:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2015-05-12 19:50:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2015-05-12 19:50:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-11 20:17:48.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-05-11 23:46:26.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2015-05-12 01:57:06.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-05-12 19:50:23.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-05-12 21:34:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-21 01:14:34.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ae9d002757af4bc34b1b73d63502173fb57292be","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-05-11 09:06:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82b9e34da208899ba8b63e58e7f2ce4019c3f420","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-05-11 09:27:03.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c88493241f638b1f90dd14d4b11439b1916b56ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-11 10:16:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/33/181833/2/check/check-tempest-dsvm-full/05b3f45/ : SUCCESS in 45m 55s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/33/181833/2/check/check-tempest-dsvm-postgres-full/49e72fb/ : SUCCESS in 40m 19s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/33/181833/2/check/check-tempest-dsvm-neutron-full/2d21d6f/ : SUCCESS in 49m 46s\n- check-grenade-dsvm http://logs.openstack.org/33/181833/2/check/check-grenade-dsvm/587314b/ : SUCCESS in 40m 37s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/33/181833/2/check/gate-tempest-dsvm-large-ops/78788c4/ : SUCCESS in 25m 30s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/33/181833/2/check/gate-tempest-dsvm-neutron-large-ops/aa8804f/ : SUCCESS in 22m 09s\n- gate-devstack-bashate http://logs.openstack.org/33/181833/2/check/gate-devstack-bashate/8fa5b9f/ : SUCCESS in 17s\n- gate-devstack-unit-tests http://logs.openstack.org/33/181833/2/check/gate-devstack-unit-tests/d16d24e/ : SUCCESS in 17s\n- check-devstack-dsvm-cells http://logs.openstack.org/33/181833/2/check/check-devstack-dsvm-cells/5ef75b6/ : SUCCESS in 19m 31s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/33/181833/2/check/check-grenade-dsvm-partial-ncpu/263b812/ : SUCCESS in 37m 25s\n- check-swift-dsvm-functional http://logs.openstack.org/33/181833/2/check/check-swift-dsvm-functional/a3ffcf9/ : SUCCESS in 22m 47s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/33/181833/2/check/check-tempest-dsvm-ironic-pxe_ssh/3c2ca52/ : SUCCESS in 33m 40s\n- check-devstack-dsvm-updown http://logs.openstack.org/33/181833/2/check/check-devstack-dsvm-updown/b69a704/ : SUCCESS in 18m 04s\n- check-tempest-dsvm-f21 http://logs.openstack.org/33/181833/2/check/check-tempest-dsvm-f21/3ac5c4e/ : SUCCESS in 38m 03s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/33/181833/2/check/check-tempest-dsvm-centos7/2d54a27/ : FAILURE in 38m 49s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/33/181833/2/check/gate-devstack-publish-docs/bbe1bdf//doc/build/html/ : SUCCESS in 1m 26s\n- check-grenade-dsvm-neutron http://logs.openstack.org/33/181833/2/check/check-grenade-dsvm-neutron/9618638/ : SUCCESS in 46m 48s","accounts_in_message":[],"_revision_number":2},{"id":"340f8fae3d4810c9a845b866a807cc46b7d79077","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-11 20:17:48.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks for cleaning this up","accounts_in_message":[],"_revision_number":2},{"id":"aa5b752d9a84438db70304ba1002f808323acfda","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-05-11 23:46:26.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"de865b0b9c83c683127079c0df61a5e62785ee26","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-05-12 01:57:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8e339209785ac900c90430f11328ad8c7895790f","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-12 19:50:23.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"28abef1f81e306cdb484c4daf2f5a0772666500d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 19:56:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ea7c9209e91516cb1bb8be95822c659b6586b3b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 21:34:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/33/181833/2/gate/gate-tempest-dsvm-full/aa8824a/ : SUCCESS in 38m 57s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/33/181833/2/gate/gate-tempest-dsvm-postgres-full/08aa2ab/ : SUCCESS in 42m 02s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/33/181833/2/gate/gate-tempest-dsvm-neutron-full/dccf954/ : SUCCESS in 54m 20s\n- gate-grenade-dsvm http://logs.openstack.org/33/181833/2/gate/gate-grenade-dsvm/7c882ab/ : SUCCESS in 35m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/33/181833/2/gate/gate-tempest-dsvm-large-ops/0629894/ : SUCCESS in 22m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/33/181833/2/gate/gate-tempest-dsvm-neutron-large-ops/600be48/ : SUCCESS in 26m 26s\n- gate-devstack-bashate http://logs.openstack.org/33/181833/2/gate/gate-devstack-bashate/59a0429/ : SUCCESS in 28s\n- gate-devstack-dsvm-cells http://logs.openstack.org/33/181833/2/gate/gate-devstack-dsvm-cells/5a4d427/ : SUCCESS in 20m 24s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/33/181833/2/gate/gate-grenade-dsvm-partial-ncpu/b718e00/ : SUCCESS in 50m 26s\n- gate-swift-dsvm-functional http://logs.openstack.org/33/181833/2/gate/gate-swift-dsvm-functional/8c3c614/ : SUCCESS in 21m 53s","accounts_in_message":[],"_revision_number":2},{"id":"be688ac66ebdd2b124394058511679c8312bc410","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 21:34:31.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"33ab52d4ee57b603d4009e79d17db8800d2e291c","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-05-21 01:14:34.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/33/181833/2/16136/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"98f59aafaf88328f6aee98efa0f563fb8bf91ebd","revisions":{"e7aee8bb15536d30dd576cc8f819f6003011b746":{"kind":"REWORK","_number":1,"created":"2015-05-11 09:06:03.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/33/181833/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/33/181833/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/181833/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/181833/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/181833/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/33/181833/1"}}},"commit":{"parents":[{"commit":"e3fcc54b9ba99577d9d74d175b86974aab208514","subject":"Merge \"Add toggle to run Nova API and EC2-API under Apache2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e3fcc54b9ba99577d9d74d175b86974aab208514"}]}],"author":{"name":"Mahito OGURA","email":"earthdragon77@gmail.com","date":"2015-05-11 09:02:34.000000000","tz":540},"committer":{"name":"Mahito OGURA","email":"earthdragon77@gmail.com","date":"2015-05-11 09:02:34.000000000","tz":540},"subject":"Fix function and test for \u0027trueorfalse\u0027.","message":"Fix function and test for \u0027trueorfalse\u0027.\n\nThe function\u0027s comment is written as follow, however the function accepts\nother values (ex. \"e\", \"t\", \"T\", \"f\", \"F\", etc...).\n\n---\n---\n\nThis patch fixes the issue and add test patterns.\n\nChange-Id: Ie48a859476faff22a4dfef466516e2d7d62ef0c0\nCloses-bug: #1453687\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e7aee8bb15536d30dd576cc8f819f6003011b746"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e7aee8bb15536d30dd576cc8f819f6003011b746"}]},"branch":"refs/heads/master"},"98f59aafaf88328f6aee98efa0f563fb8bf91ebd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-05-11 09:27:03.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/33/181833/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/33/181833/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/181833/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/181833/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/181833/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/33/181833/2"}}},"commit":{"parents":[{"commit":"e3fcc54b9ba99577d9d74d175b86974aab208514","subject":"Merge \"Add toggle to run Nova API and EC2-API under Apache2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e3fcc54b9ba99577d9d74d175b86974aab208514"}]}],"author":{"name":"Mahito OGURA","email":"earthdragon77@gmail.com","date":"2015-05-11 09:02:34.000000000","tz":540},"committer":{"name":"Mahito OGURA","email":"earthdragon77@gmail.com","date":"2015-05-11 09:23:07.000000000","tz":540},"subject":"Fix function and test for \u0027trueorfalse\u0027.","message":"Fix function and test for \u0027trueorfalse\u0027.\n\nThe function\u0027s comment is written as follow, however the function accepts\nother values (ex. \"e\", \"t\", \"T\", \"f\", \"F\", etc...).\n\n---\nAccepts as False: 0 no No NO false False FALSE\nAccepts as True: 1 yes Yes YES true True TRUE\n---\n\nMoreover if testval mach True or False, the function exits without resetting\nxtrace.\n\nThis patch fixes the issue and add test patterns.\n\nChange-Id: Ie48a859476faff22a4dfef466516e2d7d62ef0c0\nCloses-bug: #1453687\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/98f59aafaf88328f6aee98efa0f563fb8bf91ebd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/98f59aafaf88328f6aee98efa0f563fb8bf91ebd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}