)]}'
{"id":"openstack%2Fdevstack~182301","triplet_id":"openstack%2Fdevstack~master~If3edbf21e0e87cbba4f893385ed53f25faf1f551","project":"openstack/devstack","branch":"master","topic":"fix-clean-iptables","hashtags":[],"change_id":"If3edbf21e0e87cbba4f893385ed53f25faf1f551","subject":"Make clean_iptables really clean all entries","status":"ABANDONED","created":"2015-05-12 13:57:52.000000000","updated":"2016-06-29 18:28:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8ddfe1a5c92d32a37ce269520ccab530c5333e56","_number":182301,"virtual_id_number":182301,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-05-12 15:16:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-05-12 20:05:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-12 15:16:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-12 20:05:39.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"18548e6a657451bc2ae74b5c40dbd9ef911091a7","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-05-12 13:57:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a957445ad50b65b13e13ec9c1c6a67998116b5df","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 15:16:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/01/182301/1/check/check-tempest-dsvm-full/6030d55/ : SUCCESS in 45m 04s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/01/182301/1/check/check-tempest-dsvm-postgres-full/0d8576b/ : SUCCESS in 36m 24s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/01/182301/1/check/check-tempest-dsvm-neutron-full/4c946db/ : SUCCESS in 57m 18s\n- check-grenade-dsvm http://logs.openstack.org/01/182301/1/check/check-grenade-dsvm/96b577b/ : SUCCESS in 39m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/01/182301/1/check/gate-tempest-dsvm-large-ops/019c251/ : SUCCESS in 26m 26s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/01/182301/1/check/gate-tempest-dsvm-neutron-large-ops/6aa224a/ : SUCCESS in 25m 24s\n- gate-devstack-bashate http://logs.openstack.org/01/182301/1/check/gate-devstack-bashate/bd3ebfa/ : SUCCESS in 24s\n- gate-devstack-unit-tests http://logs.openstack.org/01/182301/1/check/gate-devstack-unit-tests/83ad034/ : SUCCESS in 25s\n- check-devstack-dsvm-cells http://logs.openstack.org/01/182301/1/check/check-devstack-dsvm-cells/6397f6b/ : SUCCESS in 20m 41s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/01/182301/1/check/check-grenade-dsvm-partial-ncpu/b3d7006/ : SUCCESS in 40m 08s\n- check-swift-dsvm-functional http://logs.openstack.org/01/182301/1/check/check-swift-dsvm-functional/bf4962d/ : SUCCESS in 25m 38s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/01/182301/1/check/check-tempest-dsvm-ironic-pxe_ssh/a4cc8dd/ : SUCCESS in 34m 33s\n- check-devstack-dsvm-updown http://logs.openstack.org/01/182301/1/check/check-devstack-dsvm-updown/fbf284d/ : SUCCESS in 20m 31s\n- check-tempest-dsvm-f21 http://logs.openstack.org/01/182301/1/check/check-tempest-dsvm-f21/6ec1e98/ : FAILURE in 1h 16m 54s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/01/182301/1/check/check-tempest-dsvm-centos7/6c0c4d5/ : FAILURE in 39m 15s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/01/182301/1/check/gate-devstack-publish-docs/41536f5//doc/build/html/ : SUCCESS in 1m 22s\n- check-grenade-dsvm-neutron http://logs.openstack.org/01/182301/1/check/check-grenade-dsvm-neutron/1c944e0/ : SUCCESS in 49m 01s","accounts_in_message":[],"_revision_number":1},{"id":"b4eceb77c874ee6082d1037fec80382f13b84d17","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-12 20:05:39.000000000","message":"Patch Set 1: Code-Review-1\n\ni agree this needs some help ... but i don\u0027t think saving to a temp file is really necessary and it\u0027s not like anything else we do. There\u0027s still a lot of duplication in the commands too ...  this seems like something a list and \"xargs\" could do just fine and not need to fork out","accounts_in_message":[],"_revision_number":1},{"id":"7aa054948f3905b4403bc750ee780681686ae29f","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2016-06-29 18:28:38.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0cbd9dfe703a7c5bf8b51df5b676062ee468a662","revisions":{"0cbd9dfe703a7c5bf8b51df5b676062ee468a662":{"kind":"REWORK","_number":1,"created":"2015-05-12 13:57:52.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/01/182301/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/01/182301/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/182301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/182301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/182301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/01/182301/1"}}},"commit":{"parents":[{"commit":"d5bcc42a71083eebf74d645a2bf1eb0c5367dea0","subject":"Merge \"lib/swift: the s3_token middleware should be provided by keystonemiddleware\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d5bcc42a71083eebf74d645a2bf1eb0c5367dea0"}]}],"author":{"name":"Jens Rosenboom","email":"j.rosenboom@x-ion.de","date":"2015-05-12 13:51:29.000000000","tz":120},"committer":{"name":"Jens Rosenboom","email":"j.rosenboom@x-ion.de","date":"2015-05-12 13:51:29.000000000","tz":120},"subject":"Make clean_iptables really clean all entries","message":"Make clean_iptables really clean all entries\n\nThe old code creates a list of commands and pipes it into bash. Under\ncertain circumstances, i.e. running under Ubuntu Vivid, the first\ncommand eats up all of stdin, resulting in the following commands not\nbeing executed.\n\nFix that by writing all of the commands into a tmpfile first, which is\nthen executed by bash.\n\nChange-Id: If3edbf21e0e87cbba4f893385ed53f25faf1f551\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0cbd9dfe703a7c5bf8b51df5b676062ee468a662"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0cbd9dfe703a7c5bf8b51df5b676062ee468a662"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
