)]}'
{"lib/glance":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4073d8a08a42206aba563739764497561bacfd19","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            iniset $GLANCE_API_CONF glance_store swift_store_key $SERVICE_PASSWORD"},{"line_number":160,"context_line":"            iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":161,"context_line":"            iniset $GLANCE_API_CONF glance_store stores \"file, http, swift\""},{"line_number":162,"context_line":"            ;;"},{"line_number":163,"context_line":"        *)"},{"line_number":164,"context_line":"            # default to the filesystem"},{"line_number":165,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store file"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_9dccb762","line":162,"updated":"2015-05-27 12:20:26.000000000","message":"although file is the default, you might want to add a case for `file | filesystem` here.","commit_id":"53c43cfeb95ae17d9eac7e8b61c297064072615b"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"e7d8d9a4938563cf38880141d2baee8aa970df1a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            iniset $GLANCE_API_CONF glance_store swift_store_key $SERVICE_PASSWORD"},{"line_number":160,"context_line":"            iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":161,"context_line":"            iniset $GLANCE_API_CONF glance_store stores \"file, http, swift\""},{"line_number":162,"context_line":"            ;;"},{"line_number":163,"context_line":"        *)"},{"line_number":164,"context_line":"            # default to the filesystem"},{"line_number":165,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store file"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_7d58db56","line":162,"in_reply_to":"7a016987_9dccb762","updated":"2015-05-27 12:34:54.000000000","message":"Thanks, this has been added in the latest patchset.","commit_id":"53c43cfeb95ae17d9eac7e8b61c297064072615b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4dd4cf41cf8f5a12a24894013c820559925bd05c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # Store configuration"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if ! isset GLANCE_STORE_DRIVER ; then"},{"line_number":143,"context_line":"        if is_service_enabled s-proxy; then"},{"line_number":144,"context_line":"            # Store the images in swift if enabled"},{"line_number":145,"context_line":"            GLANCE_STORE_DRIVER\u003dswift"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a016987_86f686f7","line":142,"updated":"2015-05-28 01:27:01.000000000","message":"This statements confuse me. It\u0027s better to describe like following implements for me.\n\nGLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-file}\nif is_service_enabled s-proxy; then\n            # Store the images in swift if enabled\n            echo \"WARNING: You don\u0027t set swift to GLANCE_STORE_DRIVER\"\n            GLANCE_STORE_DRIVER\u003dswift\nif","commit_id":"4f506eae686e0b1be80cfdcbb3dc14a3e87a4904"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"4b2caf1c92396e6dd528162c2d0a9687287e528c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # Store configuration"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if ! isset GLANCE_STORE_DRIVER ; then"},{"line_number":143,"context_line":"        if is_service_enabled s-proxy; then"},{"line_number":144,"context_line":"            # Store the images in swift if enabled"},{"line_number":145,"context_line":"            GLANCE_STORE_DRIVER\u003dswift"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a016987_9a636b1a","line":142,"in_reply_to":"7a016987_86f686f7","updated":"2015-05-28 13:33:26.000000000","message":"Note I only want the swift driver to be enabled if the driver has not been explicitly set otherwise.","commit_id":"4f506eae686e0b1be80cfdcbb3dc14a3e87a4904"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4dd4cf41cf8f5a12a24894013c820559925bd05c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        file|filesystem)"},{"line_number":164,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store file"},{"line_number":165,"context_line":"            ;;"},{"line_number":166,"context_line":"        *)"},{"line_number":167,"context_line":"            echo \"Unrecognized glance_store driver!\""},{"line_number":168,"context_line":"            exit 1"},{"line_number":169,"context_line":"            ;;"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a016987_fb7cb7b6","line":166,"updated":"2015-05-28 01:27:01.000000000","message":"Do you need \"*\" case because it seems the case doesn\u0027t happen in current code?","commit_id":"4f506eae686e0b1be80cfdcbb3dc14a3e87a4904"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"4b2caf1c92396e6dd528162c2d0a9687287e528c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        file|filesystem)"},{"line_number":164,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store file"},{"line_number":165,"context_line":"            ;;"},{"line_number":166,"context_line":"        *)"},{"line_number":167,"context_line":"            echo \"Unrecognized glance_store driver!\""},{"line_number":168,"context_line":"            exit 1"},{"line_number":169,"context_line":"            ;;"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a016987_fa201fb2","line":166,"in_reply_to":"7a016987_fb7cb7b6","updated":"2015-05-28 13:33:26.000000000","message":"This case will occur if an invalid driver name is set in GLANCE_STORE_DRIVER. You are correct it does not happen in the current code, but the point of this commit is to allow the driver to be arbitrarily changed.","commit_id":"4f506eae686e0b1be80cfdcbb3dc14a3e87a4904"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2a4c89923cc24f81c088a66a4143803c8990853d","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Choose which store driver to use. This defaults to filesystem, or swift if"},{"line_number":77,"context_line":"# swift-proxy is enabled"},{"line_number":78,"context_line":"GLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-filesystem}"},{"line_number":79,"context_line":"if is_service_enabled s-proxy; then"},{"line_number":80,"context_line":"    # Store the images in swift if swift is enabled"},{"line_number":81,"context_line":"    GLANCE_STORE_DRIVER\u003dswift"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a016987_9d9a426d","line":78,"updated":"2015-05-28 14:05:17.000000000","message":"Just question: Do you have the specific opinion about \"filesystem\" word? I prefer \"file\" over it. Is it better to use \"filesystem\" for glance folks rather than \"file\"?","commit_id":"75d3da7fd6856611e7a4761d0ecf659f522e5c12"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d591608efa4be7b2bcad30c51eee966f9aaff3f1","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Choose which store driver to use. This defaults to filesystem, or swift if"},{"line_number":77,"context_line":"# swift-proxy is enabled"},{"line_number":78,"context_line":"GLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-filesystem}"},{"line_number":79,"context_line":"if is_service_enabled s-proxy; then"},{"line_number":80,"context_line":"    # Store the images in swift if swift is enabled"},{"line_number":81,"context_line":"    GLANCE_STORE_DRIVER\u003dswift"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a016987_006ee52e","line":78,"in_reply_to":"7a016987_60859957","updated":"2015-05-28 14:25:02.000000000","message":"I got it.","commit_id":"75d3da7fd6856611e7a4761d0ecf659f522e5c12"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"1358c0a7e0c8e7ee08e0ced5984cdef6edbc3d64","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Choose which store driver to use. This defaults to filesystem, or swift if"},{"line_number":77,"context_line":"# swift-proxy is enabled"},{"line_number":78,"context_line":"GLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-filesystem}"},{"line_number":79,"context_line":"if is_service_enabled s-proxy; then"},{"line_number":80,"context_line":"    # Store the images in swift if swift is enabled"},{"line_number":81,"context_line":"    GLANCE_STORE_DRIVER\u003dswift"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a016987_60859957","line":78,"in_reply_to":"7a016987_9d9a426d","updated":"2015-05-28 14:14:33.000000000","message":"The driver is named \u0027filesystem\u0027 and the relevant glance configuration options are named filesystem_store_*, so I think we\u0027d prefer this over file.","commit_id":"75d3da7fd6856611e7a4761d0ecf659f522e5c12"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d1e800bc6a34014690527da3fac7b98b891e5805","unresolved":false,"context_lines":[{"line_number":73,"context_line":"GLANCE_SEARCH_PORT_INT\u003d${GLANCE_SEARCH_PORT_INT:-19393}"},{"line_number":74,"context_line":"GLANCE_SEARCH_HOSTPORT\u003d${GLANCE_SEARCH_HOSTPORT:-$GLANCE_SERVICE_HOST:$GLANCE_SEARCH_PORT}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Choose which store driver to use. This defaults to filesystem, or swift if"},{"line_number":77,"context_line":"# swift-proxy is enabled"},{"line_number":78,"context_line":"GLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-filesystem}"},{"line_number":79,"context_line":"if is_service_enabled s-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_a57b98bd","line":76,"updated":"2015-05-28 17:59:43.000000000","message":"For the documentation formatting, please put the possible values in doube backticks:\n\n  ... This defaults to ``filesystem``, or ``swift`` if","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"ee1461c2b066d298574bd566d62e2f24064b0a2f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"GLANCE_SEARCH_PORT_INT\u003d${GLANCE_SEARCH_PORT_INT:-19393}"},{"line_number":74,"context_line":"GLANCE_SEARCH_HOSTPORT\u003d${GLANCE_SEARCH_HOSTPORT:-$GLANCE_SERVICE_HOST:$GLANCE_SEARCH_PORT}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Choose which store driver to use. This defaults to filesystem, or swift if"},{"line_number":77,"context_line":"# swift-proxy is enabled"},{"line_number":78,"context_line":"GLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-filesystem}"},{"line_number":79,"context_line":"if is_service_enabled s-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_10a50ca1","line":76,"in_reply_to":"7a016987_a57b98bd","updated":"2015-05-28 18:12:58.000000000","message":"Thanks, I\u0027ll fix this.","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d1e800bc6a34014690527da3fac7b98b891e5805","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":159,"context_line":"            iniset $GLANCE_API_CONF glance_store stores \"file, http, swift\""},{"line_number":160,"context_line":"            ;;"},{"line_number":161,"context_line":"        file|filesystem)"},{"line_number":162,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store file"},{"line_number":163,"context_line":"            ;;"},{"line_number":164,"context_line":"        *)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_45418462","line":161,"updated":"2015-05-28 17:59:43.000000000","message":"Why include file here?","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"ee1461c2b066d298574bd566d62e2f24064b0a2f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":159,"context_line":"            iniset $GLANCE_API_CONF glance_store stores \"file, http, swift\""},{"line_number":160,"context_line":"            ;;"},{"line_number":161,"context_line":"        file|filesystem)"},{"line_number":162,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store file"},{"line_number":163,"context_line":"            ;;"},{"line_number":164,"context_line":"        *)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_309b6868","line":161,"in_reply_to":"7a016987_45418462","updated":"2015-05-28 18:12:58.000000000","message":"No good reason. I\u0027ll remove it.","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d1e800bc6a34014690527da3fac7b98b891e5805","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            ;;"},{"line_number":168,"context_line":"    esac"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":173,"context_line":"        iniset $GLANCE_API_CONF DEFAULT bind_port $GLANCE_SERVICE_PORT_INT"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_e58750b3","line":170,"updated":"2015-05-28 17:59:43.000000000","message":"This has nothing to do with the store configuration","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"098a35ef43147006605780e14698e973513a92da","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            ;;"},{"line_number":168,"context_line":"    esac"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":173,"context_line":"        iniset $GLANCE_API_CONF DEFAULT bind_port $GLANCE_SERVICE_PORT_INT"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_b04878b4","line":170,"in_reply_to":"7a016987_5096e43e","updated":"2015-05-28 18:16:14.000000000","message":"OK, I missed the move, thought it slipped in as an add.","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"ee1461c2b066d298574bd566d62e2f24064b0a2f","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            ;;"},{"line_number":168,"context_line":"    esac"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":173,"context_line":"        iniset $GLANCE_API_CONF DEFAULT bind_port $GLANCE_SERVICE_PORT_INT"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a016987_5096e43e","line":170,"in_reply_to":"7a016987_e58750b3","updated":"2015-05-28 18:12:58.000000000","message":"This has just been moved from line 143 of the base file. I can move it back if you\u0027d prefer, but this keeps the store configuration grouped together.","commit_id":"56098510d4c44c5bf28d09e8c51e8c92d22ee698"}]}