)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"f44491b1c3aeb4f349fba81be79d6f5225a1c7a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add verification for PUBLIC_BRIDGE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PUBLIC_BRIDGE is not always be set, so the call to sysctl in lib/neutron-legacy"},{"line_number":10,"context_line":"which refter to PUBLIC_BRIDGE, should be wrapped."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4c7617f6a245ea4e2e08f518d873b1b8adc2b807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_80ed4027","line":9,"updated":"2015-05-18 10:19:10.000000000","message":"s/is not always be set/is not always defined/","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"2ae564921d0932399e4805a36267a3a8488edf21","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add verification for PUBLIC_BRIDGE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PUBLIC_BRIDGE is not always be set, so the call to sysctl in lib/neutron-legacy"},{"line_number":10,"context_line":"which refter to PUBLIC_BRIDGE, should be wrapped."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4c7617f6a245ea4e2e08f518d873b1b8adc2b807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_d60bf428","line":9,"in_reply_to":"7a016987_80ed4027","updated":"2015-05-19 01:29:29.000000000","message":"Thanks Kashyap! Done.","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"f44491b1c3aeb4f349fba81be79d6f5225a1c7a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add verification for PUBLIC_BRIDGE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PUBLIC_BRIDGE is not always be set, so the call to sysctl in lib/neutron-legacy"},{"line_number":10,"context_line":"which refter to PUBLIC_BRIDGE, should be wrapped."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4c7617f6a245ea4e2e08f518d873b1b8adc2b807"},{"line_number":13,"context_line":"Closes-Bug: #1454475"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_60424412","line":10,"updated":"2015-05-18 10:19:10.000000000","message":"s/which refter to PUBLIC_BRIDGE,/which refers to PUBLIC_BRIDGE/","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"2ae564921d0932399e4805a36267a3a8488edf21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add verification for PUBLIC_BRIDGE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PUBLIC_BRIDGE is not always be set, so the call to sysctl in lib/neutron-legacy"},{"line_number":10,"context_line":"which refter to PUBLIC_BRIDGE, should be wrapped."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4c7617f6a245ea4e2e08f518d873b1b8adc2b807"},{"line_number":13,"context_line":"Closes-Bug: #1454475"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_b604f817","line":10,"in_reply_to":"7a016987_60424412","updated":"2015-05-19 01:29:29.000000000","message":"Done.","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e0b68cdb10ba5c43f4223618093d8e61d62c6401","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yalei Wang \u003cyalei.wang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-25 12:59:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the error from undefined PUBLIC_BRIDGE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As unstack.sh does destroy all bridges, we don\u0027t have to refresh bridge"},{"line_number":10,"context_line":"interface any more, as what is done in commit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_8353716c","line":7,"updated":"2015-05-26 02:36:00.000000000","message":"I think it\u0027s not proper tile for this patch.\n\ne.g. Remove the code against flushing public bridge","commit_id":"bd1235a0c9a4da2d0163e2a03ffe7f317000a4c3"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"feb6d08ce5459a139706461abb296861ca9b75cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yalei Wang \u003cyalei.wang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-25 12:59:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the error from undefined PUBLIC_BRIDGE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As unstack.sh does destroy all bridges, we don\u0027t have to refresh bridge"},{"line_number":10,"context_line":"interface any more, as what is done in commit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_889fac02","line":7,"in_reply_to":"7a016987_8353716c","updated":"2015-05-28 08:23:32.000000000","message":"Done","commit_id":"bd1235a0c9a4da2d0163e2a03ffe7f317000a4c3"}],"lib/neutron-legacy":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9ba6e6dbb429cc68ffd736865682d16c77ed80c0","unresolved":false,"context_lines":[{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"        # The ovs_base_configure_l3_agent function flushes the public"},{"line_number":1296,"context_line":"        # bridge\u0027s ip addresses, so turn IPv6 support in the host off"},{"line_number":1297,"context_line":"        # and then on to recover the public bridge\u0027s link local address"},{"line_number":1298,"context_line":"        if [ -n \"$PUBLIC_BRIDGE\" ]; then"},{"line_number":1299,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d1"},{"line_number":1300,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a0c5dc1_b7ff9d00","line":1297,"updated":"2015-05-13 06:53:58.000000000","message":"is this block still necessary after commit c2dc95add6e46829f1705041c1d9dddab9b360d3 ?","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67e66b763c957b2b86c181e768d4164f72cce932","unresolved":false,"context_lines":[{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"        # The ovs_base_configure_l3_agent function flushes the public"},{"line_number":1296,"context_line":"        # bridge\u0027s ip addresses, so turn IPv6 support in the host off"},{"line_number":1297,"context_line":"        # and then on to recover the public bridge\u0027s link local address"},{"line_number":1298,"context_line":"        if [ -n \"$PUBLIC_BRIDGE\" ]; then"},{"line_number":1299,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d1"},{"line_number":1300,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_79da8118","line":1297,"in_reply_to":"7a016987_b6e3d8a3","updated":"2015-05-24 23:37:50.000000000","message":"i meant L1295-1306 can be just removed.  how do you think?\nat least, the commt (L1295-1297) needs an update.","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"2ae564921d0932399e4805a36267a3a8488edf21","unresolved":false,"context_lines":[{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"        # The ovs_base_configure_l3_agent function flushes the public"},{"line_number":1296,"context_line":"        # bridge\u0027s ip addresses, so turn IPv6 support in the host off"},{"line_number":1297,"context_line":"        # and then on to recover the public bridge\u0027s link local address"},{"line_number":1298,"context_line":"        if [ -n \"$PUBLIC_BRIDGE\" ]; then"},{"line_number":1299,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d1"},{"line_number":1300,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_b6e3d8a3","line":1297,"in_reply_to":"9a0c5dc1_b7ff9d00","updated":"2015-05-19 01:29:29.000000000","message":"yes, this is another call position refer to PUBLIC_BRIDGE, I think that commit will not Influence this one","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0c4d734a3324ef3a450c77b076f995a2363c0daf","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"        # The ovs_base_configure_l3_agent function flushes the public"},{"line_number":1296,"context_line":"        # bridge\u0027s ip addresses, so turn IPv6 support in the host off"},{"line_number":1297,"context_line":"        # and then on to recover the public bridge\u0027s link local address"},{"line_number":1298,"context_line":"        if [ -n \"$PUBLIC_BRIDGE\" ]; then"},{"line_number":1299,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d1"},{"line_number":1300,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d0"},{"line_number":1301,"context_line":"            if ! ip -6 addr show dev $PUBLIC_BRIDGE | grep \u0027scope global\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_6316d156","line":1298,"updated":"2015-05-18 09:22:18.000000000","message":"Also note that PUBLIC_BRIDGE is for ovs, so even if it would be necessary (which Yamamoto pointed correctly out it is not), we may move the block to ovs specific settings.","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8a35470407fa816452e371d27afeff40a466714d","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"        # The ovs_base_configure_l3_agent function flushes the public"},{"line_number":1296,"context_line":"        # bridge\u0027s ip addresses, so turn IPv6 support in the host off"},{"line_number":1297,"context_line":"        # and then on to recover the public bridge\u0027s link local address"},{"line_number":1298,"context_line":"        if [ -n \"$PUBLIC_BRIDGE\" ]; then"},{"line_number":1299,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d1"},{"line_number":1300,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d0"},{"line_number":1301,"context_line":"            if ! ip -6 addr show dev $PUBLIC_BRIDGE | grep \u0027scope global\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_0bea7ddb","line":1298,"in_reply_to":"7a016987_36100859","updated":"2015-05-19 09:53:16.000000000","message":"I meant we need to make sure the block is needed. According the commit Yamamoto posted it seems this block can be removed. In case it is still needed, I\u0027d put it either to openvswitch_agent or under block \u0027if is_neutron_ovs_base_plugin\u0027.","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"2ae564921d0932399e4805a36267a3a8488edf21","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"        # The ovs_base_configure_l3_agent function flushes the public"},{"line_number":1296,"context_line":"        # bridge\u0027s ip addresses, so turn IPv6 support in the host off"},{"line_number":1297,"context_line":"        # and then on to recover the public bridge\u0027s link local address"},{"line_number":1298,"context_line":"        if [ -n \"$PUBLIC_BRIDGE\" ]; then"},{"line_number":1299,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d1"},{"line_number":1300,"context_line":"            sudo sysctl -w net.ipv6.conf.${PUBLIC_BRIDGE}.disable_ipv6\u003d0"},{"line_number":1301,"context_line":"            if ! ip -6 addr show dev $PUBLIC_BRIDGE | grep \u0027scope global\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_36100859","line":1298,"in_reply_to":"7a016987_6316d156","updated":"2015-05-19 01:29:29.000000000","message":"Thanks Jakub, do you mean move it to lib/neutron_plugins/ovs_base or neutron_plugins/openvswitch_agent?\nI don\u0027t find a proper position.\n\npersonally I thought PUBLIC_BRIDGE here is enough if PUBLIC_BRIDGE is just for ovs, and the code block just refer to PUBLIC_BRIDG.","commit_id":"19453f60398d2c6b88231a227537c9fcdbf9a185"}]}