)]}'
{"lib/ironic":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"52879a9b45563d1c98e99acfdc7d76a6b8222314","unresolved":false,"context_lines":[{"line_number":237,"context_line":"dhcp-userclass\u003dset:ipxe,iPXE"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"# Alternatively, create the \"ipxe\" tag if request comes from DHCP option 175"},{"line_number":240,"context_line":"# dhcp-match\u003dset:ipxe,175"},{"line_number":241,"context_line":"EOF"},{"line_number":242,"context_line":"}"},{"line_number":243,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_679e1658","line":240,"updated":"2015-05-15 04:29:09.000000000","message":"why is this here if it\u0027s commented out?","commit_id":"ec4b0536bbddb17035c1ee595c5d18115f950a93"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87b2b6fa04424249d348ade4edf172e858359017","unresolved":false,"context_lines":[{"line_number":237,"context_line":"dhcp-userclass\u003dset:ipxe,iPXE"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"# Alternatively, create the \"ipxe\" tag if request comes from DHCP option 175"},{"line_number":240,"context_line":"# dhcp-match\u003dset:ipxe,175"},{"line_number":241,"context_line":"EOF"},{"line_number":242,"context_line":"}"},{"line_number":243,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_756ebdca","line":240,"in_reply_to":"7a016987_679e1658","updated":"2015-05-15 08:29:34.000000000","message":"It\u0027s to show the user that the \"ipxe\" tag can be created in two ways. One by matching the user class (the uncommented line) or by matching the DHCP option 175.\n\nI thought it would be good to leave it commented for the sake of showing it (like a sample config file). But if you think it\u0027s not important I can remove of course.","commit_id":"ec4b0536bbddb17035c1ee595c5d18115f950a93"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"56b876daa95834ff68d03684e23a77da3500fdb5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IRONIC_HTTP_DIR\u003d${IRONIC_HTTP_DIR:-$IRONIC_DATA_DIR/httpboot}"},{"line_number":123,"context_line":"IRONIC_HTTP_SERVER\u003d${IRONIC_HTTP_SERVER:-$HOST_IP}"},{"line_number":124,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8088}"},{"line_number":125,"context_line":"IRONIC_DNSMASQ_CONFIG\u003d${IRONIC_DNSMASQ_CONFIG:-$IRONIC_DATA_DIR/dnsmasq-ironic.conf}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# NOTE(lucasagomes): This flag is used to differentiate the nodes that"},{"line_number":128,"context_line":"# uses IPA as their deploy ramdisk from nodes that uses the agent_* drivers"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa32b979_2b13d467","line":125,"updated":"2015-06-16 18:10:55.000000000","message":"Why can this be overridden? I understand making it a variable so it can be referenced in 2 places, but I don\u0027t understand why it\u0027s customizable.","commit_id":"93f6c3b2d0472aa1c4a3331f80d42e13c7cf32d8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d968a359a5d9ee6f0a66528a8563b4ec944af6eb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IRONIC_HTTP_DIR\u003d${IRONIC_HTTP_DIR:-$IRONIC_DATA_DIR/httpboot}"},{"line_number":123,"context_line":"IRONIC_HTTP_SERVER\u003d${IRONIC_HTTP_SERVER:-$HOST_IP}"},{"line_number":124,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8088}"},{"line_number":125,"context_line":"IRONIC_DNSMASQ_CONFIG\u003d${IRONIC_DNSMASQ_CONFIG:-$IRONIC_DATA_DIR/dnsmasq-ironic.conf}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# NOTE(lucasagomes): This flag is used to differentiate the nodes that"},{"line_number":128,"context_line":"# uses IPA as their deploy ramdisk from nodes that uses the agent_* drivers"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa32b979_545010d4","line":125,"in_reply_to":"fa32b979_2b13d467","updated":"2015-06-17 13:52:19.000000000","message":"Right, yeah making it customizable has little/no value. I will update the patch.\n\nThanks","commit_id":"93f6c3b2d0472aa1c4a3331f80d42e13c7cf32d8"}]}