)]}'
{"inc/rootwrap":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"667fca0ad1249a2061a91eb2561e152a2ec1101d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Make a load of assumptions otherwise we\u0027ll have 6 arguments"},{"line_number":41,"context_line":"# configure_rootwrap project"},{"line_number":42,"context_line":"function configure_rootwrap {"},{"line_number":43,"context_line":"    local project\u003d$1                    # xx"},{"line_number":44,"context_line":"    local project_uc\u003d$(echo $1|tr a-z A-Z)"},{"line_number":45,"context_line":"    local bin_dir\u003d\"${project_uc}_BIN_DIR\""},{"line_number":46,"context_line":"    bin_dir\u003d\"${!bin_dir}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_10ffc902","line":43,"range":{"start_line":43,"start_character":42,"end_line":43,"end_character":44},"updated":"2015-05-14 06:21:18.000000000","message":"this \"xx\" comment is now useless.","commit_id":"c2f0824814a53ed4c9732ba9eddd9a5644665e6b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1fa252a447c9a00a2912510e97b3a0fb8e9d947b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Make a load of assumptions otherwise we\u0027ll have 6 arguments"},{"line_number":41,"context_line":"# configure_rootwrap project"},{"line_number":42,"context_line":"function configure_rootwrap {"},{"line_number":43,"context_line":"    local project\u003d$1                    # xx"},{"line_number":44,"context_line":"    local project_uc\u003d$(echo $1|tr a-z A-Z)"},{"line_number":45,"context_line":"    local bin_dir\u003d\"${project_uc}_BIN_DIR\""},{"line_number":46,"context_line":"    bin_dir\u003d\"${!bin_dir}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_a779ae95","line":43,"in_reply_to":"7a016987_10ffc902","updated":"2015-05-15 04:00:26.000000000","message":"Done","commit_id":"c2f0824814a53ed4c9732ba9eddd9a5644665e6b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"667fca0ad1249a2061a91eb2561e152a2ec1101d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    local bin_dir\u003d\"${project_uc}_BIN_DIR\""},{"line_number":46,"context_line":"    bin_dir\u003d\"${!bin_dir}\""},{"line_number":47,"context_line":"    local project_dir\u003d\"${project_uc}_DIR\""},{"line_number":48,"context_line":"    project_dir\u003d\"${!project_dir}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    local rootwrap_conf_src_dir\u003d\"${project_dir}/etc/${project}\""},{"line_number":51,"context_line":"    local rootwrap_bin\u003d\"${bin_dir}/${project}-rootwrap\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_8d5e0244","line":48,"updated":"2015-05-14 06:21:18.000000000","message":"better to avoid reusing the variables.\ni.e.\n  local bin_dir_var\u003d...\n  local bin_dir \u003d\"${!bin_dir_var}\"","commit_id":"c2f0824814a53ed4c9732ba9eddd9a5644665e6b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7d5b6add29a4e4a85b180bcf8bc9e59065bbc9bb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    local bin_dir\u003d\"${project_uc}_BIN_DIR\""},{"line_number":46,"context_line":"    bin_dir\u003d\"${!bin_dir}\""},{"line_number":47,"context_line":"    local project_dir\u003d\"${project_uc}_DIR\""},{"line_number":48,"context_line":"    project_dir\u003d\"${!project_dir}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    local rootwrap_conf_src_dir\u003d\"${project_dir}/etc/${project}\""},{"line_number":51,"context_line":"    local rootwrap_bin\u003d\"${bin_dir}/${project}-rootwrap\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_27cc9e88","line":48,"in_reply_to":"7a016987_6773b6b2","updated":"2015-05-15 04:23:01.000000000","message":"my concern was code readability.  but i don\u0027t insist.","commit_id":"c2f0824814a53ed4c9732ba9eddd9a5644665e6b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1fa252a447c9a00a2912510e97b3a0fb8e9d947b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    local bin_dir\u003d\"${project_uc}_BIN_DIR\""},{"line_number":46,"context_line":"    bin_dir\u003d\"${!bin_dir}\""},{"line_number":47,"context_line":"    local project_dir\u003d\"${project_uc}_DIR\""},{"line_number":48,"context_line":"    project_dir\u003d\"${!project_dir}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    local rootwrap_conf_src_dir\u003d\"${project_dir}/etc/${project}\""},{"line_number":51,"context_line":"    local rootwrap_bin\u003d\"${bin_dir}/${project}-rootwrap\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a016987_6773b6b2","line":48,"in_reply_to":"7a016987_8d5e0244","updated":"2015-05-15 04:00:26.000000000","message":"i don\u0027t see this makes any difference, and it\u0027s how we do it for the policyd stuff\n\nhowever, if this is going to happen a lot, maybe a fn to expand this in-place would be good","commit_id":"c2f0824814a53ed4c9732ba9eddd9a5644665e6b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d3c6db68bd91854039b6134f6fd25c5ac5f1a600","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    local project_dir\u003d\"${project_uc}_DIR\""},{"line_number":48,"context_line":"    project_dir\u003d\"${!project_dir}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    local rootwrap_conf_src_dir\u003d\"${project_dir}/etc/${project}\""},{"line_number":51,"context_line":"    local rootwrap_bin\u003d\"${bin_dir}/${project}-rootwrap\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Start fresh with rootwrap filters"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a016987_ad5493fe","line":50,"updated":"2015-05-19 18:18:26.000000000","message":"This reminds me to update and commit the CONF_DIR patch...","commit_id":"c6782413081cbdc72c7b24e34acec383a1cf2f46"}]}