)]}'
{"id":"openstack%2Fdevstack~183154","triplet_id":"openstack%2Fdevstack~master~Ia0288d349b21e27fbf6370c7939e6ac1af0ebe17","project":"openstack/devstack","branch":"master","topic":"fix_stop_service","hashtags":[],"change_id":"Ia0288d349b21e27fbf6370c7939e6ac1af0ebe17","subject":"ensure that the service is killed on unstack","status":"ABANDONED","created":"2015-05-14 18:28:40.000000000","updated":"2016-03-22 12:42:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"362d6a7d5a4d050b33e5cabeddb1300e302c22a5","_number":183154,"virtual_id_number":183154,"owner":{"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-05-15 05:07:30.000000000","_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},{"value":-1,"date":"2015-07-02 20:18:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"date":"2015-05-20 23:15:39.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},{"date":"2016-03-22 12:42:18.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":-1,"date":"2015-05-15 04:23:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-05-15 03:40:14.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2015-05-15 06:34:41.000000000","_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"date":"2015-05-15 03:40:44.000000000","_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},{"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-15 03:40:14.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2015-05-15 03:40:44.000000000","updated_by":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"reviewer":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"state":"REVIEWER"},{"updated":"2015-05-15 04:23:59.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-05-15 06:34:41.000000000","updated_by":{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},"reviewer":{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},"state":"REVIEWER"},{"updated":"2015-05-20 23:15:39.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-07-02 20:18:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-22 12:42:18.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"ee8f1bd8086a0eaf9d3eb3b9fab6f847c10dd3a2","author":{"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},"date":"2015-05-14 18:28:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d9d645e181e30ff605c52b405f8dde5081169b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-14 19:24:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/54/183154/1/check/check-tempest-dsvm-full/4d44e90/ : SUCCESS in 44m 09s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/54/183154/1/check/check-tempest-dsvm-postgres-full/85daa38/ : SUCCESS in 34m 21s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/54/183154/1/check/check-tempest-dsvm-neutron-full/9c9566d/ : SUCCESS in 53m 20s\n- check-grenade-dsvm http://logs.openstack.org/54/183154/1/check/check-grenade-dsvm/2e4fc50/ : SUCCESS in 40m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/54/183154/1/check/gate-tempest-dsvm-large-ops/a0f6d7b/ : SUCCESS in 21m 24s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/54/183154/1/check/gate-tempest-dsvm-neutron-large-ops/ffe0e35/ : SUCCESS in 45m 49s\n- gate-devstack-bashate http://logs.openstack.org/54/183154/1/check/gate-devstack-bashate/58e9dac/ : SUCCESS in 20s\n- gate-devstack-unit-tests http://logs.openstack.org/54/183154/1/check/gate-devstack-unit-tests/0bb7640/ : SUCCESS in 13s\n- check-devstack-dsvm-cells http://logs.openstack.org/54/183154/1/check/check-devstack-dsvm-cells/c0e227e/ : SUCCESS in 22m 01s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/54/183154/1/check/check-grenade-dsvm-partial-ncpu/40be6a1/ : SUCCESS in 40m 05s\n- check-swift-dsvm-functional http://logs.openstack.org/54/183154/1/check/check-swift-dsvm-functional/1f1e64e/ : SUCCESS in 19m 14s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/54/183154/1/check/check-tempest-dsvm-ironic-pxe_ssh/7934755/ : SUCCESS in 32m 00s\n- check-devstack-dsvm-updown http://logs.openstack.org/54/183154/1/check/check-devstack-dsvm-updown/5aee4a0/ : SUCCESS in 22m 18s\n- check-tempest-dsvm-f21 http://logs.openstack.org/54/183154/1/check/check-tempest-dsvm-f21/b90e3c5/ : FAILURE in 41m 37s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/54/183154/1/check/check-tempest-dsvm-centos7/956627f/ : SUCCESS in 36m 14s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/54/183154/1/check/gate-devstack-publish-docs/1b82fd6//doc/build/html/ : SUCCESS in 1m 39s\n- check-grenade-dsvm-neutron http://logs.openstack.org/54/183154/1/check/check-grenade-dsvm-neutron/b040b98/ : SUCCESS in 45m 25s","accounts_in_message":[],"_revision_number":1},{"id":"5683166094bdecc300d3140b8b17e7c6e9b1caa6","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-15 04:23:59.000000000","message":"Patch Set 1: Code-Review-1\n\nif we\u0027re running under setsid this isn\u0027t going to go anywhere.  what\u0027s the real issue, is stop_process not finding the right pid or something?","accounts_in_message":[],"_revision_number":1},{"id":"6e326acf61995cc594b0269931d0d1a235f2ad0f","author":{"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},"date":"2015-05-15 05:07:30.000000000","message":"Patch Set 1:\n\nActually on running ./unstack.sh and then ./rejoin.sh again. \nPID\u0027s don\u0027t show up in the /opt/stack/status/stack/\n\nNow, on doing ./unstack.sh again,it defaults to just killing the screen window. \nThen init becomes the new parent for glance-api and glance-reg process, while occupying the resource(port).","accounts_in_message":[],"_revision_number":1},{"id":"55e20c39546da0f1a73d945356ee440074fa4fae","author":{"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},"date":"2015-05-15 05:30:54.000000000","message":"Patch Set 1:\n\nI have patched screen_stop_process function which will only run when the screen is being used. Let me know if i am wrong on my assumption.","accounts_in_message":[],"_revision_number":1},{"id":"91b3f5de027e81567c74e051de0f4a422f74ada9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-20 23:15:39.000000000","message":"Patch Set 1:\n\nPart of your problem is in assuming that rejoin actually works.  as you see, it often doesn\u0027t.  This really is not something that is a high priority as that script does not always start processes properly.  I am not interested in changing the process functions to accommodate this without a lot of testing to ensure that the rest of this insanely fragile setup doesn\u0027t break.","accounts_in_message":[],"_revision_number":1},{"id":"d865007cdabbdb70c8af5764a95af9d5a806c797","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-02 20:18:22.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"7df04ed1def2e821e3965d5533bd77f756ae8cdf","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-03-22 12:42:18.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"639a7bcd34d13020a43c53ebd64f8570dcfb5446","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-03-22 12:42:18.000000000","message":"Patch Set 1:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bb909dfe4f7a6afe722b90a046209a20231e3a85","revisions":{"bb909dfe4f7a6afe722b90a046209a20231e3a85":{"kind":"REWORK","_number":1,"created":"2015-05-14 18:28:40.000000000","uploader":{"_account_id":14081,"name":"Harkirat Singh","email":"reachharkirat@gmail.com","username":"reachharkirat"},"ref":"refs/changes/54/183154/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/54/183154/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/54/183154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/54/183154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/54/183154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/54/183154/1"}}},"commit":{"parents":[{"commit":"bf5de0aee48cd756fcc8e792f2014054c5f5294a","subject":"Merge \"Prevent setting tempest fixed_network_name for cells\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bf5de0aee48cd756fcc8e792f2014054c5f5294a"}]}],"author":{"name":"Harkirat Singh","email":"reachharkirat@gmail.com","date":"2015-05-14 18:25:29.000000000","tz":330},"committer":{"name":"Harkirat Singh","email":"reachharkirat@gmail.com","date":"2015-05-14 18:28:36.000000000","tz":330},"subject":"ensure that the service is killed on unstack","message":"ensure that the service is killed on unstack\n\nChange-Id: Ia0288d349b21e27fbf6370c7939e6ac1af0ebe17\nCloses-Bug: #1454948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bb909dfe4f7a6afe722b90a046209a20231e3a85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bb909dfe4f7a6afe722b90a046209a20231e3a85"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}