)]}'
{"id":"openstack%2Fdevstack~185292","triplet_id":"openstack%2Fdevstack~master~Ib317ad1e9dd2a5d2232b9c64541fe4a601a2b8da","project":"openstack/devstack","branch":"master","topic":"bug/1457989","hashtags":[],"change_id":"Ib317ad1e9dd2a5d2232b9c64541fe4a601a2b8da","subject":"Fix msg argument to assert_equal","status":"MERGED","created":"2015-05-25 01:54:46.000000000","updated":"2015-05-27 15:43:23.000000000","submitted":"2015-05-27 15:43:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2bf3415a3a017ab36e4b0a1f1941ff05dc2724f2","_number":185292,"virtual_id_number":185292,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":2,"date":"2015-05-27 15:43:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"recommended":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"all":[{"value":1,"date":"2015-05-25 22:44:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-05-26 11:38:41.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2015-05-25 02:33:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":1,"date":"2015-05-25 22:47:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":2,"date":"2015-05-27 14:49:35.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":1,"date":"2015-05-27 14:49:35.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-25 02:33:10.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-05-25 22:44:54.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2015-05-25 22:47:56.000000000","updated_by":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"reviewer":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"state":"REVIEWER"},{"updated":"2015-05-26 11:38:41.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2015-05-27 14:49:35.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-05-27 15:43:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0d54cd91245f2219f5e8e7f5b14560d2883dc15d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-25 01:54:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e801680775423a1457d6b6a34d93abee28f5590","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-05-25 02:33:10.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8f981ab1f602713fb93ee0ded771fa81e38ad8b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-25 02:49:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/92/185292/1/check/check-tempest-dsvm-full/8045f49/ : SUCCESS in 37m 05s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/92/185292/1/check/check-tempest-dsvm-postgres-full/7b1352c/ : SUCCESS in 46m 15s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/92/185292/1/check/check-tempest-dsvm-neutron-full/dac750e/ : SUCCESS in 54m 58s\n- check-grenade-dsvm http://logs.openstack.org/92/185292/1/check/check-grenade-dsvm/3baac15/ : SUCCESS in 39m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/92/185292/1/check/gate-tempest-dsvm-large-ops/a3248d2/ : SUCCESS in 19m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/92/185292/1/check/gate-tempest-dsvm-neutron-large-ops/1c57981/ : SUCCESS in 25m 35s\n- gate-devstack-bashate http://logs.openstack.org/92/185292/1/check/gate-devstack-bashate/ef6cfa2/ : SUCCESS in 10s\n- gate-devstack-unit-tests http://logs.openstack.org/92/185292/1/check/gate-devstack-unit-tests/c71de82/ : SUCCESS in 17s\n- check-devstack-dsvm-cells http://logs.openstack.org/92/185292/1/check/check-devstack-dsvm-cells/ebcce84/ : SUCCESS in 19m 28s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/92/185292/1/check/check-grenade-dsvm-partial-ncpu/b376724/ : SUCCESS in 37m 19s\n- check-swift-dsvm-functional http://logs.openstack.org/92/185292/1/check/check-swift-dsvm-functional/f61b191/ : SUCCESS in 16m 32s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/92/185292/1/check/check-tempest-dsvm-ironic-pxe_ssh/cca02b5/ : SUCCESS in 27m 51s\n- check-devstack-dsvm-updown http://logs.openstack.org/92/185292/1/check/check-devstack-dsvm-updown/97e8f33/ : SUCCESS in 20m 24s\n- check-tempest-dsvm-f21 http://logs.openstack.org/92/185292/1/check/check-tempest-dsvm-f21/c1f5b8c/ : FAILURE in 43m 15s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/92/185292/1/check/check-tempest-dsvm-centos7/81bb2d9/ : FAILURE in 41m 26s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/92/185292/1/check/gate-devstack-publish-docs/8757a26//doc/build/html/ : SUCCESS in 1m 07s\n- check-grenade-dsvm-neutron http://logs.openstack.org/92/185292/1/check/check-grenade-dsvm-neutron/20283e6/ : SUCCESS in 35m 34s","accounts_in_message":[],"_revision_number":1},{"id":"c8c1b6db4bb341f97ae63bf799ffe6fe5dcbc2e9","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-05-25 22:44:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"765743cb400f921483aa7f405195ec826e469539","author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"date":"2015-05-25 22:47:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"499693746559ce16c53d98d1abb036aaed985dbe","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2015-05-26 11:38:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2f6ab1d388f5d5b2d5558c3b9ea3cf42ce69329a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-27 14:49:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThanks for improving these!","accounts_in_message":[],"_revision_number":1},{"id":"8622c13a63b18fa1a5b1b1585ed87d74078a0e3b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-27 14:49:41.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ce6c4aea45cd35456e367aa3dbfe650ecdad780c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-27 15:43:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/92/185292/1/gate/gate-tempest-dsvm-full/7218b9f/ : SUCCESS in 45m 47s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/92/185292/1/gate/gate-tempest-dsvm-postgres-full/d476ae3/ : SUCCESS in 47m 11s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/92/185292/1/gate/gate-tempest-dsvm-neutron-full/d5fcd7a/ : SUCCESS in 52m 50s\n- gate-grenade-dsvm http://logs.openstack.org/92/185292/1/gate/gate-grenade-dsvm/7d10d53/ : SUCCESS in 38m 28s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/92/185292/1/gate/gate-tempest-dsvm-large-ops/3ca2753/ : SUCCESS in 27m 01s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/92/185292/1/gate/gate-tempest-dsvm-neutron-large-ops/9e80f4b/ : SUCCESS in 24m 42s\n- gate-devstack-bashate http://logs.openstack.org/92/185292/1/gate/gate-devstack-bashate/00e3093/ : SUCCESS in 17s\n- gate-devstack-dsvm-cells http://logs.openstack.org/92/185292/1/gate/gate-devstack-dsvm-cells/e6e0b70/ : SUCCESS in 18m 50s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/92/185292/1/gate/gate-grenade-dsvm-partial-ncpu/703058a/ : SUCCESS in 43m 16s\n- gate-swift-dsvm-functional http://logs.openstack.org/92/185292/1/gate/gate-swift-dsvm-functional/1743b5e/ : SUCCESS in 18m 55s","accounts_in_message":[],"_revision_number":1},{"id":"1a4f60778a250bed214adbfac2049fb793894826","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-27 15:43:23.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"165afa2377ee8eb6bad1b6cfb454a7de525a4498","revisions":{"165afa2377ee8eb6bad1b6cfb454a7de525a4498":{"kind":"REWORK","_number":1,"created":"2015-05-25 01:54:46.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/92/185292/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/92/185292/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/92/185292/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/92/185292/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/92/185292/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/92/185292/1"}}},"commit":{"parents":[{"commit":"cf56d4e35ca3f5fd406068e757c9e82a7e2c6d61","subject":"Merge \"Remove KEYSTONE_AUTH_CACHE_DIR\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cf56d4e35ca3f5fd406068e757c9e82a7e2c6d61"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-05-25 01:29:48.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-05-25 01:29:48.000000000","tz":600},"subject":"Fix msg argument to assert_equal","message":"Fix msg argument to assert_equal\n\nI noticed this was taking an argument but not dealing with it.  In\ngeneral the functions were undocumented, so I added some terse usage.\n\nAlso, the intent of the test-case was to expand the values before\nusing them as the message; make sure this happens by using a temp\nvariable.\n\nChange-Id: Ib317ad1e9dd2a5d2232b9c64541fe4a601a2b8da\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/165afa2377ee8eb6bad1b6cfb454a7de525a4498"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/165afa2377ee8eb6bad1b6cfb454a7de525a4498"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
