)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de488ea66752a12348c65867dc78fbb022620351","unresolved":false,"context_lines":[{"line_number":11,"context_line":"stops handling messages, sql server stops answering, etc. There really"},{"line_number":12,"context_line":"should be an error to let the user know what he\u0027s doing wrong here."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2GB is used as an arbitrary lower limit."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_144e9696","line":14,"updated":"2015-05-26 08:27:23.000000000","message":"I wouldn\u0027t be afraid to use more storage. Storage is cheap these days.\n\nIs the value taken from any documentation or minimal requirements? Otherwise I would increase it to at least 10GB.","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"bfaf535e7045213ea1cba3e6ed7260c788a8ba14","unresolved":false,"context_lines":[{"line_number":11,"context_line":"stops handling messages, sql server stops answering, etc. There really"},{"line_number":12,"context_line":"should be an error to let the user know what he\u0027s doing wrong here."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2GB is used as an arbitrary lower limit."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_d5545122","line":14,"in_reply_to":"7a016987_144e9696","updated":"2015-05-27 07:45:43.000000000","message":"I somehow feel that 10GB is too much. For a fresh machine 10GB is reasonable to expect, but through time this can be diminished to much lower (for example, 2GB) and still work. I\u0027m all about finding some \"soft limit\" as to where openstack stops working, and 2GB seems reasonable.\n\nAlso, I don\u0027t want this error to pop up all the time just so people can ignore it. Say I have a new machine with 15GB of free space. Over time, this lowers to 10GB and the error pops. Since everything is working, the user will ignore the error again and again. Sometime later, around the 1GB mark, he\u0027ll get into problems, but the warning message will be ignored and this patch will have defeat its purpose.","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"}],"stack.sh":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9950869659e04b78cf88b77ec56d447b15885b2d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    exit 1"},{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"for fs in \"/\" \"/var\" \"/opt\"; do"},{"line_number":101,"context_line":"    if [ $(df -k $fs | tail -n 1 | awk \u0027{ print $4 }\u0027) -lt 2097152 ]; then"},{"line_number":102,"context_line":"        echo \"You don\u0027t have enough free space on $fs.\""},{"line_number":103,"context_line":"        echo \"You need at least 2GB of free space.\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_107349b6","line":100,"updated":"2015-05-26 00:17:26.000000000","message":"I understand the directory structure is default for devstack. But it\u0027s not all cases. Do you assure us that devstack user surely uses the directory structure?","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de488ea66752a12348c65867dc78fbb022620351","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    exit 1"},{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"for fs in \"/\" \"/var\" \"/opt\"; do"},{"line_number":101,"context_line":"    if [ $(df -k $fs | tail -n 1 | awk \u0027{ print $4 }\u0027) -lt 2097152 ]; then"},{"line_number":102,"context_line":"        echo \"You don\u0027t have enough free space on $fs.\""},{"line_number":103,"context_line":"        echo \"You need at least 2GB of free space.\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_774a6c57","line":100,"in_reply_to":"7a016987_107349b6","updated":"2015-05-26 08:27:23.000000000","message":"I agree with Hirofumi, we should check $DEST variable as well.","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"bfaf535e7045213ea1cba3e6ed7260c788a8ba14","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    exit 1"},{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"for fs in \"/\" \"/var\" \"/opt\"; do"},{"line_number":101,"context_line":"    if [ $(df -k $fs | tail -n 1 | awk \u0027{ print $4 }\u0027) -lt 2097152 ]; then"},{"line_number":102,"context_line":"        echo \"You don\u0027t have enough free space on $fs.\""},{"line_number":103,"context_line":"        echo \"You need at least 2GB of free space.\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_f88f4473","line":100,"in_reply_to":"7a016987_774a6c57","updated":"2015-05-27 07:45:43.000000000","message":"I have replaced /opt with $DEST. That\u0027s what we want anyway.","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9950869659e04b78cf88b77ec56d447b15885b2d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"for fs in \"/\" \"/var\" \"/opt\"; do"},{"line_number":101,"context_line":"    if [ $(df -k $fs | tail -n 1 | awk \u0027{ print $4 }\u0027) -lt 2097152 ]; then"},{"line_number":102,"context_line":"        echo \"You don\u0027t have enough free space on $fs.\""},{"line_number":103,"context_line":"        echo \"You need at least 2GB of free space.\""},{"line_number":104,"context_line":"        exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_cd107a5c","line":101,"updated":"2015-05-26 00:17:26.000000000","message":"What\u0027s the reason for 2GB?","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"bfaf535e7045213ea1cba3e6ed7260c788a8ba14","unresolved":false,"context_lines":[{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"for fs in \"/\" \"/var\" \"/opt\"; do"},{"line_number":101,"context_line":"    if [ $(df -k $fs | tail -n 1 | awk \u0027{ print $4 }\u0027) -lt 2097152 ]; then"},{"line_number":102,"context_line":"        echo \"You don\u0027t have enough free space on $fs.\""},{"line_number":103,"context_line":"        echo \"You need at least 2GB of free space.\""},{"line_number":104,"context_line":"        exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_38203c49","line":101,"in_reply_to":"7a016987_9764c8e5","updated":"2015-05-27 07:45:43.000000000","message":"@Hirofumi, rabbitmq starts throwing disk space warnings at the 1GB mark, at which point it may start refusing (blocking) new connections. I want to catch this somewhat earlier, so 2GB seems reasonable.\n\n@Kuba, sure :)","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de488ea66752a12348c65867dc78fbb022620351","unresolved":false,"context_lines":[{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"for fs in \"/\" \"/var\" \"/opt\"; do"},{"line_number":101,"context_line":"    if [ $(df -k $fs | tail -n 1 | awk \u0027{ print $4 }\u0027) -lt 2097152 ]; then"},{"line_number":102,"context_line":"        echo \"You don\u0027t have enough free space on $fs.\""},{"line_number":103,"context_line":"        echo \"You need at least 2GB of free space.\""},{"line_number":104,"context_line":"        exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_9764c8e5","line":101,"in_reply_to":"7a016987_cd107a5c","updated":"2015-05-26 08:27:23.000000000","message":"Can you make the minimal value a constant at the beginning of the file?","commit_id":"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3e65cd515a95816dd4482a8cbb46b33ab475d544","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    set -o nounset"},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"EXPECTED_FREE_SPACE\u003d${EXPECTED_FREE_SPACE:-2097152}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Configuration"},{"line_number":52,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a016987_b381ed4f","line":49,"updated":"2015-05-27 08:03:42.000000000","message":"It is a little bit funny to set env variable prior to running devstack to give you warning at certain disk space :)","commit_id":"3a48e748d4f6c6780314ad142d6257b0e8d12f0a"}]}