)]}'
{"id":"openstack%2Fdevstack~185432","triplet_id":"openstack%2Fdevstack~master~I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e","project":"openstack/devstack","branch":"master","topic":"check_free_space","hashtags":[],"change_id":"I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e","subject":"Add sanity check for enough free space","status":"ABANDONED","created":"2015-05-25 17:14:23.000000000","updated":"2016-02-15 10:23:56.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ccfb063850dacdb2c025901b634ecf47c9b51650","_number":185432,"virtual_id_number":185432,"owner":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":-1,"date":"2016-01-23 08:53:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"date":"2015-05-28 09:37:16.000000000","_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"disliked":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"all":[{"value":-1,"date":"2015-08-04 17:45:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-05-28 20:36:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},{"value":1,"date":"2015-05-27 23:56:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":1,"date":"2015-08-04 04:38:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2015-05-28 00:00:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},{"value":-1,"date":"2015-05-28 00:30:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2015-07-01 04:56:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},{"value":1,"date":"2015-05-27 08:03:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-25 17:15:45.000000000","updated_by":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"reviewer":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"state":"REVIEWER"},{"updated":"2015-05-26 07:15:08.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2015-05-27 08:03:42.000000000","updated_by":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"reviewer":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"state":"REVIEWER"},{"updated":"2015-05-27 23:56:45.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2015-05-28 00:00:59.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-05-28 00:30:52.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-05-28 20:36:37.000000000","updated_by":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"reviewer":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"state":"REVIEWER"},{"updated":"2015-07-01 04:56:26.000000000","updated_by":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"reviewer":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"state":"REVIEWER"},{"updated":"2015-08-04 04:38:33.000000000","updated_by":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"reviewer":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"state":"REVIEWER"},{"updated":"2015-08-04 17:45:52.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-01-23 08:53:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"14dd97677bcb675cc09e5e723a102686fd34d171","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-25 17:14:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"768979bb5110b765c94f2b8c0f04145122969f45","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-25 17:14:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cc0cb495b41087281ad37dbccf09b4bac068ca71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-25 18:00:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/32/185432/2/check/check-tempest-dsvm-full/eed6f94/ : SUCCESS in 36m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/185432/2/check/check-tempest-dsvm-postgres-full/eaf8cec/ : SUCCESS in 35m 23s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/32/185432/2/check/check-tempest-dsvm-neutron-full/73bd038/ : SUCCESS in 44m 09s\n- check-grenade-dsvm http://logs.openstack.org/32/185432/2/check/check-grenade-dsvm/2443959/ : SUCCESS in 40m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/185432/2/check/gate-tempest-dsvm-large-ops/350cdc1/ : SUCCESS in 21m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/185432/2/check/gate-tempest-dsvm-neutron-large-ops/c6f193d/ : SUCCESS in 20m 11s\n- gate-devstack-bashate http://logs.openstack.org/32/185432/2/check/gate-devstack-bashate/c19ccc7/ : SUCCESS in 23s\n- gate-devstack-unit-tests http://logs.openstack.org/32/185432/2/check/gate-devstack-unit-tests/1960fd9/ : SUCCESS in 20s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/185432/2/check/check-devstack-dsvm-cells/c2a703e/ : SUCCESS in 18m 21s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/32/185432/2/check/check-grenade-dsvm-partial-ncpu/94c4b45/ : SUCCESS in 37m 27s\n- check-swift-dsvm-functional http://logs.openstack.org/32/185432/2/check/check-swift-dsvm-functional/fe0acf9/ : SUCCESS in 20m 24s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/32/185432/2/check/check-tempest-dsvm-ironic-pxe_ssh/5b357eb/ : SUCCESS in 34m 39s\n- check-devstack-dsvm-updown http://logs.openstack.org/32/185432/2/check/check-devstack-dsvm-updown/e1d6f86/ : SUCCESS in 24m 46s\n- check-tempest-dsvm-f21 http://logs.openstack.org/32/185432/2/check/check-tempest-dsvm-f21/4aa3b72/ : FAILURE in 40m 42s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/32/185432/2/check/check-tempest-dsvm-centos7/6511693/ : SUCCESS in 36m 33s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/32/185432/2/check/gate-devstack-publish-docs/42802f1//doc/build/html/ : SUCCESS in 1m 40s\n- check-grenade-dsvm-neutron http://logs.openstack.org/32/185432/2/check/check-grenade-dsvm-neutron/f80f632/ : FAILURE in 39m 10s","accounts_in_message":[],"_revision_number":2},{"id":"a54bc42c460e8889ab487d05b5bf110f15eff606","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-05-25 18:25:42.000000000","message":"Patch Set 2: Code-Review-1\n\nIMHO this is too clumsy, in particular when stack.sh is run more than once, the second run will not need any additional space at all.","accounts_in_message":[],"_revision_number":2},{"id":"5a5c6209c4bad229e197838de96ea8375b9fd9ef","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-25 18:32:48.000000000","message":"Patch Set 2:\n\nActually, I ran into this on a pre-existing setup which I\u0027ve been running for about a year or so. Eventually the logs accumulated and were too much. I know of other people it happened to as well.\n\nCan you please clarify why it is clumsy?","accounts_in_message":[],"_revision_number":2},{"id":"9950869659e04b78cf88b77ec56d447b15885b2d","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-05-26 00:17:26.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4f01cf55a1e42d768d728a1354df2669117fd2fd","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-05-26 03:23:21.000000000","message":"Patch Set 2:\n\nIf you leave your devstack running long enough, any setup will run out of space, as the old logs never get deleted. So IMHO monitoring free disk space is outside the scope of devstack.\n\nAlso I think that requiring 2GB is pretty much for a small testing VM, on the other hand it may be too small if one initially deploys a large set of services, so that value should at least be configurable.","accounts_in_message":[],"_revision_number":2},{"id":"16d24173976e2d3fa429a4a7ba02bcb852888e12","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-26 05:45:39.000000000","message":"Patch Set 2:\n\n@Jens, that\u0027s the point. Eventually, given a setup that runs for long enough, it will start failing because of the ambitious reasons specified in the commit message. In that case, it\u0027s reasonable that the user will re-run ./stack.sh - and this is the case i\u0027m seeking to alert the user of.\n\nAlso, I\u0027d like to point out that I\u0027m expecting at least 2GB of free space, not 2GB of disk space allocated to the machine. Also, that limit is arbitrarily selected (a hunch if you will) until I\u0027ll have more time to examine exactly how much space *is* needed.","accounts_in_message":[],"_revision_number":2},{"id":"054794749288a24247354f6b5b1488a638beadf0","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-05-26 07:15:08.000000000","message":"Patch Set 2: -Code-Review\n\nO.k., I\u0027m halfway convinced, but still think that 2GB is way too much in general. Also, how about moving the check towards the end of the run, so that all the space occupied by the downloads is already included. That way you could also make this check non-fatal, just showing a big enough warning might then be enough.","accounts_in_message":[],"_revision_number":2},{"id":"de488ea66752a12348c65867dc78fbb022620351","author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"date":"2015-05-26 08:27:23.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3e4db114179fb63a15f5f3a77021c043134aef8f","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-26 11:45:49.000000000","message":"Patch Set 2:\n\nJens, will do. Thanks for the reconsideration :)\n\nI\u0027ll probably have enough time to revisit this on Thursday. Please stay tuned.","accounts_in_message":[],"_revision_number":2},{"id":"4aa89f9441f97f8255fff1c05d50fbabf130b177","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-05-26 13:16:45.000000000","message":"Patch Set 2: Code-Review-1\n\n+1 to make it a warning","accounts_in_message":[],"_revision_number":2},{"id":"bfaf535e7045213ea1cba3e6ed7260c788a8ba14","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-27 07:45:43.000000000","message":"Patch Set 2:\n\n(3 comments)\n\nI\u0027ve also moved the check down the file, after the images have been downloaded and uploaded to glance. The error was changed to a warning (so no \u0027exit 1\u0027 now).","accounts_in_message":[],"_revision_number":2},{"id":"17ea2787fd4083ed83924a33dcd9c55e207a55a1","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-27 07:45:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4cb3683bc83bd2a1b3be4c843c7eac35240c6478","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-27 07:46:49.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3e65cd515a95816dd4482a8cbb46b33ab475d544","author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"date":"2015-05-27 08:03:42.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"965c84713a8e46e69d4075ea5a77a52417dbe994","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-27 08:39:26.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/32/185432/4/check/check-tempest-dsvm-full/d391f99/ : SUCCESS in 47m 09s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/185432/4/check/check-tempest-dsvm-postgres-full/73349ab/ : SUCCESS in 44m 49s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/32/185432/4/check/check-tempest-dsvm-neutron-full/3c3bc10/ : SUCCESS in 50m 14s\n- check-grenade-dsvm http://logs.openstack.org/32/185432/4/check/check-grenade-dsvm/ad41b23/ : SUCCESS in 42m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/185432/4/check/gate-tempest-dsvm-large-ops/69024a1/ : SUCCESS in 26m 41s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/185432/4/check/gate-tempest-dsvm-neutron-large-ops/c7a44dd/ : SUCCESS in 19m 04s\n- gate-devstack-bashate http://logs.openstack.org/32/185432/4/check/gate-devstack-bashate/95cd6fe/ : SUCCESS in 17s\n- gate-devstack-unit-tests http://logs.openstack.org/32/185432/4/check/gate-devstack-unit-tests/7ceb5b3/ : SUCCESS in 19s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/185432/4/check/check-devstack-dsvm-cells/cc57038/ : SUCCESS in 21m 51s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/32/185432/4/check/check-grenade-dsvm-partial-ncpu/533fd24/ : SUCCESS in 35m 34s\n- check-swift-dsvm-functional http://logs.openstack.org/32/185432/4/check/check-swift-dsvm-functional/29502b5/ : SUCCESS in 19m 02s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/32/185432/4/check/check-tempest-dsvm-ironic-pxe_ssh/629997d/ : SUCCESS in 28m 06s\n- check-devstack-dsvm-updown http://logs.openstack.org/32/185432/4/check/check-devstack-dsvm-updown/06cbafa/ : SUCCESS in 19m 21s\n- check-tempest-dsvm-f21 http://logs.openstack.org/32/185432/4/check/check-tempest-dsvm-f21/c71c5c8/ : SUCCESS in 38m 04s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/32/185432/4/check/check-tempest-dsvm-centos7/bb329d5/ : FAILURE in 38m 36s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/32/185432/4/check/gate-devstack-publish-docs/7a295bd//doc/build/html/ : SUCCESS in 1m 39s\n- check-grenade-dsvm-neutron http://logs.openstack.org/32/185432/4/check/check-grenade-dsvm-neutron/20ddcf6/ : SUCCESS in 36m 50s","accounts_in_message":[],"_revision_number":4},{"id":"bea2a7eb226a7df4e46e0a18ec3a399dd95c3082","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-05-27 23:56:45.000000000","message":"Patch Set 4: Code-Review+1\n\nI agree with using warning.","accounts_in_message":[],"_revision_number":4},{"id":"6b9ee1049cae5f5d4b5321674523abf177d4ac9d","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-05-28 00:00:59.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e118227cb5a24e3b327a2e755622225a90bf4155","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-28 00:30:52.000000000","message":"Patch Set 4: Code-Review-1\n\ni remain unconvinced\n\n* devstack is used in many CI situations where people might keep thing very tight for performance reasons, but they don\u0027t care because after their run they start again.\n\n* what good is a warning really?  is anyone going to read it in the scroll-through for thousands of lines.  who is going to bother with that variable\n\n* i can\u0027t see we can sensibly decide on something generic enough to enforce this in a meaningful way.  not just the size, but people might use mounted volumes for things like /opt in their ci, etc.\n\n* size varies hugely depending on what images get downloaded\n\n* this only warns at stack.sh time; the problem occurs most likely after a system has been running for a long time.  i\u0027d suggest devstack is more targeted at the ephemeral case\n\n* every program fails badly when disk-space runs out, and they don\u0027t all check for X free space before they start.\n\nMy concern is that stuff like this becomes calcified and we even forget what it\u0027s there for, and tends to unnecessary confusion down the line.","accounts_in_message":[],"_revision_number":4},{"id":"938d7f90728598d55e4f1fd0ed70b2d9b030d65d","author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"date":"2015-05-28 07:41:19.000000000","message":"Patch Set 4:\n\n@Ian, John wanted to make a better \u0027user experience\u0027. I know two more people who ran out of space during stack.sh and spent quite a time investigating what\u0027s wrong. What usually happens is that rabbitmq just stops communicating (https://bugs.launchpad.net/oslo.messaging/+bug/1454449), my experience is that \u0027glance image-create\u0027 just hung forever without any warning or error message.\n\nI\u0027m also not sure how not having a warning message is better.","accounts_in_message":[],"_revision_number":4},{"id":"9cdc6961faa75f2330caac1c66b6f68fc1855b78","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2015-05-28 09:37:16.000000000","message":"Patch Set 4:\n\n@Ian, I\u0027ll address your points in order (can\u0027t do it inline):\n\n * This patch isn\u0027t addressed for CI situations. In that case I assume the CI guy will be smart enough to see that something is bad and look for errors and warnings in his stack.sh (and in this case, the warning is only another indicator of what\u0027s wrong with his setup). Normally this shouldn\u0027t pop but if there is a problem this might help.\n\n * This patch is addressed for humans running ./stack.sh for development purposes. In this case, the screen printout is quite short (1-2 screens long) and it should pop up to the screen, allowing the user to easily find it among the ~50 lines of output. A warning is good since it *might* indicate a problem that might be there.\n\n * They are welcome to use mounted volumes for things like /opt. \u0027df /opt\u0027 gives a listing specifically for the filesystem /opt is in. Since this is a warning, nothing is enforced.\n\n * Size may vary greatly, which is why the warning is placed after the images were downloaded. It doesn\u0027t change the fact that if, after downloading the images, there isn\u0027t enough space for programs to operate, stuff like rabbitmq will fail and no warning is given at all.\n\n * On this we agree. However, as I (and numerous others) have indicated, once things to south, us developers tend to just \"start from scratch\" - which is basically re-run ./stack.sh. This is (one of) the case(s) this patch tries to deal with, but displaying a visible warning to the screen.\n\n * Just because every program fails for it, doesn\u0027t mean they shouldn\u0027t alert for it. Especially if we\u0027re talking about a deployment program.\n\nI\u0027m fine with adding comments as to why this is needed if this will ease your mind.","accounts_in_message":[],"_revision_number":4},{"id":"39b2c60c83fcf802a0827424b44dd2213c3ce605","author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"date":"2015-05-28 20:36:37.000000000","message":"Patch Set 4: Code-Review-1\n\nYou are making an assumption the software is installed in /.\nIt\u0027s actually installed in $DEST, which is configurable defaulting to /opt/stack.\n\nWhat is their is a dedicated /opt partition.  That\u0027s the old school way some of us still setup servers.\n\nI also point out to install Magnum you need generally 30G+ so the value is dependent on the LIBS installed.","accounts_in_message":[],"_revision_number":4},{"id":"c5bce66c67c1498e638367970b41318a24e2b3b6","author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"date":"2015-07-01 04:56:26.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"b65fb37eddc8c458ff099b939e88a3e40711903d","author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"date":"2015-08-04 04:38:33.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"45930a259859f8cecfd9b908810d23927b18c0a1","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2015-08-04 17:45:52.000000000","message":"Patch Set 4: Code-Review-1\n\nDevStack has documentation about how much RAM a system needs. However, up until earlier this year it was incredibly out of date, I think it was either 512MB or 1GB of ram, which was really what DevStack needed ... in 2012. I think that the velocity of OpenStack is such that it\u0027s difficult to keep a good set of recommendations as to the minimum amount of resources that are required for a successful stack.sh run. \n\nSo, it\u0027s not a great reason to -1 this, but we\u0027ve done a bad job at documenting what the minimums are, and that was just docs, not code (which is even less flexible and forgiving)","accounts_in_message":[],"_revision_number":4},{"id":"671211cef3265ed48f457b8530dd6962458e31e9","author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"date":"2015-08-06 08:47:58.000000000","message":"Patch Set 4:\n\n@Sean: Even though documentation provides minimum requirements it\u0027s not nice from devstack to hang forever without any warning or log message. And this is about running out of disk space, not RAM :)\n\nMaybe it\u0027s a glance bug that glance image creation doesn\u0027t fail when you run out of space?","accounts_in_message":[],"_revision_number":4},{"id":"525174afc71bba8eca1bb9c142c10cc0f6b9f8a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-23 08:53:17.000000000","message":"Patch Set 4: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"d714daf0077772287747b9962bfde7e08ef0dc10","author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"date":"2016-02-15 10:23:56.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"3a48e748d4f6c6780314ad142d6257b0e8d12f0a","revisions":{"197c120be70f86ce54612c9d60e5d3bdcc6492f3":{"kind":"REWORK","_number":1,"created":"2015-05-25 17:14:23.000000000","uploader":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"ref":"refs/changes/32/185432/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/185432/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/185432/1"}}},"commit":{"parents":[{"commit":"1235581559087974580c0e5f6e3ade82e9030a70","subject":"Merge \"Add ironic files to .gitignore\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1235581559087974580c0e5f6e3ade82e9030a70"}]}],"author":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-25 17:08:50.000000000","tz":-240},"committer":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-25 17:11:27.000000000","tz":180},"subject":"Add sanity check for enough free space.","message":"Add sanity check for enough free space.\n\nRunning ./stack.sh on a machine that lacks enough free space can lead\nvarious errors that are hard to track down, such as the messaging queue\nstops handling messages, sql server stops answering, etc. There really\nshould be an error to let the user know what he\u0027s doing wrong here.\n\n2GB is used as an arbitrary lower limit.\n\nChange-Id: I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/197c120be70f86ce54612c9d60e5d3bdcc6492f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/197c120be70f86ce54612c9d60e5d3bdcc6492f3"}]},"branch":"refs/heads/master"},"ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-05-25 17:14:56.000000000","uploader":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"ref":"refs/changes/32/185432/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/185432/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/185432/2"}}},"commit":{"parents":[{"commit":"1235581559087974580c0e5f6e3ade82e9030a70","subject":"Merge \"Add ironic files to .gitignore\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1235581559087974580c0e5f6e3ade82e9030a70"}]}],"author":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-25 17:08:50.000000000","tz":-240},"committer":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-25 17:14:43.000000000","tz":180},"subject":"Add sanity check for enough free space","message":"Add sanity check for enough free space\n\nRunning ./stack.sh on a machine that lacks enough free space can lead\nvarious errors that are hard to track down, such as the messaging queue\nstops handling messages, sql server stops answering, etc. There really\nshould be an error to let the user know what he\u0027s doing wrong here.\n\n2GB is used as an arbitrary lower limit.\n\nChange-Id: I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ec8adc4e986732d9cd0f1aa3a1a19a3a5f3670d7"}]},"branch":"refs/heads/master"},"d8129de6c761b05a5558ce7028b1edb8a01d58e8":{"kind":"REWORK","_number":3,"created":"2015-05-27 07:45:56.000000000","uploader":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"ref":"refs/changes/32/185432/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/185432/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/185432/3"}}},"commit":{"parents":[{"commit":"1235581559087974580c0e5f6e3ade82e9030a70","subject":"Merge \"Add ironic files to .gitignore\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1235581559087974580c0e5f6e3ade82e9030a70"}]}],"author":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-25 17:08:50.000000000","tz":-240},"committer":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-27 07:42:50.000000000","tz":180},"subject":"Add sanity check for enough free space","message":"Add sanity check for enough free space\n\nRunning ./stack.sh on a machine that lacks enough free space can lead\nvarious errors that are hard to track down, such as the messaging queue\nstops handling messages, sql server stops answering, etc. There really\nshould be an error to let the user know what he\u0027s doing wrong here.\n\n2GB is used as a lower limit, since rabbitmq for example starts logging\nwarnings at the 1GB mark.\n\nChange-Id: I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d8129de6c761b05a5558ce7028b1edb8a01d58e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d8129de6c761b05a5558ce7028b1edb8a01d58e8"}]},"branch":"refs/heads/master"},"3a48e748d4f6c6780314ad142d6257b0e8d12f0a":{"kind":"REWORK","_number":4,"created":"2015-05-27 07:46:49.000000000","uploader":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"ref":"refs/changes/32/185432/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/185432/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/185432/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/185432/4"}}},"commit":{"parents":[{"commit":"1235581559087974580c0e5f6e3ade82e9030a70","subject":"Merge \"Add ironic files to .gitignore\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1235581559087974580c0e5f6e3ade82e9030a70"}]}],"author":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-25 17:08:50.000000000","tz":-240},"committer":{"name":"John Schwarz","email":"jschwarz@redhat.com","date":"2015-05-27 07:46:39.000000000","tz":180},"subject":"Add sanity check for enough free space","message":"Add sanity check for enough free space\n\nRunning ./stack.sh on a machine that lacks enough free space can lead\nvarious errors that are hard to track down, such as the messaging queue\nstops handling messages, sql server stops answering, etc. There really\nshould be an error to let the user know what he\u0027s doing wrong here.\n\n2GB is used as a lower limit, since rabbitmq for example starts logging\nwarnings at the 1GB mark.\n\nChange-Id: I3f44cb8cfe3cbc8bc8940a52a2c0b81c1890383e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3a48e748d4f6c6780314ad142d6257b0e8d12f0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3a48e748d4f6c6780314ad142d6257b0e8d12f0a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}