)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4ab842055ad8529ee38fdf8497c25951e38c1503","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tony Breeds \u003ctony@bakeyournoodle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 13:40:29 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Chnage the restart_rpc_backend loop to accomodate slow rabbitmq"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RabbitMQ 3.4 seems to start slower than previous versions."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_3e28cbe1","line":7,"updated":"2015-05-29 03:51:40.000000000","message":"Grrr I\u0027ll *Change* this once I\u0027ve collected some reviews.","commit_id":"d271120fe9cc4ea3debbdf0fd9e04f62cafa3e61"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0775453ea9b7e194db5bedc1382e5fa7499089fd","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"},{"line_number":22,"context_line":"through the loop.  Allowing time for the slow rabbot to start."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ibb291c1ecfd109f9ed10b5f194933364985cc1ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_0b182c74","line":23,"updated":"2015-05-29 04:57:11.000000000","message":"bug 1449056 ?","commit_id":"d271120fe9cc4ea3debbdf0fd9e04f62cafa3e61"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"778841d397b029ccf529e07c7970b6e280191123","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"},{"line_number":22,"context_line":"through the loop.  Allowing time for the slow rabbot to start."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ibb291c1ecfd109f9ed10b5f194933364985cc1ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_cb0b34d5","line":23,"in_reply_to":"7a016987_0b182c74","updated":"2015-05-29 05:18:34.000000000","message":"Done","commit_id":"d271120fe9cc4ea3debbdf0fd9e04f62cafa3e61"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bc19a2fc2079c0a3d63b65ec7d7ab660a89cf701","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the restart_rpc_backend loop to accomodate async rabbitmq"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros have converted to systemd for starting RabiitMQ.  This has"},{"line_number":10,"context_line":"resulted in:"},{"line_number":11,"context_line":"---"},{"line_number":12,"context_line":"[Call Trace]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_4ae5c806","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":60},"updated":"2015-06-01 06:07:09.000000000","message":"RabbitMQ","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"10b63fa4c4c62b2489e81c27ba043cd091ee9e21","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the restart_rpc_backend loop to accomodate async rabbitmq"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros have converted to systemd for starting RabiitMQ.  This has"},{"line_number":10,"context_line":"resulted in:"},{"line_number":11,"context_line":"---"},{"line_number":12,"context_line":"[Call Trace]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_ca09b896","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":60},"in_reply_to":"7a016987_4ae5c806","updated":"2015-06-01 06:31:24.000000000","message":"Done","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"63ec3d615d5f08073e504a98321da01473a1509f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"World dumping... see /opt/stack/logs/worlddump-2015-05-29-031618.txt for details"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Because \u0027restart_service rabbitmq-server\u0027 returns befoer the server is ready to"},{"line_number":21,"context_line":"accept connections."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_6ad1a422","line":20,"range":{"start_line":20,"start_character":50,"end_line":20,"end_character":56},"updated":"2015-06-01 06:07:48.000000000","message":"before","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"10b63fa4c4c62b2489e81c27ba043cd091ee9e21","unresolved":false,"context_lines":[{"line_number":17,"context_line":"World dumping... see /opt/stack/logs/worlddump-2015-05-29-031618.txt for details"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Because \u0027restart_service rabbitmq-server\u0027 returns befoer the server is ready to"},{"line_number":21,"context_line":"accept connections."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_aafc3c72","line":20,"range":{"start_line":20,"start_character":50,"end_line":20,"end_character":56},"in_reply_to":"7a016987_6ad1a422","updated":"2015-06-01 06:31:24.000000000","message":"Done","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bc19a2fc2079c0a3d63b65ec7d7ab660a89cf701","unresolved":false,"context_lines":[{"line_number":21,"context_line":"accept connections."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"},{"line_number":24,"context_line":"through the loop.  Allowing time for the slow rabbot to start."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: 1449056"},{"line_number":27,"context_line":"Change-Id: Ibb291c1ecfd109f9ed10b5f194933364985cc1ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_ca31b8a3","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":52},"updated":"2015-06-01 06:07:09.000000000","message":"rabbit?","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"10b63fa4c4c62b2489e81c27ba043cd091ee9e21","unresolved":false,"context_lines":[{"line_number":21,"context_line":"accept connections."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"},{"line_number":24,"context_line":"through the loop.  Allowing time for the slow rabbot to start."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: 1449056"},{"line_number":27,"context_line":"Change-Id: Ibb291c1ecfd109f9ed10b5f194933364985cc1ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_6afbe479","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":52},"in_reply_to":"7a016987_ca31b8a3","updated":"2015-06-01 06:31:24.000000000","message":"Done","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bc19a2fc2079c0a3d63b65ec7d7ab660a89cf701","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"},{"line_number":24,"context_line":"through the loop.  Allowing time for the slow rabbot to start."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: 1449056"},{"line_number":27,"context_line":"Change-Id: Ibb291c1ecfd109f9ed10b5f194933364985cc1ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_8ade203c","line":25,"updated":"2015-06-01 06:07:09.000000000","message":"i\u0027m not sure how this can be a workaround.\nisn\u0027t it more reliable to have an explicit sleep?","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"10b63fa4c4c62b2489e81c27ba043cd091ee9e21","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Alter the retry loop to only restart the rabbitmq-server every second time"},{"line_number":24,"context_line":"through the loop.  Allowing time for the slow rabbot to start."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: 1449056"},{"line_number":27,"context_line":"Change-Id: Ibb291c1ecfd109f9ed10b5f194933364985cc1ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_2a1f2cb8","line":25,"in_reply_to":"7a016987_8ade203c","updated":"2015-06-01 06:31:24.000000000","message":"Possibly.  Frankly I think it comes down to style/taste.  I\u0027m happy to add a sleep if that\u0027s preferred.","commit_id":"beb5ceea5ffffc8eacbf96e58e80e07804befb42"}],"lib/rpc_backend":[{"author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"change_message_id":"5a1299400743a66a60531736fd15985aab24ecb1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        # every second time around the loop.  This allows for slow rabbitmq"},{"line_number":199,"context_line":"        # startup causing this to fail devstack."},{"line_number":200,"context_line":"        local i"},{"line_number":201,"context_line":"        for i in `seq 20`; do"},{"line_number":202,"context_line":"            local rc\u003d0"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_397905c9","line":201,"updated":"2015-05-29 04:50:35.000000000","message":"I seem that this loop finish 10,  because there is as follow code.\n\n[[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\"","commit_id":"d271120fe9cc4ea3debbdf0fd9e04f62cafa3e61"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"778841d397b029ccf529e07c7970b6e280191123","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        # every second time around the loop.  This allows for slow rabbitmq"},{"line_number":199,"context_line":"        # startup causing this to fail devstack."},{"line_number":200,"context_line":"        local i"},{"line_number":201,"context_line":"        for i in `seq 20`; do"},{"line_number":202,"context_line":"            local rc\u003d0"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_eb06f0cc","line":201,"in_reply_to":"7a016987_397905c9","updated":"2015-05-29 05:18:34.000000000","message":"Done","commit_id":"d271120fe9cc4ea3debbdf0fd9e04f62cafa3e61"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4ab842055ad8529ee38fdf8497c25951e38c1503","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            [[ $i -eq \"10\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":207,"context_line":"                restart_service rabbitmq-server"},{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_1e53cf6c","line":206,"updated":"2015-05-29 03:51:40.000000000","message":"I also considered adding a check against the distro (or rabbit versionb) and adding a sleep.\n ---\n +            if [[ ${DISTRO} \u003d~ vivid ]] ; then \n +                sleep 1s\n +            fi\n ---\n\nThat seemed more hackish to me.  In the common case that rabbit-mq starts in a reasonable time *and* bug 1144100 isn\u0027t a problem then my proposal is essentially a no-op.","commit_id":"d271120fe9cc4ea3debbdf0fd9e04f62cafa3e61"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89f19130f86a812d83837e00e6340df73f1df98d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # NOTE(bnemec): Retry initial rabbitmq configuration to deal with"},{"line_number":195,"context_line":"        # the fact that sometimes it fails to start properly."},{"line_number":196,"context_line":"        # Reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1144100"},{"line_number":197,"context_line":"        # NOTE(tonyb): Extend the orginal retry logic to only restart rabbitmq"},{"line_number":198,"context_line":"        # every second time around the loop."},{"line_number":199,"context_line":"        # See: https://bugs.launchpad.net/devstack/+bug/1449056 for details on"},{"line_number":200,"context_line":"        # why this is needed.  This can bee seen on vivid and Debian unstable"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5afe65bd_2036af52","line":197,"updated":"2015-06-03 07:52:58.000000000","message":"Nit: original","commit_id":"6bc905c3488a93fa87776bcd0af7e362a90b082f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89f19130f86a812d83837e00e6340df73f1df98d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        # See: https://bugs.launchpad.net/devstack/+bug/1449056 for details on"},{"line_number":200,"context_line":"        # why this is needed.  This can bee seen on vivid and Debian unstable"},{"line_number":201,"context_line":"        # (May 2015)"},{"line_number":202,"context_line":"        # TODO(tonyb): Remove this when Debian and Ubuntu have a fixed systemd"},{"line_number":203,"context_line":"        # service file."},{"line_number":204,"context_line":"        local i"},{"line_number":205,"context_line":"        for i in `seq 20`; do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5afe65bd_60614739","line":202,"updated":"2015-06-03 07:52:58.000000000","message":"Maybe you can be a bit more specific here what \"this\" shall be, iiuc the general restart logic was needed because of some other issues.","commit_id":"6bc905c3488a93fa87776bcd0af7e362a90b082f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89f19130f86a812d83837e00e6340df73f1df98d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        # TODO(tonyb): Remove this when Debian and Ubuntu have a fixed systemd"},{"line_number":203,"context_line":"        # service file."},{"line_number":204,"context_line":"        local i"},{"line_number":205,"context_line":"        for i in `seq 20`; do"},{"line_number":206,"context_line":"            local rc\u003d0"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5afe65bd_008733d8","line":205,"updated":"2015-06-03 07:52:58.000000000","message":"Do we really need 20 iterations? I was already wondering whether trying 10 restarts in a row will solve anything. IMO keeping the count at 10, resulting in a maximum of four restarts should still be more than enough.","commit_id":"6bc905c3488a93fa87776bcd0af7e362a90b082f"}]}