)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fe214a1a327d2599ff76c21f38d3d9391fec425c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check if lvm2 is installed before doing anything lvm2 related"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On some system Cinder is not installed nor LVM. Do not try to `sed`"},{"line_number":10,"context_line":"/etc/lvm.conf or clean LVM VG if lvm is not installed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I09b1a7bee0785e5e1bb7dc96158a654bd3f15c83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa32b979_8e3e1828","line":10,"updated":"2015-06-19 13:56:05.000000000","message":"This commit message is old. You should rewrite it according with discussion on this patch.","commit_id":"cae35309c8de577ca7771da29aea794068c2e2bc"}],"lib/lvm":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e5bd8ca73662776106f6116283e3f2b011beec08","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    filter_string\u003d$filter_string$filter_suffix"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    clean_lvm_filter"},{"line_number":180,"context_line":"    sudo sed -i \"/# global_filter \u003d \\[*\\]/a\\    $global_filter$filter_string\" /etc/lvm/lvm.conf"},{"line_number":181,"context_line":"    echo_summary \"set lvm.conf device global_filter to: $filter_string\""},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_e63ccf94","line":180,"updated":"2015-05-29 16:40:56.000000000","message":"Do you also add it to here? Otherwise, does ubuntu surely have lvm?","commit_id":"84db574d8fa29cfe088731afa4acc7ddaa01f7d1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e0e9138fa0ab4271c49d662d8130b5d1d5545c47","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    filter_string\u003d$filter_string$filter_suffix"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    clean_lvm_filter"},{"line_number":180,"context_line":"    sudo sed -i \"/# global_filter \u003d \\[*\\]/a\\    $global_filter$filter_string\" /etc/lvm/lvm.conf"},{"line_number":181,"context_line":"    echo_summary \"set lvm.conf device global_filter to: $filter_string\""},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a016987_6f09b394","line":180,"in_reply_to":"7a016987_e63ccf94","updated":"2015-06-02 15:15:53.000000000","message":"I should also add it here, yes. But, in fact, on a system without lvm a lot of command on lib/lvm will fail (e.g the call to \u0027pvs\u0027 l172). So I think a more useful fix for this more general problem would be to skip the call to every functions that do a lvm operation.\n\nBut for now, I just want to fix the unstack.sh part because the output of unstack is only a few lines long so any error hurts my eyes more :)","commit_id":"84db574d8fa29cfe088731afa4acc7ddaa01f7d1"}],"stack.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"0fa66f3304dab7e8babd8884ad72daa0e0db19a8","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"openstack complete | sudo tee /etc/bash_completion.d/osc.bash_completion \u003e /dev/null"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"# If cinder is configured, set global_filter for PV devices"},{"line_number":1367,"context_line":"if is_service_enabled cinder \u0026\u0026 is_package_installed lvm2; then"},{"line_number":1368,"context_line":"    if is_ubuntu; then"},{"line_number":1369,"context_line":"        echo_summary \"Configuring lvm.conf global device filter\""},{"line_number":1370,"context_line":"        set_lvm_filter"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_ce47d649","line":1367,"updated":"2015-06-16 18:12:36.000000000","message":"so... the real conditional should probably be testing if lvm is the cinder backend.","commit_id":"717733f738ed812be11c9d129de1411583865e49"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2db2d88f2454a0d7eef6ab6e275bda6a49e20679","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"openstack complete | sudo tee /etc/bash_completion.d/osc.bash_completion \u003e /dev/null"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"# If cinder is configured, set global_filter for PV devices"},{"line_number":1367,"context_line":"if is_service_enabled cinder \u0026\u0026 is_package_installed lvm2; then"},{"line_number":1368,"context_line":"    if is_ubuntu; then"},{"line_number":1369,"context_line":"        echo_summary \"Configuring lvm.conf global device filter\""},{"line_number":1370,"context_line":"        set_lvm_filter"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_c77f69de","line":1367,"in_reply_to":"fa32b979_ce47d649","updated":"2015-06-18 08:19:06.000000000","message":"My change was wrong anyway: you can\u0027t have cinder enabled without lvm2 because lvm2 is installed with cinder (lvm2 is in files/*/cinder)","commit_id":"717733f738ed812be11c9d129de1411583865e49"}],"unstack.sh":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"60fe955c95ea795c36f7ce0c0c0bbef5492b8096","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    fi"},{"line_number":187,"context_line":"fi"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# BUG: maybe it doesn\u0027t exist? We should isolate this further down."},{"line_number":190,"context_line":"clean_lvm_volume_group $DEFAULT_VOLUME_GROUP_NAME || /bin/true"},{"line_number":191,"context_line":"clean_lvm_filter"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3afb71cf_012cd600","side":"PARENT","line":189,"updated":"2015-06-08 09:50:26.000000000","message":"This patch isn\u0027t what solve the issue, is it? If so, the line shouldn\u0027t be removed.","commit_id":"a1774b5704fc73a52ffbda869f923819adb10cf7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ba83fb2ee69e5296f851044009c28139ded3af92","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    fi"},{"line_number":187,"context_line":"fi"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# BUG: maybe it doesn\u0027t exist? We should isolate this further down."},{"line_number":190,"context_line":"clean_lvm_volume_group $DEFAULT_VOLUME_GROUP_NAME || /bin/true"},{"line_number":191,"context_line":"clean_lvm_filter"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3afb71cf_049624f0","side":"PARENT","line":189,"in_reply_to":"3afb71cf_012cd600","updated":"2015-06-08 10:14:24.000000000","message":"I am not sure what this \"BUG\" comment is about, but it feels outdated. I\u0027ll leave (re add) the comment in the next patch set.","commit_id":"a1774b5704fc73a52ffbda869f923819adb10cf7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"60fe955c95ea795c36f7ce0c0c0bbef5492b8096","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    fi"},{"line_number":187,"context_line":"fi"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"if is_package_installed lvm2; then"},{"line_number":190,"context_line":"    clean_lvm_volume_group $DEFAULT_VOLUME_GROUP_NAME || /bin/true"},{"line_number":191,"context_line":"    clean_lvm_filter"},{"line_number":192,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3afb71cf_24e36035","line":189,"updated":"2015-06-08 09:50:26.000000000","message":"If we consider a case that lvm2 is installed and lvm.conf doesn\u0027t exist in the path, it\u0027s better to use the following.\n\nif [[ -f /etc/lvm/lvm.conf ]]","commit_id":"90c7eaa3226a05378a98fcd393f631e594ec84e9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ba83fb2ee69e5296f851044009c28139ded3af92","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    fi"},{"line_number":187,"context_line":"fi"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"if is_package_installed lvm2; then"},{"line_number":190,"context_line":"    clean_lvm_volume_group $DEFAULT_VOLUME_GROUP_NAME || /bin/true"},{"line_number":191,"context_line":"    clean_lvm_filter"},{"line_number":192,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3afb71cf_c4124c62","line":189,"in_reply_to":"3afb71cf_24e36035","updated":"2015-06-08 10:14:24.000000000","message":"clean_lvm_volume_group calls \u0027lvremove\u0027 which comes with the lvm2 package. So we should check that this package is really installed.\n\nI don\u0027t know any distribution that ships lvm2 without /etc/lvm.conf. I could also argue that lvm.conf could be here but the lvm2 package not present (leftover from a previous install) so \"if [[ -f /etc/lvm/lvm.conf ]]\" is probably not enough.","commit_id":"90c7eaa3226a05378a98fcd393f631e594ec84e9"}]}