)]}'
{"id":"openstack%2Fdevstack~188646","triplet_id":"openstack%2Fdevstack~master~Ia508c552d806363f6633d0bcd357c05bf956279f","project":"openstack/devstack","branch":"master","topic":"bridge-filtering","hashtags":[],"change_id":"Ia508c552d806363f6633d0bcd357c05bf956279f","subject":"Ensure netfilter enabled for bridges with OVS Hybrid","status":"ABANDONED","created":"2015-06-05 01:37:36.000000000","updated":"2015-06-17 13:40:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"38297ebbc00a6db7de2edf05741013dc2b61b7a2","_number":188646,"virtual_id_number":188646,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-06-05 02:46:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-06-17 13:18:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":1,"date":"2015-06-17 10:46:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-05 02:46:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-06-17 10:46:59.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-06-17 13:18:50.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"}],"messages":[{"id":"01d4657276d3f7f7922a8d6ec9ed5c75ba6290f1","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-06-05 01:37:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7ae4a5557d62974cc34b2b92dd9e312fcb662e4c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-06-05 01:53:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"aeb6b0593e7e7b2e348e8e426f5fb8605d92f027","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-05 02:46:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/188646/2/check/check-tempest-dsvm-full/b904ba6/ : SUCCESS in 42m 01s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/188646/2/check/check-tempest-dsvm-postgres-full/2bbdf22/ : SUCCESS in 40m 38s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/188646/2/check/check-tempest-dsvm-neutron-full/7d04660/ : SUCCESS in 40m 51s\n- check-grenade-dsvm http://logs.openstack.org/46/188646/2/check/check-grenade-dsvm/06d3f8d/ : SUCCESS in 36m 48s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/188646/2/check/gate-tempest-dsvm-large-ops/20132d7/ : SUCCESS in 20m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/188646/2/check/gate-tempest-dsvm-neutron-large-ops/2b6e5e1/ : SUCCESS in 29m 07s\n- gate-devstack-bashate http://logs.openstack.org/46/188646/2/check/gate-devstack-bashate/67f56ed/ : SUCCESS in 38s\n- gate-devstack-unit-tests http://logs.openstack.org/46/188646/2/check/gate-devstack-unit-tests/2968b69/ : SUCCESS in 23s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/188646/2/check/check-devstack-dsvm-cells/a1b9fc6/ : SUCCESS in 16m 23s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/188646/2/check/check-grenade-dsvm-partial-ncpu/cddc72b/ : SUCCESS in 38m 58s\n- check-swift-dsvm-functional http://logs.openstack.org/46/188646/2/check/check-swift-dsvm-functional/5ee13e5/ : SUCCESS in 26m 26s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/188646/2/check/check-tempest-dsvm-ironic-pxe_ssh/15eb87a/ : SUCCESS in 33m 57s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/188646/2/check/check-devstack-dsvm-updown/fa9902e/ : SUCCESS in 22m 25s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/188646/2/check/check-tempest-dsvm-f21/53e4e29/ : FAILURE in 53m 00s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/188646/2/check/check-tempest-dsvm-centos7/1328f80/ : SUCCESS in 39m 42s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/188646/2/check/gate-devstack-publish-docs/649a100//doc/build/html/ : SUCCESS in 1m 38s\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/188646/2/check/check-grenade-dsvm-neutron/7a16f00/ : SUCCESS in 45m 17s","accounts_in_message":[],"_revision_number":2},{"id":"1ed7609048ee569c9cb0fdf45b7f6f7e4a67043b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-06-17 10:46:59.000000000","message":"Patch Set 2: Code-Review+1\n\nIdeally I\u0027d like to see the neutron fix instead, it seems weird that neutron needs so much out of tree support to function correctly.","accounts_in_message":[],"_revision_number":2},{"id":"77030e2a203b46da969c651cbbef9dc0ce91d7ff","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-06-17 10:47:23.000000000","message":"Patch Set 2:\n\nLeaving at +1 for now until talking with mestery about looking at the base neutron patch.","accounts_in_message":[],"_revision_number":2},{"id":"87afd61c0ba43ef81658a817afc428ebddb94e5b","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2015-06-17 13:18:50.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027m going to move forward with the proper fix in Neutron. Ian and Sean, thanks for bringing this forward to my attention, and thanks for helping to make Neutron better!","accounts_in_message":[],"_revision_number":2},{"id":"db6c1bcb71b367c004ce93a9341f0203266bbcc7","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-06-17 13:40:00.000000000","message":"Abandoned\n\nfix merged in neutron instead","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"15579760cb52f5a2c11a98e380bb0854a6ff873a","revisions":{"48cf0a8036c2fbe7a4b2191cba5b04279722b430":{"kind":"REWORK","_number":1,"created":"2015-06-05 01:37:36.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/46/188646/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/188646/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/188646/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/188646/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/188646/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/188646/1"}}},"commit":{"parents":[{"commit":"21b7e975fa3d1db3710b3d12d965f87828d9be84","subject":"Merge \"MAINTAINERS.rst: Add MidoNet section\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/21b7e975fa3d1db3710b3d12d965f87828d9be84"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-05 01:32:50.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-05 01:32:50.000000000","tz":600},"subject":"Ensure netfilter enabled for bridges with OVS Hybrid","message":"Ensure netfilter enabled for bridges with OVS Hybrid\n\nThe OVS Hybrid driver implements security groups by using netfilter on\nan intermediate Linux bridge.  Unfortunately distributions differ on\nthe default status of this (Ubuntu has it on, Red Hat off, at least).\n\nNeutron is unwilling to set this up itself\n(If2d316eb8c422dc1e4f34b17a50b93dd72993a99) but I have a review out to\ndetect this situation and halt the agent\n(I8b49298d27a75a864c0066896cbd3d3095982f6e).\n\nThis change enables the setting, and does some minimal work to\nconfigure the system to have it enabled.  This is analgous to what is\ndone in other deployment mechanisms such as packstack and fuel, and\nalso what is suggested in the documentation.\n\nChange-Id: Ia508c552d806363f6633d0bcd357c05bf956279f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/48cf0a8036c2fbe7a4b2191cba5b04279722b430"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/48cf0a8036c2fbe7a4b2191cba5b04279722b430"}]},"branch":"refs/heads/master"},"15579760cb52f5a2c11a98e380bb0854a6ff873a":{"kind":"REWORK","_number":2,"created":"2015-06-05 01:53:00.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/46/188646/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/188646/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/188646/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/188646/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/188646/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/188646/2"}}},"commit":{"parents":[{"commit":"21b7e975fa3d1db3710b3d12d965f87828d9be84","subject":"Merge \"MAINTAINERS.rst: Add MidoNet section\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/21b7e975fa3d1db3710b3d12d965f87828d9be84"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-05 01:32:50.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-05 01:52:49.000000000","tz":600},"subject":"Ensure netfilter enabled for bridges with OVS Hybrid","message":"Ensure netfilter enabled for bridges with OVS Hybrid\n\nThe OVS Hybrid driver implements security groups by using netfilter on\nan intermediate Linux bridge.  Unfortunately distributions differ on\nthe default status of this (Ubuntu has it on, Red Hat off, at least).\n\nNeutron is unwilling to set this up itself\n(If2d316eb8c422dc1e4f34b17a50b93dd72993a99) but I have a review out to\ndetect this situation and halt the agent\n(I8b49298d27a75a864c0066896cbd3d3095982f6e).\n\nThis change enables the setting, and does some minimal work to\nconfigure the system to have it enabled.  This is analgous to what is\ndone in other deployment mechanisms such as packstack and fuel, and\nalso what is suggested in the documentation.\n\nChange-Id: Ia508c552d806363f6633d0bcd357c05bf956279f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/15579760cb52f5a2c11a98e380bb0854a6ff873a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/15579760cb52f5a2c11a98e380bb0854a6ff873a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}