)]}'
{"id":"openstack%2Fdevstack~1893","triplet_id":"openstack%2Fdevstack~master~Ia08d314e26fcf4a443b567432d0c36202d151c9f","project":"openstack/devstack","branch":"master","topic":"ci-config","hashtags":[],"change_id":"Ia08d314e26fcf4a443b567432d0c36202d151c9f","subject":"Set up downloaded images for testing","status":"MERGED","created":"2011-11-24 06:20:29.000000000","updated":"2012-01-24 20:02:06.000000000","submitted":"2012-01-24 20:02:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c47573c688207fb022d84fe315afe084f1aa3e93","_number":1893,"virtual_id_number":1893,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-01-24 20:02:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":2,"date":"2012-01-24 19:32:25.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-01-24 20:02:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-01-19 12:06:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"date":"2012-01-06 22:42:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":1,"date":"2012-01-24 19:32:25.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-11-29 23:58:05.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2011-12-09 17:26:53.000000000","updated_by":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"reviewer":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"state":"REVIEWER"},{"updated":"2012-01-19 12:06:40.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-01-24 19:32:25.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2012-01-24 20:02:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4d30c69990fb424448293e998f0c9abadbe5172b","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-11-29 23:58:05.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nyay tests!","accounts_in_message":[],"_revision_number":1},{"id":"88fb0d2db5ce573bcbef2b19127adbd7a7eab2fb","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-11-30 00:40:48.000000000","message":"Patch Set 1:\n\nDoes this imply that it will only work on machines where you also run stack.sh?\n\nPerhaps it should always download the TTY image and use it?","accounts_in_message":[],"_revision_number":1},{"id":"ad42d91209abede1d1d7ce090794868b2a0ef816","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-11-30 00:57:57.000000000","message":"Patch Set 1:\n\nWe already assume that stack.sh is present, or rather that properly configured stackrc/localrc is present.  I have a config path for when UPLOAD_LEGACY_TTY is set that uses the tty image. The tests themselves make assumptions that are wrong with both approaches.  I can go either way with it.","accounts_in_message":[],"_revision_number":1},{"id":"8e8e054dbdea20a0faac6254ba77d75bd893f55a","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2011-11-30 23:40:24.000000000","message":"Patch Set 1:\n\nIn stack.sh there no need to run a sub shell, or use cd, semi colons, or the line continuation chars.You can just:\n\nln -s $IMAGE_NAME-vmlinuz $FILES/images/kernel\nln -s $IMAGE_NAME.img $FILES/images/disk","accounts_in_message":[],"_revision_number":1},{"id":"a20a37475d8a199164cfcdfcb2788624e736cc13","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-01 21:17:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"835d6ce4780ff6437ef63f7c0cfc4c74aad8b643","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-02 00:09:40.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"0f8846fb92985525b8aa60a015c539ca5c2db9cb","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2011-12-09 17:26:53.000000000","message":"Patch Set 2:\n\nIt looks like this will only work if you first run stack.sh with the default image configuration.  Perhaps if the tty is not present as expected, we should error out and inform the user of the likely cause.","accounts_in_message":[],"_revision_number":2},{"id":"b5215f90f8ade82ee3b05ff3ffcecae1bc5415a8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-27 20:05:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"222d1f05774a428ecf29ff03bdf3736842981b46","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-27 20:07:04.000000000","message":"Patch Set 3:\n\nUpdated to handle all downloaded images; defaults to use the first one in the config file.","accounts_in_message":[],"_revision_number":3},{"id":"9260ba8a06f8f4e359ee671ad92b4bcd9e219f12","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2011-12-28 17:49:41.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nThe logic looks correct. I\u0027ve suggested an optional improvment","accounts_in_message":[],"_revision_number":3},{"id":"5a5794bcb3e63847eacfab01824340f3c30408fa","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-01-06 22:39:48.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a8a61d94199eb6f5b9b492c9ca1ddc8fb5df8f8b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-01-06 22:42:05.000000000","message":"Patch Set 4:\n\np-draigbrady: I re-worked the bottom of the loop a bit to hopefully make the intention clearer.  We want to set IMAGE_DIR to the value of imagedir for the first directory with a disk image link.  I removed the break so the symlinks get set for all image directories.","accounts_in_message":[],"_revision_number":4},{"id":"6756460b93f529738a9acdbc22b5292a98038023","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-01-19 12:06:40.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"dec3616222207517106865564c1dcb5cd9dbce38","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-01-24 19:32:25.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"ff9f719ef8648ce866f6a5260abf40d97c75b955","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-24 20:02:06.000000000","message":"Patch Set 4: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/785/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-devstack-merge/82/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"603184e9b0634ef03f40a376bb0d185235ba10f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-24 20:02:06.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"3320c55d10b65d370f1b91bde1bcbd4d78a6a5ca","revisions":{"8148eeb680f7e54ac8721724907c6d6e09113c1c":{"kind":"REWORK","_number":1,"created":"2011-11-24 06:20:29.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/93/1893/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/93/1893/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/93/1893/1"}}},"commit":{"parents":[{"commit":"44d8f8f826a962eabcd219316d9f5e9650a807c3","subject":"Check out integration tests and install prereqs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/44d8f8f826a962eabcd219316d9f5e9650a807c3"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-11-24 05:19:10.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-11-24 06:20:13.000000000","tz":-360},"subject":"Set up default images for testing","message":"Set up default images for testing\n\nChange-Id: Ia08d314e26fcf4a443b567432d0c36202d151c9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8148eeb680f7e54ac8721724907c6d6e09113c1c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8148eeb680f7e54ac8721724907c6d6e09113c1c"}]},"branch":"refs/heads/master"},"97782cea9ed45ce40979cc122abedb7ca80d22df":{"kind":"REWORK","_number":2,"created":"2011-12-01 21:17:15.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/93/1893/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/93/1893/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/93/1893/2"}}},"commit":{"parents":[{"commit":"4d4d96dd20482d0f6a0c09541f0c176e100152e3","subject":"Merge \"Fix glance config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4d4d96dd20482d0f6a0c09541f0c176e100152e3"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-11-24 05:19:10.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-01 21:15:47.000000000","tz":-360},"subject":"Set up default images for testing","message":"Set up default images for testing\n\nPatch 2: move image symlinking out of stack.sh\n\nChange-Id: Ia08d314e26fcf4a443b567432d0c36202d151c9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/97782cea9ed45ce40979cc122abedb7ca80d22df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/97782cea9ed45ce40979cc122abedb7ca80d22df"}]},"branch":"refs/heads/master"},"e5009e467e9486bb902ef382dbd0063a431ab4c4":{"kind":"REWORK","_number":3,"created":"2011-12-27 20:05:35.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/93/1893/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/93/1893/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/93/1893/3"}}},"commit":{"parents":[{"commit":"c1b2354a88f9d14c6773fe9f9fa06f918e37d8f8","subject":"Merge \"add adapters for exercises jenkins integration)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1b2354a88f9d14c6773fe9f9fa06f918e37d8f8"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-11-24 05:19:10.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-27 20:05:41.000000000","tz":-360},"subject":"Set up downloaded images for testing","message":"Set up downloaded images for testing\n\nChange-Id: Ia08d314e26fcf4a443b567432d0c36202d151c9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e5009e467e9486bb902ef382dbd0063a431ab4c4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e5009e467e9486bb902ef382dbd0063a431ab4c4"}]},"branch":"refs/heads/master"},"3320c55d10b65d370f1b91bde1bcbd4d78a6a5ca":{"kind":"REWORK","_number":4,"created":"2012-01-06 22:39:48.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/93/1893/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/93/1893/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/93/1893/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/93/1893/4"}}},"commit":{"parents":[{"commit":"f4497d5eb9b1d1457593515ff7a9f23d433ccba0","subject":"Merge \"Add info.sh\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f4497d5eb9b1d1457593515ff7a9f23d433ccba0"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-11-24 05:19:10.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-06 22:39:46.000000000","tz":-360},"subject":"Set up downloaded images for testing","message":"Set up downloaded images for testing\n\nChange-Id: Ia08d314e26fcf4a443b567432d0c36202d151c9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3320c55d10b65d370f1b91bde1bcbd4d78a6a5ca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3320c55d10b65d370f1b91bde1bcbd4d78a6a5ca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}