)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"eecd2f5b4f461b3dd0d3803c700340f0a995c821","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        neutron_fwaas_stop"},{"line_number":782,"context_line":"    fi"},{"line_number":783,"context_line":"    if is_service_enabled q-vpn; then"},{"line_number":784,"context_line":"        neutron_vpn_stop"},{"line_number":785,"context_line":"    fi"},{"line_number":786,"context_line":"    if is_service_enabled q-metering; then"},{"line_number":787,"context_line":"        neutron_metering_stop"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3afb71cf_aac88ba9","line":784,"updated":"2015-06-11 14:18:35.000000000","message":"do you want to move this to stop_neutron_l3_agent?","commit_id":"89412aa5b095f55bb344182e971c83da1d201c2c"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"07c74c084774161a208d4900e0ea7515a5098358","unresolved":false,"context_lines":[{"line_number":762,"context_line":""},{"line_number":763,"context_line":"function stop_neutron_l3_agent {"},{"line_number":764,"context_line":"    if is_service_enabled q-vpn; then"},{"line_number":765,"context_line":"        neutron_vpn_stop"},{"line_number":766,"context_line":"    else"},{"line_number":767,"context_line":"        stop_process q-l3"},{"line_number":768,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a50d1a3_15eb3bdd","line":765,"updated":"2015-07-29 05:00:42.000000000","message":"This seems like a change in logic from the previous patch (where q-l3 was stopped and q-vpn as well).\n\nCan you please explain why the if/else here?","commit_id":"04ceadfc1519881ef7b1a9d2b1727d6415245ca3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c673181873398084a655ba576b2960004a7c939e","unresolved":false,"context_lines":[{"line_number":731,"context_line":"function start_neutron_other_agents {"},{"line_number":732,"context_line":"    if is_service_enabled neutron-vpnaas; then"},{"line_number":733,"context_line":"        :  # Started by plugin"},{"line_number":734,"context_line":"    fi"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    run_process q-dhcp \"python $AGENT_DHCP_BINARY --config-file $NEUTRON_CONF --config-file\u003d$Q_DHCP_CONF_FILE\""},{"line_number":737,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da20952f_266776ea","line":734,"updated":"2015-09-04 06:43:35.000000000","message":"This logic must not be separated L724-728 otherwise regression to https://review.openstack.org/#/c/213228/","commit_id":"18dd5c83c6a32f27af756251022023f034e7383b"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"63706e44cbbfd3189ed5e9ad7ecdec6d4aad9898","unresolved":false,"context_lines":[{"line_number":731,"context_line":"function start_neutron_other_agents {"},{"line_number":732,"context_line":"    if is_service_enabled neutron-vpnaas; then"},{"line_number":733,"context_line":"        :  # Started by plugin"},{"line_number":734,"context_line":"    fi"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    run_process q-dhcp \"python $AGENT_DHCP_BINARY --config-file $NEUTRON_CONF --config-file\u003d$Q_DHCP_CONF_FILE\""},{"line_number":737,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da20952f_aadee00e","line":734,"in_reply_to":"da20952f_266776ea","updated":"2015-09-04 11:49:22.000000000","message":"thanks!  will fix.","commit_id":"18dd5c83c6a32f27af756251022023f034e7383b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"bb64b4f420a5fb1cd35d174e13f70de158b4159f","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        run_process q-vpn \"$AGENT_VPN_BINARY $(determine_config_files neutron-vpn-agent)\""},{"line_number":728,"context_line":"    else"},{"line_number":729,"context_line":"        run_process q-l3 \"python $AGENT_L3_BINARY $(determine_config_files neutron-l3-agent)\""},{"line_number":730,"context_line":"    fi"},{"line_number":731,"context_line":"}"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"function start_neutron_other_agents {"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da20952f_26374d00","line":730,"updated":"2015-09-05 07:26:30.000000000","message":"I think the metadata agent should also be started along side the l3 agent.","commit_id":"9426ff2136cde8077d57d627537841724bc30c86"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fef8b8be8378119dea1300d7599ed9250acdaf58","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        run_process q-vpn \"$AGENT_VPN_BINARY $(determine_config_files neutron-vpn-agent)\""},{"line_number":728,"context_line":"    else"},{"line_number":729,"context_line":"        run_process q-l3 \"python $AGENT_L3_BINARY $(determine_config_files neutron-l3-agent)\""},{"line_number":730,"context_line":"    fi"},{"line_number":731,"context_line":"}"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"function start_neutron_other_agents {"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_ae12dcb2","line":730,"in_reply_to":"da20952f_26374d00","updated":"2015-09-25 17:09:27.000000000","message":"that wasn\u0027t the intention of this patch.  It was only for the l3 agent ...","commit_id":"9426ff2136cde8077d57d627537841724bc30c86"}]}