)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a3d814467fe3437e491423db8316c9e92d5edcf6","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"function service_status {"},{"line_number":1921,"context_line":"    local rc\u003d1"},{"line_number":1922,"context_line":"    if is_ubuntu; then"},{"line_number":1923,"context_line":"        sudo /usr/sbin/service $1 status \u003e /dev/null 2\u003e\u00261"},{"line_number":1924,"context_line":"        rc\u003d$?"},{"line_number":1925,"context_line":"    else"},{"line_number":1926,"context_line":"        sudo /sbin/service $1 status \u003e /dev/null 2\u003e\u00261"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a41bdd9_eed4f320","line":1923,"updated":"2015-07-15 01:17:06.000000000","message":"this isn\u0027t safe to run under errexit ... i think having\n\n  if service status; then\n    return\n  fi\n\nis probably better","commit_id":"8cf81d511d6cd43843d8220234fc2ea0753e22e4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"51b7e27a40afbb7a87a4410418c5c7a80b902695","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"function service_status {"},{"line_number":1921,"context_line":"    local rc\u003d1"},{"line_number":1922,"context_line":"    if is_ubuntu; then"},{"line_number":1923,"context_line":"        sudo /usr/sbin/service $1 status \u003e /dev/null 2\u003e\u00261"},{"line_number":1924,"context_line":"        rc\u003d$?"},{"line_number":1925,"context_line":"    else"},{"line_number":1926,"context_line":"        sudo /sbin/service $1 status \u003e /dev/null 2\u003e\u00261"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a50d1a3_90fde43d","line":1923,"in_reply_to":"3a50d1a3_62e3f9a4","updated":"2015-07-30 00:47:18.000000000","message":"because under errexit (-e) that command will return -1 and the script will halt at that point, so it negates the checking being done","commit_id":"8cf81d511d6cd43843d8220234fc2ea0753e22e4"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"7df4082644ddef1fff48af1d7bbbc05bda33de09","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"function service_status {"},{"line_number":1921,"context_line":"    local rc\u003d1"},{"line_number":1922,"context_line":"    if is_ubuntu; then"},{"line_number":1923,"context_line":"        sudo /usr/sbin/service $1 status \u003e /dev/null 2\u003e\u00261"},{"line_number":1924,"context_line":"        rc\u003d$?"},{"line_number":1925,"context_line":"    else"},{"line_number":1926,"context_line":"        sudo /sbin/service $1 status \u003e /dev/null 2\u003e\u00261"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a50d1a3_fb617da9","line":1923,"in_reply_to":"3a50d1a3_90fde43d","updated":"2015-07-30 20:34:45.000000000","message":"I tested it and the status always return 0 or 1 depending on the error code and sudo passes that error code to $? ... when will we see -1 ?","commit_id":"8cf81d511d6cd43843d8220234fc2ea0753e22e4"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"6b18045a8f6f09d373a3a995b0fde6bd486404d0","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"function service_status {"},{"line_number":1921,"context_line":"    local rc\u003d1"},{"line_number":1922,"context_line":"    if is_ubuntu; then"},{"line_number":1923,"context_line":"        sudo /usr/sbin/service $1 status \u003e /dev/null 2\u003e\u00261"},{"line_number":1924,"context_line":"        rc\u003d$?"},{"line_number":1925,"context_line":"    else"},{"line_number":1926,"context_line":"        sudo /sbin/service $1 status \u003e /dev/null 2\u003e\u00261"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a50d1a3_62e3f9a4","line":1923,"in_reply_to":"9a41bdd9_eed4f320","updated":"2015-07-22 19:59:44.000000000","message":"Why is that not safe?","commit_id":"8cf81d511d6cd43843d8220234fc2ea0753e22e4"}],"lib/rpc_backend":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1bff3e7b6510f1a437f7a1fc6a42b4a9ce183c91","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa32b979_19962af0","line":211,"updated":"2015-06-24 13:49:35.000000000","message":"If this in only for Vivid you should say so in a code comment. or surround this by a if [[ $running_vivid ]]; then","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7bc03f1368d4f7812afde8cf7e181cdacbfeac27","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_8da82979","line":211,"in_reply_to":"ba3cc151_3aacb8ec","updated":"2015-07-07 00:57:32.000000000","message":"so the sequence is roughly\n\n restart rabbitmq\n add user -\u003e fails\n restart rabbitmq -\u003e fails because not running yet?\n\nrabbitmq-server is execed to whatever erlang stuff is, so that pgrep doesn\u0027t match anything on fedora at least.  is it different on ubuntu?","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"305457120c15243bfee4103255a6057baad1b0b9","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_3aacb8ec","line":211,"in_reply_to":"ba3cc151_4de80c17","updated":"2015-07-06 20:19:52.000000000","message":"Well, there\u0027re no needs to restart rabbitmq if it\u0027s already running.  This seems to be breaking up under vivid installation as the server will be restarted every X seconds or so while trying to set the user... and this fails lamentably because the rabbitmq server isn\u0027t running.  The patch only start rabbitmq if it\u0027s not already running and for all vivid devstack installation I\u0027ve tested so far it worked and in the bug report, another guy confirmed it fixed the problem for him.  So Vivid or not, I doubt that restarting rabbitmq server for no valid reasons is the best way to go around this bug.","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"326e9940ed11f48027dbc6dab48c0f924f4016c0","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_1b78b0c3","line":211,"in_reply_to":"ba3cc151_8da82979","updated":"2015-07-07 15:01:22.000000000","message":"I patched the code in order to get the full command-line instead of the process name... I wonder why the pgrep behaviour is not the same ... but this should solve it for everybody.","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"abfa8a74ed48c1a98dc153783d8577173aa88342","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_de06b61f","line":211,"in_reply_to":"ba3cc151_8da82979","updated":"2015-07-07 16:01:12.000000000","message":"Ian ?  I was wondering, do you have this issue ?  Because I fixed it having in mind that only vivid was affected by this restart issue but if you have the same bug, then it doesn\u0027t affect only vivid and perhaps more work will have to be done in order to address this issue.   If Fedora isn\u0027t using the same version of rabbitmq-server with the same launching method (shell script called rabbitmq-server) , then the prep will fail for this and would need to be fixed using some case checks ...","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"39c786c556f7de163fe75dc0d696f61f99c41f6e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_3e91e252","line":211,"in_reply_to":"ba3cc151_8da82979","updated":"2015-07-07 15:11:38.000000000","message":"Which version of fedora are you using?\n\nWhich ubuntu , I have the following process:\n\nrabbitmq 15276  0.0  0.0   4472   628 ?        Ss   03:21   0:00 /bin/sh /usr/sbin/rabbitmq-server","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a0e6f42aea7ceba0c768e6570608eaec26b5137f","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_4de80c17","line":211,"in_reply_to":"ba3cc151_e929edf3","updated":"2015-07-06 08:14:56.000000000","message":"No it doesn\"t. But you can check in the source code how to properly detect if running vivid.","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"2b77db2113d35ebb1a0b68cfaed9924e6be65f06","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            [[ $i -eq \"20\" ]] \u0026\u0026 die $LINENO \"Failed to set rabbitmq password\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            if [[ $(( i % 2 )) \u003d\u003d \"0\" ]] ; then"},{"line_number":211,"context_line":"                if ! $(pgrep -c rabbitmq-server 1\u003e/dev/null ); then"},{"line_number":212,"context_line":"                    restart_service rabbitmq-server"},{"line_number":213,"context_line":"                fi"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_e929edf3","line":211,"in_reply_to":"fa32b979_19962af0","updated":"2015-07-03 18:34:52.000000000","message":"running_vivid doesn\u0027t exist does it?","commit_id":"523251dcf60ae780e8c8279ddd68ae2a828eb583"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a3d814467fe3437e491423db8316c9e92d5edcf6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    local rc\u003d1"},{"line_number":57,"context_line":"    if is_ubuntu; then"},{"line_number":58,"context_line":"        sudo /usr/sbin/rabbitmqctl status \u003e /dev/null 2\u003e\u00261"},{"line_number":59,"context_line":"        rc\u003d$?"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"        sudo /sbin/rabbitmqctl status \u003e /dev/null 2\u003e\u00261"},{"line_number":62,"context_line":"        rc\u003d$?"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a41bdd9_cedfaf38","line":59,"updated":"2015-07-15 01:17:06.000000000","message":"similar errexit concerns","commit_id":"8cf81d511d6cd43843d8220234fc2ea0753e22e4"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"6b18045a8f6f09d373a3a995b0fde6bd486404d0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    local rc\u003d1"},{"line_number":57,"context_line":"    if is_ubuntu; then"},{"line_number":58,"context_line":"        sudo /usr/sbin/rabbitmqctl status \u003e /dev/null 2\u003e\u00261"},{"line_number":59,"context_line":"        rc\u003d$?"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"        sudo /sbin/rabbitmqctl status \u003e /dev/null 2\u003e\u00261"},{"line_number":62,"context_line":"        rc\u003d$?"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a50d1a3_c253ed69","line":59,"in_reply_to":"9a41bdd9_cedfaf38","updated":"2015-07-22 19:59:44.000000000","message":"Why is that not safe?","commit_id":"8cf81d511d6cd43843d8220234fc2ea0753e22e4"}]}