)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f35e9eb2f333457ed6fd07f35c91ad9ee0114b90","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running in httpd, keystone accepts requests on /identity and"},{"line_number":10,"context_line":"/identity_admin. These endpoints should be preferred."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I34569b9e03c3f36748c92d803349e22a7ee1a633"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a7e1126_a2570d01","line":11,"updated":"2015-12-17 21:21:08.000000000","message":"Add Depends-On: I43cd923e54c990311595bc2636a1a4d5ea159a88","commit_id":"8195f4aec606b7d8c588e1d6afe84f559131a811"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1ba52f5d7a249cbc9eca7e07801f52c567b0a2db","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When running in httpd, keystone accepts requests on /identity and"},{"line_number":10,"context_line":"/identity_admin. These endpoints should be preferred."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Idb5f8ad9290569cf559bd2141b82075e6e0d6091"},{"line_number":13,"context_line":"Change-Id: I34569b9e03c3f36748c92d803349e22a7ee1a633"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1af94dfe_3ee38eda","line":12,"updated":"2016-03-18 19:31:50.000000000","message":"Try I0d24f83ea3243b8eeee50f8bfec28326be7c7292 next","commit_id":"be8fc1a8d170dbc0b3ee273c908098511e4a45c9"}],"lib/keystone":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e67a92205070388da0033d45aa1c56305af0c58d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        s|%KEYSTONE_BIN%|$KEYSTONE_BIN_DIR|g"},{"line_number":174,"context_line":"    \" -i $keystone_apache_conf"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    iniset $KEYSTONE_CONF DEFAULT public_endpoint $KEYSTONE_SERVICE_URI"},{"line_number":177,"context_line":"    iniset $KEYSTONE_CONF DEFAULT admin_endpoint $KEYSTONE_AUTH_URI"},{"line_number":178,"context_line":"}"},{"line_number":179,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a710552_ef4c7078","line":176,"updated":"2015-12-14 20:39:34.000000000","message":"Should be able to get rid of this once https://review.openstack.org/#/c/226464/ merges in keystone.","commit_id":"283b6a50d9f8953d4d4f706cec2c9db6583401a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"96eccac9a0f71679d8c9835fdcbbfdc3650bb809","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        s|%KEYSTONE_BIN%|$KEYSTONE_BIN_DIR|g"},{"line_number":174,"context_line":"    \" -i $keystone_apache_conf"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    iniset $KEYSTONE_CONF DEFAULT public_endpoint $KEYSTONE_SERVICE_URI"},{"line_number":177,"context_line":"    iniset $KEYSTONE_CONF DEFAULT admin_endpoint $KEYSTONE_AUTH_URI"},{"line_number":178,"context_line":"}"},{"line_number":179,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a710552_ca1f225a","line":176,"in_reply_to":"5a710552_ef4c7078","updated":"2015-12-14 21:01:16.000000000","message":"Actually, I think it\u0027s better to leave this here until we stop accepting on the port, too, because then if you go to the port you get \"redirected\" to the correct path-mounted endpoint.","commit_id":"283b6a50d9f8953d4d4f706cec2c9db6583401a1"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"71c798d8178322102d0258588ab16b4d1145909b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"if [ \"$KEYSTONE_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":107,"context_line":"    # If running in Apache, use path access rather than port."},{"line_number":108,"context_line":"    KEYSTONE_AUTH_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}/identity_admin"},{"line_number":109,"context_line":"    KEYSTONE_SERVICE_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}/identity"},{"line_number":110,"context_line":"else"},{"line_number":111,"context_line":"    KEYSTONE_AUTH_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}:${KEYSTONE_AUTH_PORT}"},{"line_number":112,"context_line":"    KEYSTONE_SERVICE_URI\u003d${KEYSTONE_SERVICE_PROTOCOL}://${KEYSTONE_SERVICE_HOST}:${KEYSTONE_SERVICE_PORT}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"7a5de9d1_46001502","line":109,"range":{"start_line":109,"start_character":55,"end_line":109,"end_character":73},"updated":"2016-02-02 08:22:03.000000000","message":"Shoudn\u0027t this be KEYSTONE_SERVICE_HOST?","commit_id":"43e6e9b807e4fd37b8e16851435e65ceb25be888"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"71c798d8178322102d0258588ab16b4d1145909b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"if [ \"$KEYSTONE_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":107,"context_line":"    # If running in Apache, use path access rather than port."},{"line_number":108,"context_line":"    KEYSTONE_AUTH_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}/identity_admin"},{"line_number":109,"context_line":"    KEYSTONE_SERVICE_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}/identity"},{"line_number":110,"context_line":"else"},{"line_number":111,"context_line":"    KEYSTONE_AUTH_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}:${KEYSTONE_AUTH_PORT}"},{"line_number":112,"context_line":"    KEYSTONE_SERVICE_URI\u003d${KEYSTONE_SERVICE_PROTOCOL}://${KEYSTONE_SERVICE_HOST}:${KEYSTONE_SERVICE_PORT}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"7a5de9d1_4629f599","line":109,"range":{"start_line":109,"start_character":27,"end_line":109,"end_character":49},"updated":"2016-02-02 08:22:03.000000000","message":"Shouldn\u0027t this be KEYSTONE_SERVICE_PROTOCOL?","commit_id":"43e6e9b807e4fd37b8e16851435e65ceb25be888"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a3834cba6f5ea28510c2fd097933b05bbb563617","unresolved":false,"context_lines":[{"line_number":106,"context_line":"if [ \"$KEYSTONE_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":107,"context_line":"    # If running in Apache, use path access rather than port."},{"line_number":108,"context_line":"    KEYSTONE_AUTH_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}/identity_admin"},{"line_number":109,"context_line":"    KEYSTONE_SERVICE_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}/identity"},{"line_number":110,"context_line":"else"},{"line_number":111,"context_line":"    KEYSTONE_AUTH_URI\u003d${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_AUTH_HOST}:${KEYSTONE_AUTH_PORT}"},{"line_number":112,"context_line":"    KEYSTONE_SERVICE_URI\u003d${KEYSTONE_SERVICE_PROTOCOL}://${KEYSTONE_SERVICE_HOST}:${KEYSTONE_SERVICE_PORT}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3a57f1b5_26ea28dc","line":109,"range":{"start_line":109,"start_character":27,"end_line":109,"end_character":49},"in_reply_to":"7a5de9d1_4629f599","updated":"2016-02-11 22:39:13.000000000","message":"Done","commit_id":"43e6e9b807e4fd37b8e16851435e65ceb25be888"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"71c798d8178322102d0258588ab16b4d1145909b","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    local service_uri\u003d$auth_protocol://$KEYSTONE_SERVICE_HOST:$service_port/v$IDENTITY_API_VERSION/"},{"line_number":563,"context_line":"    if [ \"$KEYSTONE_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":564,"context_line":"        service_uri\u003d$auth_protocol://$KEYSTONE_SERVICE_HOST/identity/v$IDENTITY_API_VERSION/"},{"line_number":565,"context_line":"    fi"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    if ! wait_for_service $SERVICE_TIMEOUT $service_uri; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"7a5de9d1_8194b78a","line":564,"range":{"start_line":564,"start_character":20,"end_line":564,"end_character":68},"updated":"2016-02-02 08:22:03.000000000","message":"Isn\u0027t this equal to $KEYSTONE_SERVICE_URI?","commit_id":"43e6e9b807e4fd37b8e16851435e65ceb25be888"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a3834cba6f5ea28510c2fd097933b05bbb563617","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    local service_uri\u003d$auth_protocol://$KEYSTONE_SERVICE_HOST:$service_port/v$IDENTITY_API_VERSION/"},{"line_number":563,"context_line":"    if [ \"$KEYSTONE_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":564,"context_line":"        service_uri\u003d$auth_protocol://$KEYSTONE_SERVICE_HOST/identity/v$IDENTITY_API_VERSION/"},{"line_number":565,"context_line":"    fi"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    if ! wait_for_service $SERVICE_TIMEOUT $service_uri; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3a57f1b5_2698e877","line":564,"range":{"start_line":564,"start_character":20,"end_line":564,"end_character":68},"in_reply_to":"7a5de9d1_8194b78a","updated":"2016-02-11 22:39:13.000000000","message":"It\u0027s not, because KEYSTONE_SERVICE_URI uses {KEYSTONE_SERVICE_PROTOCOL} whereas this uses $auth_protocol which is set above.\n\nThere\u0027s probably a bug here but I\u0027m not trying to fix that in this patch.","commit_id":"43e6e9b807e4fd37b8e16851435e65ceb25be888"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"b256066bea25ffb5542d74fad4e809ff6de2dde2","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    get_or_create_endpoint \\"},{"line_number":679,"context_line":"        \"identity\" \\"},{"line_number":680,"context_line":"        \"$REGION_NAME\" \\"},{"line_number":681,"context_line":"        \"$KEYSTONE_SERVICE_URI/v$IDENTITY_API_VERSION\"\" \\"},{"line_number":682,"context_line":"        \"$KEYSTONE_AUTH_URI/v$IDENTITY_API_VERSION\" \\"},{"line_number":683,"context_line":"        \"$KEYSTONE_SERVICE_URI/v$IDENTITY_API_VERSION\""},{"line_number":684,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_51fd85af","line":681,"range":{"start_line":681,"start_character":54,"end_line":681,"end_character":55},"updated":"2016-02-24 16:44:11.000000000","message":"I think there is new syntax error here.","commit_id":"4bfa97432dae0eedce02e9153e49152f7d56a63a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a44d5580cf0172e273280a1c4e855963a68ec32d","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    get_or_create_endpoint \\"},{"line_number":679,"context_line":"        \"identity\" \\"},{"line_number":680,"context_line":"        \"$REGION_NAME\" \\"},{"line_number":681,"context_line":"        \"$KEYSTONE_SERVICE_URI/v$IDENTITY_API_VERSION\"\" \\"},{"line_number":682,"context_line":"        \"$KEYSTONE_AUTH_URI/v$IDENTITY_API_VERSION\" \\"},{"line_number":683,"context_line":"        \"$KEYSTONE_SERVICE_URI/v$IDENTITY_API_VERSION\""},{"line_number":684,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_5148e5b2","line":681,"range":{"start_line":681,"start_character":54,"end_line":681,"end_character":55},"in_reply_to":"bae84128_51fd85af","updated":"2016-02-24 16:50:02.000000000","message":"Done","commit_id":"4bfa97432dae0eedce02e9153e49152f7d56a63a"}]}