)]}'
{"lib/ironic":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ece81ba6c3a6802d2dbac0c499985a769b19a7ce","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    fi"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":663,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_HTTP_PORT -j ACCEPT || true"},{"line_number":664,"context_line":"    fi"},{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa32b979_97877ab4","line":663,"updated":"2015-06-24 03:41:34.000000000","message":"i know you probably just copied, but what\u0027s the reason for ignoring the return code?  it seems like useful information to stop there if it fails","commit_id":"365d11dfa9fec3b1025c14e38ad3a66f8c79a148"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ea44edba40fe5b7c70212a2cbb82fc7950a39878","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    fi"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":663,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_HTTP_PORT -j ACCEPT || true"},{"line_number":664,"context_line":"    fi"},{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_2ca243af","line":663,"in_reply_to":"fa32b979_2b996279","updated":"2015-06-30 10:35:47.000000000","message":"we don\u0027t support firewalld at all -- neutron doesn\u0027t work with it and it has caused a bunch of problems before (see tools/fixup_stuff.sh)\n\nfor consistency ok","commit_id":"365d11dfa9fec3b1025c14e38ad3a66f8c79a148"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"aad8d41a636522f6b1e90ce26f6c79fcd6befef2","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    fi"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":663,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_HTTP_PORT -j ACCEPT || true"},{"line_number":664,"context_line":"    fi"},{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa32b979_2b996279","line":663,"in_reply_to":"fa32b979_97877ab4","updated":"2015-06-24 08:11:20.000000000","message":"Hi Ian,\n\nI believe the idea behind ignoring the return code is so that one could disable iptables if he/she wants to. Failing devstack because iptables is not enabled is not great. (Especially in distros where the default is firewalld and not iptables)","commit_id":"365d11dfa9fec3b1025c14e38ad3a66f8c79a148"}]}