)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c43fed08ef38b28a28d7052e97f0136b5895ff59","unresolved":false,"context_lines":[{"line_number":949,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":950,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":951,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT root_helper \"$Q_RR_COMMAND\""},{"line_number":952,"context_line":"    dns\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":953,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT dnsmasq_dns_servers \"$dns\""},{"line_number":954,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" \u003d\u003d \"True\" ]]; then"},{"line_number":955,"context_line":"        iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_d82b5c81","line":952,"updated":"2015-06-30 05:07:07.000000000","message":"this should be a local, or better still you can just put it in directly as the third argument\n\nalthough, i also see this as being a sensible default but maybe you want to give people an argument to override it?  this does seem like a case where just leaving it up to localrc isn\u0027t in the users best interest","commit_id":"4fbc444ceb39cbc51def9f80de63d081af08bdf5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4ea985c843e45190ea2e8e1d9fd3f94e3b1ce82e","unresolved":false,"context_lines":[{"line_number":949,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":950,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":951,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT root_helper \"$Q_RR_COMMAND\""},{"line_number":952,"context_line":"    dns\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":953,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT dnsmasq_dns_servers \"$dns\""},{"line_number":954,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" \u003d\u003d \"True\" ]]; then"},{"line_number":955,"context_line":"        iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa32b979_3732caf3","line":952,"updated":"2015-06-25 21:24:40.000000000","message":"you could use tr","commit_id":"4fbc444ceb39cbc51def9f80de63d081af08bdf5"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"9f5a73472008afb7f18f6fc7b60b298c47bb6deb","unresolved":false,"context_lines":[{"line_number":949,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":950,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":951,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT root_helper \"$Q_RR_COMMAND\""},{"line_number":952,"context_line":"    dns\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":953,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT dnsmasq_dns_servers \"$dns\""},{"line_number":954,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" \u003d\u003d \"True\" ]]; then"},{"line_number":955,"context_line":"        iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_64d29002","line":952,"in_reply_to":"ba3cc151_53b5d42e","updated":"2015-06-30 16:21:22.000000000","message":"I agree that an env var would be handy. Replacing config files is more of a power user thing, and setting your DNS is a pretty basic setting.\nThis begs the question of whether support should also be added for nova-net, but I\u0027m going to start with adjusting for content and style as suggested (n-net that might be a follow-on patch.)","commit_id":"4fbc444ceb39cbc51def9f80de63d081af08bdf5"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b7e55bf16d9776d9cb81248bf4be05a55e710c0d","unresolved":false,"context_lines":[{"line_number":949,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":950,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":951,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT root_helper \"$Q_RR_COMMAND\""},{"line_number":952,"context_line":"    dns\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":953,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT dnsmasq_dns_servers \"$dns\""},{"line_number":954,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" \u003d\u003d \"True\" ]]; then"},{"line_number":955,"context_line":"        iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_53b5d42e","line":952,"in_reply_to":"ba3cc151_ca292d39","updated":"2015-06-30 15:43:03.000000000","message":"I agree with Ian.\n\n@Sean Why do you think so? We created it so that users could do, didn\u0027t us? I was able to set it in my environments.\n\nAnyway \"dns\" must be changed according to devstack style.\n\ne.g.\n DNS_SERVERS\u003d${DNS_SERVERS:-}\n if [[ \"$DNS_SERVERS\" \u003d\u003d \u0027\u0027 ]]; then\n   DNS_SERVERS\u003d*******\n fi","commit_id":"4fbc444ceb39cbc51def9f80de63d081af08bdf5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"dc08cb60c00e4710a97e643ed70255efea1ed365","unresolved":false,"context_lines":[{"line_number":949,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":950,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":951,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT root_helper \"$Q_RR_COMMAND\""},{"line_number":952,"context_line":"    dns\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":953,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT dnsmasq_dns_servers \"$dns\""},{"line_number":954,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" \u003d\u003d \"True\" ]]; then"},{"line_number":955,"context_line":"        iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba3cc151_ca292d39","line":952,"in_reply_to":"ba3cc151_d82b5c81","updated":"2015-06-30 14:54:17.000000000","message":"Couldn\u0027t people override it by having a $Q_DHCP_CONF_FILE section in their local.conf?","commit_id":"4fbc444ceb39cbc51def9f80de63d081af08bdf5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a01ed6996697bdbf8d5cd3cbca54e02cd491631a","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    # TODO(dougwig) - Move this to a higher-level and consider support"},{"line_number":947,"context_line":"    # for nova-net"},{"line_number":948,"context_line":"    DNS_SERVERS\u003d${DNS_SERVERS:-}"},{"line_number":949,"context_line":"    if [[ \"$DNS_SERVERS\" \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":950,"context_line":"\tDNS_SERVERS\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":951,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_963d7fbd","line":948,"updated":"2015-06-30 19:38:58.000000000","message":"I think we should namespace this a bit more tightly ... GUEST_DNS_SERVERS, something like that?\n\nas a global, it should go at the top.  you can also just ${DNS_SERVERS:-$(foo)}\n\n awk \u0027/^nameserver/{print $2}\u0027 /etc/resolv.conf | paste -sd,\n\nshould work and be a bit shorter for that case","commit_id":"7495b1755914a9080ab13eb5ddd2ae9e1dd32fad"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"50588916c244eb2ae69e0295e0cbb3a85dd47894","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    # TODO(dougwig) - Move this to a higher-level and consider support"},{"line_number":947,"context_line":"    # for nova-net"},{"line_number":948,"context_line":"    DNS_SERVERS\u003d${DNS_SERVERS:-}"},{"line_number":949,"context_line":"    if [[ \"$DNS_SERVERS\" \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":950,"context_line":"\tDNS_SERVERS\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":951,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_3a0ed53b","line":948,"in_reply_to":"ba3cc151_963d7fbd","updated":"2015-06-30 20:37:29.000000000","message":"+1, I like Ian\u0027s idea on the variable name and it\u0027s place in the devstack namespace.","commit_id":"7495b1755914a9080ab13eb5ddd2ae9e1dd32fad"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"5b1654f06f7351d3e9e6a60baff6634509778d2c","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    # TODO(dougwig) - Move this to a higher-level and consider support"},{"line_number":947,"context_line":"    # for nova-net"},{"line_number":948,"context_line":"    DNS_SERVERS\u003d${DNS_SERVERS:-}"},{"line_number":949,"context_line":"    if [[ \"$DNS_SERVERS\" \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":950,"context_line":"\tDNS_SERVERS\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":951,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_bd273fb5","line":948,"in_reply_to":"ba3cc151_963d7fbd","updated":"2015-06-30 20:38:06.000000000","message":"Done","commit_id":"7495b1755914a9080ab13eb5ddd2ae9e1dd32fad"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a01ed6996697bdbf8d5cd3cbca54e02cd491631a","unresolved":false,"context_lines":[{"line_number":947,"context_line":"    # for nova-net"},{"line_number":948,"context_line":"    DNS_SERVERS\u003d${DNS_SERVERS:-}"},{"line_number":949,"context_line":"    if [[ \"$DNS_SERVERS\" \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":950,"context_line":"\tDNS_SERVERS\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":951,"context_line":"    fi"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    cp $NEUTRON_DIR/etc/dhcp_agent.ini $Q_DHCP_CONF_FILE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_5647f74a","line":950,"updated":"2015-06-30 19:38:58.000000000","message":"stray tab","commit_id":"7495b1755914a9080ab13eb5ddd2ae9e1dd32fad"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"5b1654f06f7351d3e9e6a60baff6634509778d2c","unresolved":false,"context_lines":[{"line_number":947,"context_line":"    # for nova-net"},{"line_number":948,"context_line":"    DNS_SERVERS\u003d${DNS_SERVERS:-}"},{"line_number":949,"context_line":"    if [[ \"$DNS_SERVERS\" \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":950,"context_line":"\tDNS_SERVERS\u003d$(grep ^nameserver /etc/resolv.conf  | awk \u0027{print $2}\u0027 | paste -d, -s -)"},{"line_number":951,"context_line":"    fi"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    cp $NEUTRON_DIR/etc/dhcp_agent.ini $Q_DHCP_CONF_FILE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_1d1aeb6e","line":950,"in_reply_to":"ba3cc151_5647f74a","updated":"2015-06-30 20:38:06.000000000","message":"gone","commit_id":"7495b1755914a9080ab13eb5ddd2ae9e1dd32fad"}]}