)]}'
{"id":"openstack%2Fdevstack~196050","triplet_id":"openstack%2Fdevstack~master~I659ec9b9b2b49690fd075f9766ae8cbf19e81848","project":"openstack/devstack","branch":"master","topic":"bug/1469160","hashtags":[],"change_id":"I659ec9b9b2b49690fd075f9766ae8cbf19e81848","subject":"Drop no longer needed and broken check for cinder in is_service_enabled","status":"MERGED","created":"2015-06-26 13:22:03.000000000","updated":"2015-06-30 16:55:33.000000000","submitted":"2015-06-30 16:55:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"218f03501ac03b171aba39ad53a25013c21dbbc9","_number":196050,"virtual_id_number":196050,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-06-26 14:21:45.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-06-30 16:55:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2015-06-26 14:31:26.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":2,"date":"2015-06-30 15:53:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2015-06-30 05:42:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-06-26 13:23:41.000000000","_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":1,"date":"2015-06-30 15:53:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-26 13:23:41.000000000","updated_by":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"reviewer":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"state":"REVIEWER"},{"updated":"2015-06-26 14:21:45.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-06-30 05:42:12.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-06-30 15:53:48.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-06-30 16:55:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fdee4efd3cc9b08ab0a70d947a3c6fbbc74c6002","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-26 13:22:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9196cbd99a7d6140a8bea6f725182ae1934ab1e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 14:20:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-full/b2ebe60/ : SUCCESS in 42m 44s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-postgres-full/b2e8530/ : SUCCESS in 33m 06s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-full/4142680/ : SUCCESS in 55m 58s\n- check-grenade-dsvm http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm/fa8a77e/ : SUCCESS in 38m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-large-ops/1395fec/ : SUCCESS in 25m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-neutron-large-ops/93693c3/ : SUCCESS in 26m 27s\n- gate-devstack-bashate http://logs.openstack.org/50/196050/1/check/gate-devstack-bashate/03c5e43/ : SUCCESS in 21s\n- gate-devstack-unit-tests http://logs.openstack.org/50/196050/1/check/gate-devstack-unit-tests/1e08dae/ : SUCCESS in 20s\n- check-devstack-dsvm-cells http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-cells/24d1291/ : SUCCESS in 19m 41s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-partial-ncpu/50ac61c/ : SUCCESS in 41m 02s\n- check-swift-dsvm-functional http://logs.openstack.org/50/196050/1/check/check-swift-dsvm-functional/7e05b03/ : FAILURE in 48m 11s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-ironic-pxe_ssh/0bf6f36/ : SUCCESS in 32m 16s\n- check-devstack-dsvm-updown http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-updown/41c7fa4/ : SUCCESS in 19m 27s\n- check-tempest-dsvm-f21 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-f21/aef958e/ : FAILURE in 45m 28s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-centos7/5c57e29/ : FAILURE in 24m 48s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/50/196050/1/check/gate-devstack-publish-docs/377fa26//doc/build/html/ : SUCCESS in 1m 52s\n- check-grenade-dsvm-neutron http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-neutron/041da03/ : SUCCESS in 50m 50s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-multinode-smoke/c52504c/ : SUCCESS in 26m 23s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-multinode-smoke/8d8d190/ : SUCCESS in 29m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4b528485010e20bb0b26e5cdb90f246e66a2e5dc","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-06-26 14:21:45.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/50/196050/1/2436/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"a7bebbd987170dcbb0181a88dc4a32ddca0369cb","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-26 14:31:26.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"b1e91a704957ffbedb5b3217a14bb6eb6ba055e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 15:36:48.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-full/7dfc3b7/ : SUCCESS in 45m 13s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-postgres-full/91ced78/ : SUCCESS in 40m 13s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-full/f731302/ : SUCCESS in 1h 03m 24s\n- check-grenade-dsvm http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm/e54b36b/ : SUCCESS in 42m 07s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-large-ops/8bf064e/ : SUCCESS in 34m 54s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-neutron-large-ops/fcf2062/ : SUCCESS in 30m 29s\n- gate-devstack-bashate http://logs.openstack.org/50/196050/1/check/gate-devstack-bashate/66b1849/ : SUCCESS in 13m 09s\n- gate-devstack-unit-tests http://logs.openstack.org/50/196050/1/check/gate-devstack-unit-tests/a2a6270/ : SUCCESS in 13m 07s\n- check-devstack-dsvm-cells http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-cells/d8e3e7b/ : SUCCESS in 45m 22s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-partial-ncpu/26d1caa/ : SUCCESS in 51m 52s\n- check-swift-dsvm-functional http://logs.openstack.org/50/196050/1/check/check-swift-dsvm-functional/c554386/ : FAILURE in 59m 15s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-ironic-pxe_ssh/cfbea1e/ : FAILURE in 1m 49s\n- check-devstack-dsvm-updown http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-updown/6c95b82/ : FAILURE in 2m 13s\n- check-tempest-dsvm-f21 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-f21/7911d0e/ : FAILURE in 56m 17s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-centos7/06d9b99/ : FAILURE in 37m 36s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/50/196050/1/check/gate-devstack-publish-docs/0cb1329//doc/build/html/ : SUCCESS in 3m 53s\n- check-grenade-dsvm-neutron http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-neutron/534aaa1/ : FAILURE in 2m 07s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-multinode-smoke/0dc9df1/ : FAILURE in 1m 21s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-multinode-smoke/fe2c20d/ : FAILURE in 1m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"893b304e41a04aa50a862e65be84d67eaaed93c2","author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"date":"2015-06-27 05:24:27.000000000","message":"Patch Set 1:\n\nDmitry, thank you for the patch. But as I wrote in  https://review.openstack.org/#/c/195967/ , I don\u0027t understand why Cinder cause problem in our gate test. \n\nAnd it\u0027s just my feeling, but dropping cinder\u0027s is_service_enabled will give a huge impact to many people, and I think we should not trouble or give an impact to people outside of Ironic/Ironic Inspector.\n\nSo that, I cannot +1 until we can find out the true reason...\n\nThank you for working on this problem together!","accounts_in_message":[],"_revision_number":1},{"id":"8d8e15de44fb996bef6d8dabcf8f8db912847fa5","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-27 19:42:38.000000000","message":"Patch Set 1:\n\n1. Please have a look at the failure log. It clearly shows Cinder trying to start and failing.\n\n2. I\u0027m not removing is_service_enabled for Cinder. These lines are workarounds, and are not actually used. The primary is_cinder_enabled just works.","accounts_in_message":[],"_revision_number":1},{"id":"e5e0239b49bf6845eac57a3ba79c171295858e57","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-27 19:45:32.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"c79eaa91b35da1e742bb9a329917f1852ef9f7b5","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-27 19:46:08.000000000","message":"Patch Set 1:\n\n@Yuiko, this is log invloved: http://logs.openstack.org/31/174231/12/check/check-ironic-inspector-dsvm-nv/f365610/logs/devstacklog.txt.gz have a look at the end. Note that we don\u0027t have Cinder enabled.","accounts_in_message":[],"_revision_number":1},{"id":"79c4a40fc2370b34342586e7e0dc07eeeae3cae3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 20:29:38.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-full/5cddaa1/ : SUCCESS in 37m 33s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-postgres-full/1745111/ : SUCCESS in 34m 01s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-full/e7d506b/ : SUCCESS in 40m 48s\n- check-grenade-dsvm http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm/50c0c75/ : SUCCESS in 41m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-large-ops/bdcbac8/ : SUCCESS in 19m 45s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-neutron-large-ops/873fcb3/ : SUCCESS in 22m 03s\n- gate-devstack-bashate http://logs.openstack.org/50/196050/1/check/gate-devstack-bashate/1757f10/ : SUCCESS in 11s\n- gate-devstack-unit-tests http://logs.openstack.org/50/196050/1/check/gate-devstack-unit-tests/b5d63c7/ : SUCCESS in 21s\n- check-devstack-dsvm-cells http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-cells/a72e96a/ : SUCCESS in 15m 52s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-partial-ncpu/cdc3026/ : SUCCESS in 37m 35s\n- check-swift-dsvm-functional http://logs.openstack.org/50/196050/1/check/check-swift-dsvm-functional/8429c46/ : SUCCESS in 20m 48s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-ironic-pxe_ssh/9cba888/ : SUCCESS in 30m 46s\n- check-devstack-dsvm-updown http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-updown/4e2d352/ : SUCCESS in 19m 04s\n- check-tempest-dsvm-f21 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-f21/0f5df13/ : FAILURE in 43m 56s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-centos7/3e75138/ : FAILURE in 22m 22s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/50/196050/1/check/gate-devstack-publish-docs/148a821//doc/build/html/ : SUCCESS in 2m 06s\n- check-grenade-dsvm-neutron http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-neutron/5f15807/ : FAILURE in 38m 32s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-multinode-smoke/0834959/ : SUCCESS in 25m 03s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-multinode-smoke/b5a1587/ : SUCCESS in 27m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b18ad39eb7b5db35fb0e5f9ad788a83900a82bc1","author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"date":"2015-06-29 02:04:57.000000000","message":"Patch Set 1: Code-Review-1\n\nDmitry, thank you for reply. I\u0027ve checked the log and understand what is the reason. (I\u0027ve also learned how to check the gate log, thanks,  awesome.)\n\nBut I think we can remove not only cinder\u0027s but also all legacy special cases and maybe it will be merged easily than removing just cinder\u0027s because Devstack\u0027s core developers can understand the meaning of the patch easily.\n\nSo that, I posted new patch. Could you please check it?\n\nhttps://review.openstack.org/#/c/196492/","accounts_in_message":[],"_revision_number":1},{"id":"e7c7f79fcc7cb8238c6c43f717793b28dba51b79","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-29 08:08:35.000000000","message":"Patch Set 1:\n\nI would prefer we just fix the inspector gate, then clean up the remaining code. Could you rebase your patch on top of this one instead?","accounts_in_message":[],"_revision_number":1},{"id":"ff3f0d79019938dbe5562bc39f4c502e745d0e89","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-06-29 08:09:10.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7bcf4c35402037777f18cd76eb1c7ee3a695eb00","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-29 09:01:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-full/1b781fd/ : SUCCESS in 41m 59s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-postgres-full/184e235/ : SUCCESS in 37m 11s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-full/03abe0b/ : SUCCESS in 50m 25s\n- check-grenade-dsvm http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm/59e9a3e/ : SUCCESS in 42m 57s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-large-ops/9de58c4/ : SUCCESS in 31m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/50/196050/1/check/gate-tempest-dsvm-neutron-large-ops/4396d73/ : SUCCESS in 26m 49s\n- gate-devstack-bashate http://logs.openstack.org/50/196050/1/check/gate-devstack-bashate/15c9807/ : SUCCESS in 19s\n- gate-devstack-unit-tests http://logs.openstack.org/50/196050/1/check/gate-devstack-unit-tests/599ff09/ : SUCCESS in 31s\n- check-devstack-dsvm-cells http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-cells/c20740f/ : SUCCESS in 27m 16s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-partial-ncpu/5039568/ : SUCCESS in 49m 35s\n- check-swift-dsvm-functional http://logs.openstack.org/50/196050/1/check/check-swift-dsvm-functional/b4c90e6/ : SUCCESS in 22m 46s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-ironic-pxe_ssh/053dd03/ : SUCCESS in 31m 34s\n- check-devstack-dsvm-updown http://logs.openstack.org/50/196050/1/check/check-devstack-dsvm-updown/42704e4/ : SUCCESS in 16m 01s\n- check-tempest-dsvm-f21 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-f21/fce7629/ : FAILURE in 41m 19s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-centos7/231aab1/ : FAILURE in 22m 01s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/50/196050/1/check/gate-devstack-publish-docs/8d82b39//doc/build/html/ : SUCCESS in 1m 57s\n- check-grenade-dsvm-neutron http://logs.openstack.org/50/196050/1/check/check-grenade-dsvm-neutron/a691206/ : SUCCESS in 38m 33s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-multinode-smoke/992ae0d/ : SUCCESS in 25m 15s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/50/196050/1/check/check-tempest-dsvm-neutron-multinode-smoke/eeffdcc/ : SUCCESS in 25m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"619dd2473bc1376bdf7f30ccbfd409a70ea488e4","author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"date":"2015-06-29 15:04:04.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"5d6f1a398ea68ecf6d538cafd8e06e0588d0f6d2","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-06-30 05:42:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a9feddbc469a7071112435146e1a7e6de932a7c1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-06-30 15:53:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nYuiko is correct in that additional checks like this can be removed, but probably not all of them yet.","accounts_in_message":[],"_revision_number":1},{"id":"2e486d378decfc1e1719eb5f3456e599117e989f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-30 15:53:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"64e8f5c878cc3907c5578c4fb5811a7961b51eea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-30 16:55:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/50/196050/1/gate/gate-tempest-dsvm-full/ab9f3ca/ : SUCCESS in 45m 12s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/50/196050/1/gate/gate-tempest-dsvm-postgres-full/1da4be1/ : SUCCESS in 41m 39s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/50/196050/1/gate/gate-tempest-dsvm-neutron-full/d0311d7/ : SUCCESS in 53m 56s\n- gate-grenade-dsvm http://logs.openstack.org/50/196050/1/gate/gate-grenade-dsvm/baa47a3/ : SUCCESS in 42m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/50/196050/1/gate/gate-tempest-dsvm-large-ops/bb0e1d7/ : SUCCESS in 26m 16s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/50/196050/1/gate/gate-tempest-dsvm-neutron-large-ops/ac947fe/ : SUCCESS in 26m 04s\n- gate-devstack-bashate http://logs.openstack.org/50/196050/1/gate/gate-devstack-bashate/76738d6/ : SUCCESS in 18s\n- gate-devstack-dsvm-cells http://logs.openstack.org/50/196050/1/gate/gate-devstack-dsvm-cells/c31215b/ : SUCCESS in 21m 12s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/50/196050/1/gate/gate-grenade-dsvm-partial-ncpu/ecceebc/ : SUCCESS in 42m 38s\n- gate-swift-dsvm-functional http://logs.openstack.org/50/196050/1/gate/gate-swift-dsvm-functional/431f9ca/ : SUCCESS in 28m 43s","accounts_in_message":[],"_revision_number":1},{"id":"168d47278b331e2eccdb0f5af67c630d1f3eb4a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-30 16:55:33.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f2a05497a3716b5eaa178b970d5cd2e6db865a97","revisions":{"f2a05497a3716b5eaa178b970d5cd2e6db865a97":{"kind":"REWORK","_number":1,"created":"2015-06-26 13:22:03.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/50/196050/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/50/196050/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/50/196050/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/50/196050/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/50/196050/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/50/196050/1"}}},"commit":{"parents":[{"commit":"c782781a4ca5fc2671a6e5d188f68e99e7a656f4","subject":"Merge \"Add devstack-admin cloud to clouds.yaml\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c782781a4ca5fc2671a6e5d188f68e99e7a656f4"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-06-26 13:20:54.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-06-26 13:22:01.000000000","tz":120},"subject":"Drop no longer needed and broken check for cinder in is_service_enabled","message":"Drop no longer needed and broken check for cinder in is_service_enabled\n\nThere is properly working is_cinder_enabled now, and this check\nactualy matches ironic-inspector, breaking its devstack plugin.\n\nChange-Id: I659ec9b9b2b49690fd075f9766ae8cbf19e81848\nCloses-Bug: #1469160\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2a05497a3716b5eaa178b970d5cd2e6db865a97"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2a05497a3716b5eaa178b970d5cd2e6db865a97"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}