)]}'
{"functions-common":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3eeb2d719d65193bdf76944ef74adbb0aba4bcf5","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"        [[ ${service} \u003d\u003d n-cell-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cell\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1809,"context_line":"        [[ ${service} \u003d\u003d n-cpu-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cpu\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1810,"context_line":"        [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1811,"context_line":"        [[ ${service} \u003d\u003d \"cinder\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"c-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1812,"context_line":"        [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"g-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1813,"context_line":"        [[ ${service} \u003d\u003d \"ironic\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"ir-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1814,"context_line":"        [[ ${service} \u003d\u003d \"neutron\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"q-\" ]] \u0026\u0026 enabled\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"fa1b9901_90032c10","line":1811,"updated":"2015-08-25 14:28:27.000000000","message":"That\u0027s weird?","commit_id":"b8ab61f9c2c1510a18362ce3de587a708c84b11d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b2bfaceb7b060a94da89a606b69c558d9ec6ee89","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"        [[ ${service} \u003d\u003d n-cell-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cell\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1809,"context_line":"        [[ ${service} \u003d\u003d n-cpu-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cpu\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1810,"context_line":"        [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1811,"context_line":"        [[ ${service} \u003d\u003d \"cinder\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"c-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1812,"context_line":"        [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"g-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1813,"context_line":"        [[ ${service} \u003d\u003d \"ironic\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"ir-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":1814,"context_line":"        [[ ${service} \u003d\u003d \"neutron\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"q-\" ]] \u0026\u0026 enabled\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"fa1b9901_f3e5d208","line":1811,"in_reply_to":"fa1b9901_90032c10","updated":"2015-08-25 14:34:18.000000000","message":"That is weird, maybe a weird merge. I\u0027ll look.","commit_id":"b8ab61f9c2c1510a18362ce3de587a708c84b11d"}],"lib/tempest":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e1a304b4ae32bcc995b4a139e38a06bea9fd8d55","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    # this tempest service list needs to be all the services that"},{"line_number":541,"context_line":"    # tempest supports, otherwise we can have an erroneous set of"},{"line_number":542,"context_line":"    # defaults (something defaulting true in Tempest, but not listed here)."},{"line_number":543,"context_line":"    TEMPEST_SERVICES\u003d\"key,glance,nova,neutron,cinder,swift,heat,ceilometer,horizon,sahara,ironic,trove,zaqar\""},{"line_number":544,"context_line":"    for service in ${TEMPEST_SERVICES//,/ }; do"},{"line_number":545,"context_line":"        if is_service_enabled $service ; then"},{"line_number":546,"context_line":"            iniset $TEMPEST_CONFIG service_available $service \"True\""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"da20952f_7b027240","side":"PARENT","line":543,"updated":"2015-08-26 19:32:39.000000000","message":"you need to leave ceilometer in here","commit_id":"346edcc532719f6f29471920f9434b6d5300d43a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"74e552a3ab11304c5d277e81a6b65c90dd8fa8a6","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    # this tempest service list needs to be all the services that"},{"line_number":541,"context_line":"    # tempest supports, otherwise we can have an erroneous set of"},{"line_number":542,"context_line":"    # defaults (something defaulting true in Tempest, but not listed here)."},{"line_number":543,"context_line":"    TEMPEST_SERVICES\u003d\"key,glance,nova,neutron,cinder,swift,heat,ceilometer,horizon,sahara,ironic,trove,zaqar\""},{"line_number":544,"context_line":"    for service in ${TEMPEST_SERVICES//,/ }; do"},{"line_number":545,"context_line":"        if is_service_enabled $service ; then"},{"line_number":546,"context_line":"            iniset $TEMPEST_CONFIG service_available $service \"True\""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"da20952f_47c1cce3","side":"PARENT","line":543,"in_reply_to":"da20952f_7b027240","updated":"2015-08-26 21:42:38.000000000","message":"Can you explain that in a little more depth please? It doesn\u0027t quite make sense to the mental model I\u0027ve got going and it would be could to get that fixed.\n\nIn my mind I was thinking this was \"those services that tempest can rely on to be there\". Thus the plugin[1] should add to it if (and only if) it is enabled.\n\nClearly this means something else and whatever that something else represent a bi-directional coupling which is counterintuitive with the notion of a \"plugin\".\n\nHelp me understand, Obi Sean\n\n[1] https://github.com/openstack/ceilometer/blob/ccf824aa4359c43fd780661ef837f2da0e2bd9b8/devstack/settings#L38","commit_id":"346edcc532719f6f29471920f9434b6d5300d43a"}]}