)]}'
{"id":"openstack%2Fdevstack~196921","triplet_id":"openstack%2Fdevstack~master~Idca49eb996d2b7ff3779ec27ed672a2da7852590","project":"openstack/devstack","branch":"master","topic":"bug/1469178","hashtags":[],"change_id":"Idca49eb996d2b7ff3779ec27ed672a2da7852590","subject":"Add header guard to functions/functions-common","status":"MERGED","created":"2015-06-30 01:06:19.000000000","updated":"2015-08-17 19:38:07.000000000","submitted":"2015-08-17 19:38:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"67b5af09d6576c25a4d5b24af71f4bc71f4b7115","_number":196921,"virtual_id_number":196921,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"date":"2015-06-30 04:44:03.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-08-17 19:38:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2015-07-07 16:29:42.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"date":"2015-08-07 04:12:08.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"recommended":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":1,"date":"2015-08-13 15:26:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-08-13 16:28:17.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":2,"date":"2015-08-17 18:08:29.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2015-06-30 09:11:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2015-08-17 18:08:29.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-30 04:44:03.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-06-30 09:11:23.000000000","updated_by":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"reviewer":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"state":"REVIEWER"},{"updated":"2015-08-13 15:26:09.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2015-08-13 16:28:17.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2015-08-17 18:08:29.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-08-17 19:38:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"02496f5fffa212935097059c336e405c68c700c4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-06-30 01:06:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a4158b1cc070b223b986538c09c94335a455ecf","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-06-30 01:12:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4bdbd63700f6780786c7a686af85fdce1e68d7b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-30 02:09:43.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-full/94ebc97/ : SUCCESS in 45m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-postgres-full/6406628/ : SUCCESS in 37m 34s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-neutron-full/79c34a6/ : SUCCESS in 53m 12s\n- check-grenade-dsvm http://logs.openstack.org/21/196921/2/check/check-grenade-dsvm/7932c6b/ : FAILURE in 29m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/21/196921/2/check/gate-tempest-dsvm-large-ops/c777a15/ : SUCCESS in 20m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/21/196921/2/check/gate-tempest-dsvm-neutron-large-ops/135b2e6/ : SUCCESS in 20m 18s\n- gate-devstack-bashate http://logs.openstack.org/21/196921/2/check/gate-devstack-bashate/7144110/ : SUCCESS in 19s\n- gate-devstack-unit-tests http://logs.openstack.org/21/196921/2/check/gate-devstack-unit-tests/4d3cb1c/ : SUCCESS in 19s\n- check-devstack-dsvm-cells http://logs.openstack.org/21/196921/2/check/check-devstack-dsvm-cells/64417e0/ : FAILURE in 16m 14s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/21/196921/2/check/check-grenade-dsvm-partial-ncpu/bdf699d/ : FAILURE in 26m 48s\n- check-swift-dsvm-functional http://logs.openstack.org/21/196921/2/check/check-swift-dsvm-functional/8e60a80/ : SUCCESS in 25m 28s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-ironic-pxe_ssh/e4808c8/ : SUCCESS in 32m 20s\n- check-devstack-dsvm-updown http://logs.openstack.org/21/196921/2/check/check-devstack-dsvm-updown/53c7cfd/ : FAILURE in 23m 01s\n- check-tempest-dsvm-f21 http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-f21/9a3a06d/ : FAILURE in 43m 39s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-centos7/3890dc3/ : FAILURE in 21m 33s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/21/196921/2/check/gate-devstack-publish-docs/52592b7//doc/build/html/ : SUCCESS in 2m 42s\n- check-grenade-dsvm-neutron http://logs.openstack.org/21/196921/2/check/check-grenade-dsvm-neutron/0b1dc78/ : FAILURE in 32m 34s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-multinode-smoke/26029f5/ : SUCCESS in 26m 51s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/21/196921/2/check/check-tempest-dsvm-neutron-multinode-smoke/d855c1e/ : SUCCESS in 26m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2c9d7f41c21f6f2128dcd47d6680fbc38631dda5","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-06-30 02:11:20.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/21/196921/2/2718/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"651ff460f82ecb06cbb55948b67b8286499c4532","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-06-30 03:50:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"252d244b569f7efb8b6afd3f0abf13329fadaef3","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-06-30 04:44:03.000000000","message":"Patch Set 3:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/21/196921/3/2725/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":3},{"id":"bbbfe812124ca872002e8d43835bef175b7f330c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-30 04:52:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-full/0ca74b9/ : SUCCESS in 50m 04s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-postgres-full/bd01e83/ : SUCCESS in 49m 18s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-neutron-full/f850506/ : SUCCESS in 59m 46s\n- check-grenade-dsvm http://logs.openstack.org/21/196921/3/check/check-grenade-dsvm/2fddd6b/ : SUCCESS in 40m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/21/196921/3/check/gate-tempest-dsvm-large-ops/8066e85/ : SUCCESS in 37m 35s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/21/196921/3/check/gate-tempest-dsvm-neutron-large-ops/0b7c75f/ : SUCCESS in 28m 50s\n- gate-devstack-bashate http://logs.openstack.org/21/196921/3/check/gate-devstack-bashate/946815f/ : SUCCESS in 18s\n- gate-devstack-unit-tests http://logs.openstack.org/21/196921/3/check/gate-devstack-unit-tests/20b8c38/ : SUCCESS in 16s\n- check-devstack-dsvm-cells http://logs.openstack.org/21/196921/3/check/check-devstack-dsvm-cells/8f62a13/ : SUCCESS in 21m 05s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/21/196921/3/check/check-grenade-dsvm-partial-ncpu/af96a62/ : SUCCESS in 45m 50s\n- check-swift-dsvm-functional http://logs.openstack.org/21/196921/3/check/check-swift-dsvm-functional/6897762/ : SUCCESS in 26m 58s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-ironic-pxe_ssh/95fb98a/ : SUCCESS in 32m 36s\n- check-devstack-dsvm-updown http://logs.openstack.org/21/196921/3/check/check-devstack-dsvm-updown/e60af4b/ : SUCCESS in 17m 11s\n- check-tempest-dsvm-f21 http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-f21/7642364/ : FAILURE in 40m 44s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-centos7/7f05704/ : SUCCESS in 27m 29s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/21/196921/3/check/gate-devstack-publish-docs/6a6b30d//doc/build/html/ : SUCCESS in 1m 49s\n- check-grenade-dsvm-neutron http://logs.openstack.org/21/196921/3/check/check-grenade-dsvm-neutron/2e031ee/ : SUCCESS in 47m 37s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-multinode-smoke/96c41ee/ : SUCCESS in 24m 27s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/21/196921/3/check/check-tempest-dsvm-neutron-multinode-smoke/42401ba/ : SUCCESS in 26m 01s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5118840b4673b8dcf1182feb8e2ee20c5bcb2009","author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"date":"2015-06-30 09:11:23.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"517d2b2ec49c89fc6fe883d6341059089ce4e392","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-07-07 16:29:42.000000000","message":"Patch Set 3:\n\nI\u0027m somewhat mixed on this, is there an example where this went horribly wrong?","accounts_in_message":[],"_revision_number":3},{"id":"36d883d5de408014e21a936dc4cb0476cf1aecb5","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-08-07 04:12:08.000000000","message":"Patch Set 3:\n\nI6fbae12f950a03afab39f341132746d3db9f788c is sort of related","accounts_in_message":[],"_revision_number":3},{"id":"0391638b0f360f8b28a161aa9ad035371b4c4b42","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2015-08-13 15:26:09.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"0396c495c7c37c8c5252bf173f5943bdfcbbff63","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2015-08-13 16:28:17.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"74a789fbfe00e77c8a6b80d1e45d789dc94b5f28","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-08-17 18:08:29.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"6b802ffd53602745e5b26fb29a53477c5bb9e307","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-17 18:08:43.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"9a53872e88e8d47711717bf94bf29b26b7ea209e","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-08-17 18:09:03.000000000","message":"Patch Set 3:\n\nso, honestly, it would be nice to just build a more generic guard function, which I bet you could do through getting the filename.","accounts_in_message":[],"_revision_number":3},{"id":"dd11bffff7a279be8da851ff5c1851d275437403","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-17 19:38:05.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/21/196921/3/gate/gate-tempest-dsvm-full/57e9bc6/ : SUCCESS in 46m 30s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/21/196921/3/gate/gate-tempest-dsvm-postgres-full/41ad6c9/ : SUCCESS in 45m 10s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/21/196921/3/gate/gate-tempest-dsvm-neutron-full/14029ac/ : SUCCESS in 53m 33s\n- gate-grenade-dsvm http://logs.openstack.org/21/196921/3/gate/gate-grenade-dsvm/2797ebb/ : SUCCESS in 43m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/21/196921/3/gate/gate-tempest-dsvm-large-ops/d8c0e02/ : SUCCESS in 37m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/21/196921/3/gate/gate-tempest-dsvm-neutron-large-ops/3b32f0b/ : SUCCESS in 33m 39s\n- gate-devstack-bashate http://logs.openstack.org/21/196921/3/gate/gate-devstack-bashate/72cc98a/ : SUCCESS in 20s\n- gate-devstack-dsvm-cells http://logs.openstack.org/21/196921/3/gate/gate-devstack-dsvm-cells/2432d17/ : SUCCESS in 28m 20s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/21/196921/3/gate/gate-grenade-dsvm-partial-ncpu/2f0bc7d/ : SUCCESS in 49m 08s","accounts_in_message":[],"_revision_number":3},{"id":"7a44cc5aaf45f2326991d6ee91e510c9bf520320","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-17 19:38:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4ffb4541452a95ae964c562c89e31c49e39dbaa7","revisions":{"de64e49da9b1f1838102ce614a013bc57d6dd986":{"kind":"REWORK","_number":1,"created":"2015-06-30 01:06:19.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/21/196921/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/196921/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/196921/1"}}},"commit":{"parents":[{"commit":"e4d57d6bed88ec11ca7fcc8dc286a69d284c70aa","subject":"Merge \"Fixes for Linux Bridge in the L3 agent\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e4d57d6bed88ec11ca7fcc8dc286a69d284c70aa"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-30 01:00:32.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-30 01:04:16.000000000","tz":600},"subject":"Add header guard to functions/functions-common","message":"Add header guard to functions/functions-common\n\nTo avoid sourcing this twice and getting globals mixed up,\nparticularly when using multiple plugins, add a \"header guard\" that\nensures we only source it once.\n\nIn general I don\u0027t think functions/functions-common have been written\nor considered to be idempotent.  I don\u0027t think going down that path is\ngoing to be a long-term solution as it\u0027s easy to break.\n\nChange-Id: Idca49eb996d2b7ff3779ec27ed672a2da7852590\nCloses-Bug: #1469178\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/de64e49da9b1f1838102ce614a013bc57d6dd986"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/de64e49da9b1f1838102ce614a013bc57d6dd986"}]},"branch":"refs/heads/master"},"2f6d5eb3ceb68f5d90c7934aea058436a686bc0d":{"kind":"REWORK","_number":2,"created":"2015-06-30 01:12:43.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/21/196921/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/196921/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/196921/2"}}},"commit":{"parents":[{"commit":"e4d57d6bed88ec11ca7fcc8dc286a69d284c70aa","subject":"Merge \"Fixes for Linux Bridge in the L3 agent\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e4d57d6bed88ec11ca7fcc8dc286a69d284c70aa"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-30 01:00:32.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-30 01:12:26.000000000","tz":600},"subject":"Add header guard to functions/functions-common","message":"Add header guard to functions/functions-common\n\nTo avoid sourcing this twice and getting globals mixed up,\nparticularly when using multiple plugins, add a \"header guard\" that\nensures we only source it once.\n\nIn general I don\u0027t think functions/functions-common have been written\nor considered to be idempotent.  I don\u0027t think going down that path is\ngoing to be a long-term solution as it\u0027s easy to break.\n\nChange-Id: Idca49eb996d2b7ff3779ec27ed672a2da7852590\nCloses-Bug: #1469178\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2f6d5eb3ceb68f5d90c7934aea058436a686bc0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2f6d5eb3ceb68f5d90c7934aea058436a686bc0d"}]},"branch":"refs/heads/master"},"4ffb4541452a95ae964c562c89e31c49e39dbaa7":{"kind":"REWORK","_number":3,"created":"2015-06-30 03:50:40.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/21/196921/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/196921/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/196921/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/196921/3"}}},"commit":{"parents":[{"commit":"04c0f0be2643ef95380a7dcf4b510d86ff11cd58","subject":"Move failure trap after functions it uses","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/04c0f0be2643ef95380a7dcf4b510d86ff11cd58"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-30 01:00:32.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-06-30 03:48:53.000000000","tz":600},"subject":"Add header guard to functions/functions-common","message":"Add header guard to functions/functions-common\n\nTo avoid sourcing this twice and getting globals mixed up,\nparticularly when using multiple plugins, add a \"header guard\" that\nensures we only source it once.\n\nIn general I don\u0027t think functions/functions-common have been written\nor considered to be idempotent.  I don\u0027t think going down that path is\ngoing to be a long-term solution as it\u0027s easy to break.\n\nChange-Id: Idca49eb996d2b7ff3779ec27ed672a2da7852590\nCloses-Bug: #1469178\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4ffb4541452a95ae964c562c89e31c49e39dbaa7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4ffb4541452a95ae964c562c89e31c49e39dbaa7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}