)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e1484ed51808c1dab584ba91aaa847d9ae8d1464","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The function of \"is_set\" \u0026 \"isset\" is duplicated."},{"line_number":10,"context_line":"These functions check that variable is set, however \"is_set\" checks"},{"line_number":11,"context_line":"that variable isn\u0027t empty too."},{"line_number":12,"context_line":"\u0027is_set\u0027 meaning is not variable empty check but variable set check."},{"line_number":13,"context_line":"This patch delete function of \"is_set\" \u0026 rename \"isset\" to \"is_set\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idcb0605330ba4680e40578603459f82c0e8377ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_cd6391dc","line":12,"updated":"2015-07-07 00:38:58.000000000","message":"is_set documents itself as saying that it does check for !0\n\n # Test if the named environment variable is set and not zero length\n # is_set env-var","commit_id":"05b529e6a187260256260539a01689584c2aea75"},{"author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"change_message_id":"ddb96525a711d708f449de20a4a74cfd868e1688","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The function of \"is_set\" \u0026 \"isset\" is duplicated."},{"line_number":10,"context_line":"These functions check that variable is set, however \"is_set\" checks"},{"line_number":11,"context_line":"that variable isn\u0027t empty too."},{"line_number":12,"context_line":"\u0027is_set\u0027 meaning is not variable empty check but variable set check."},{"line_number":13,"context_line":"This patch delete function of \"is_set\" \u0026 rename \"isset\" to \"is_set\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idcb0605330ba4680e40578603459f82c0e8377ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_726c1dd0","line":12,"in_reply_to":"ba3cc151_5ce575d9","updated":"2015-07-09 04:52:31.000000000","message":"Thank you for your reply. I agree with your thoughts. I\u0027ll delete \"isset\" and fix test cases.","commit_id":"05b529e6a187260256260539a01689584c2aea75"},{"author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"change_message_id":"839a08889c1c527892daebc9c1fc91478089a0d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The function of \"is_set\" \u0026 \"isset\" is duplicated."},{"line_number":10,"context_line":"These functions check that variable is set, however \"is_set\" checks"},{"line_number":11,"context_line":"that variable isn\u0027t empty too."},{"line_number":12,"context_line":"\u0027is_set\u0027 meaning is not variable empty check but variable set check."},{"line_number":13,"context_line":"This patch delete function of \"is_set\" \u0026 rename \"isset\" to \"is_set\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idcb0605330ba4680e40578603459f82c0e8377ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_fff2b805","line":12,"in_reply_to":"ba3cc151_cd6391dc","updated":"2015-07-07 01:54:52.000000000","message":"Thank you for your comment.\nI agree with you, however the documents mean \"variable is set and not empty\". I think \"is_not_empty\" is appropriate as for the function name.\n\nI have 3 ideas.\n\n1. Don\u0027t change \"is_set\" and delete \"isset\"\n\n2. Change function name to \"is_not_empty\".( and delete \"isset\" too)\n\n3. Don\u0027t change \"is_set\" name and Change implementation along the function name.(reuse \"isset\")\n\nI chose 3.\nIf you have any idea, I want you to tell me that.","commit_id":"05b529e6a187260256260539a01689584c2aea75"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2132f4c5cb0900e35bd1a59f5e0b43e81c8d51fc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The function of \"is_set\" \u0026 \"isset\" is duplicated."},{"line_number":10,"context_line":"These functions check that variable is set, however \"is_set\" checks"},{"line_number":11,"context_line":"that variable isn\u0027t empty too."},{"line_number":12,"context_line":"\u0027is_set\u0027 meaning is not variable empty check but variable set check."},{"line_number":13,"context_line":"This patch delete function of \"is_set\" \u0026 rename \"isset\" to \"is_set\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idcb0605330ba4680e40578603459f82c0e8377ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_5ce575d9","line":12,"in_reply_to":"ba3cc151_fff2b805","updated":"2015-07-09 01:30:55.000000000","message":"I think it can be argued either way that \"is_set\" might detect an empty string or not.  So we need to stick with the status-quo.  I think we ant to remove \"isset\" ... it was a mistake to merge that when we had is_set, just nobody noticed at the time","commit_id":"05b529e6a187260256260539a01689584c2aea75"}],"functions-common":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6f7b6866c13c6ce00bc9335d9982b11277eea180","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"#     http_proxy\u003dhttp://proxy.example.com:3128/ no_proxy\u003drepo.example.net ./stack.sh"},{"line_number":1883,"context_line":""},{"line_number":1884,"context_line":"function export_proxy_variables {"},{"line_number":1885,"context_line":"    if is_set http_proxy ; then"},{"line_number":1886,"context_line":"        export http_proxy\u003d$http_proxy"},{"line_number":1887,"context_line":"    fi"},{"line_number":1888,"context_line":"    if is_set https_proxy ; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a41bdd9_6a99021f","line":1885,"updated":"2015-07-13 16:04:53.000000000","message":"This is a change in behaviour, as I said before it will act differently if http_proxy is set but empty, which is not unusual when wanting to temporarily override the proxy config:\n\n  http_proxy\u003d ./stack.sh\n\nPlease just put [[ -v \"$http_proxy\" ]] here directly, there is no need for a function for a single check.\n\nand below...","commit_id":"d84c814aa8a6e166fc336567c11412fcf31d1980"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"908c21837606ef02d56c8b1b17aa6658ed1ed2c2","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"#     http_proxy\u003dhttp://proxy.example.com:3128/ no_proxy\u003drepo.example.net ./stack.sh"},{"line_number":1883,"context_line":""},{"line_number":1884,"context_line":"function export_proxy_variables {"},{"line_number":1885,"context_line":"    if is_set http_proxy ; then"},{"line_number":1886,"context_line":"        export http_proxy\u003d$http_proxy"},{"line_number":1887,"context_line":"    fi"},{"line_number":1888,"context_line":"    if is_set https_proxy ; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a41bdd9_abace235","line":1885,"in_reply_to":"9a41bdd9_6a99021f","updated":"2015-07-13 21:05:48.000000000","message":"Good catch.\ni assume it must be [[ -v http_proxy ]] without \"$\"","commit_id":"d84c814aa8a6e166fc336567c11412fcf31d1980"}],"tests/test_functions.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e1484ed51808c1dab584ba91aaa847d9ae8d1464","unresolved":false,"context_lines":[{"line_number":22,"context_line":"if [[ $? \u003d 0 ]]; then"},{"line_number":23,"context_line":"    failed \"die_if_not_set [X(isn\u0027t set) true] Failed\""},{"line_number":24,"context_line":"else"},{"line_number":25,"context_line":"    passed \u0027OK\u0027"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"bash -c \"source $TOP/functions; X\u003d`echo Y \u0026\u0026 false`; die_if_not_set $LINENO X \u0027not OK\u0027\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_8d46e94d","line":25,"updated":"2015-07-07 00:38:58.000000000","message":"# Checks an environment variable is not set or has length 0 OR if the \n # exit code is non-zero and prints \"message\" and exits \n # NOTE: env-var is the variable name without a \u0027$\u0027\n # die_if_not_set $LINENO env-var \"message\"\n\nso this change is incompatible with the documented behaviour of die_if_not_set()?","commit_id":"05b529e6a187260256260539a01689584c2aea75"},{"author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"change_message_id":"839a08889c1c527892daebc9c1fc91478089a0d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"if [[ $? \u003d 0 ]]; then"},{"line_number":23,"context_line":"    failed \"die_if_not_set [X(isn\u0027t set) true] Failed\""},{"line_number":24,"context_line":"else"},{"line_number":25,"context_line":"    passed \u0027OK\u0027"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"bash -c \"source $TOP/functions; X\u003d`echo Y \u0026\u0026 false`; die_if_not_set $LINENO X \u0027not OK\u0027\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_7fad4887","line":25,"in_reply_to":"ba3cc151_8d46e94d","updated":"2015-07-07 01:54:52.000000000","message":"Thank you for your review.\nI didn\u0027t know \"die_if_not_set\" show message.\nIt\u0027s my mistake. I\u0027ll revert it.","commit_id":"05b529e6a187260256260539a01689584c2aea75"}]}