)]}'
{"id":"openstack%2Fdevstack~198646","triplet_id":"openstack%2Fdevstack~master~Idcb0605330ba4680e40578603459f82c0e8377ba","project":"openstack/devstack","branch":"master","topic":"delete_isset","hashtags":[],"change_id":"Idcb0605330ba4680e40578603459f82c0e8377ba","subject":"Delete function of \"isset\"","status":"ABANDONED","created":"2015-07-06 09:04:56.000000000","updated":"2018-03-19 17:06:48.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ef6a1851bb2d03838690f3e95b6274e42a1225de","_number":198646,"virtual_id_number":198646,"owner":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},{"date":"2015-07-16 06:18:26.000000000","_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},{"date":"2015-07-14 10:30:05.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},"all":[{"value":-1,"date":"2016-03-21 19:55:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},{"value":-1,"date":"2015-07-14 15:18:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2015-07-14 23:53:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-13 21:05:48.000000000","updated_by":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"reviewer":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"state":"REVIEWER"},{"updated":"2015-07-13 21:29:48.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2015-07-14 10:30:05.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-07-14 15:18:49.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-07-14 23:53:47.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-03-21 19:55:57.000000000","updated_by":{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},"reviewer":{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},"state":"REVIEWER"}],"messages":[{"id":"a0bab8a499a3bf07c9db2a729b2dc3bbf80f4a83","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-06 09:04:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b96dee03419c25e58931e5981321212daae46a5","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-06 10:03:48.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/198646/1/3386/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"a63b7c5cef88c45fc8a9687d44b6b55bbc5e76da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-06 10:32:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-full/a547519/ : SUCCESS in 50m 29s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-postgres-full/69adae7/ : SUCCESS in 37m 29s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-neutron/265abf8/ : SUCCESS in 32m 09s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-neutron-full/c7bfd76/ : SUCCESS in 1h 08m 14s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/1/check/check-grenade-dsvm/735ca0d/ : SUCCESS in 43m 17s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/1/check/gate-tempest-dsvm-large-ops/c7f68df/ : SUCCESS in 31m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/1/check/gate-tempest-dsvm-neutron-large-ops/71beb9e/ : SUCCESS in 40m 13s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/1/check/gate-devstack-bashate/ba7a8c0/ : FAILURE in 28s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/1/check/gate-devstack-unit-tests/293a01c/ : SUCCESS in 17s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/1/check/check-devstack-dsvm-cells/841a735/ : SUCCESS in 33m 17s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/1/check/check-grenade-dsvm-partial-ncpu/838fc42/ : SUCCESS in 52m 36s\n- check-swift-dsvm-functional http://logs.openstack.org/46/198646/1/check/check-swift-dsvm-functional/4eec44c/ : SUCCESS in 33m 57s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-ironic-pxe_ssh/12e12df/ : SUCCESS in 58m 33s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/1/check/check-devstack-dsvm-updown/4df0828/ : SUCCESS in 27m 29s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-f21/dcc4019/ : FAILURE in 1h 01m 53s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-centos7/4246eba/ : SUCCESS in 30m 02s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/1/check/gate-devstack-publish-docs/6080931//doc/build/html/ : SUCCESS in 2m 00s\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/1/check/check-grenade-dsvm-neutron/f3f148a/ : SUCCESS in 1h 25m 25s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-multinode-smoke/f55d979/ : FAILURE in 22m 11s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/1/check/check-tempest-dsvm-neutron-multinode-smoke/8faf7f7/ : FAILURE in 22m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3c8afdc088fcf3436f513526e828ef1877020471","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-07 00:22:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e1484ed51808c1dab584ba91aaa847d9ae8d1464","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-07 00:38:58.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nI think you\u0027ve found a good point of confusion here; but I don\u0027t think we can change semantics of is_set() which are documented.  it seems isset() is the odd-one out here","accounts_in_message":[],"_revision_number":2},{"id":"a81a685cfc94591e9383a51bb63458c9c4727e49","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-07 01:17:42.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/198646/2/3518/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"2c6662d2d4c81877c8ee42a936e4c419750e49b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-07 01:34:34.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-full/4f9e204/ : SUCCESS in 52m 18s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-postgres-full/e11fff1/ : SUCCESS in 50m 53s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-neutron/e1ea4f6/ : SUCCESS in 39m 40s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-neutron-full/5b4a8c5/ : SUCCESS in 1h 10m 08s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/2/check/check-grenade-dsvm/299277a/ : SUCCESS in 46m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/2/check/gate-tempest-dsvm-large-ops/2409649/ : SUCCESS in 24m 23s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/2/check/gate-tempest-dsvm-neutron-large-ops/00343e9/ : SUCCESS in 25m 52s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/2/check/gate-devstack-bashate/67b5914/ : FAILURE in 30s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/2/check/gate-devstack-unit-tests/49dc070/ : SUCCESS in 29s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/2/check/check-devstack-dsvm-cells/82c1bf9/ : SUCCESS in 23m 00s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/2/check/check-grenade-dsvm-partial-ncpu/abc53a4/ : SUCCESS in 47m 15s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-ironic-pxe_ssh/aff0c42/ : SUCCESS in 36m 52s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/2/check/check-devstack-dsvm-updown/15cca48/ : SUCCESS in 20m 37s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-f21/baa7ef5/ : FAILURE in 50m 54s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-centos7/f148bf6/ : SUCCESS in 30m 56s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/2/check/gate-devstack-publish-docs/6e5f664//doc/build/html/ : SUCCESS in 1m 49s\n- check-swift-dsvm-functional-nv http://logs.openstack.org/46/198646/2/check/check-swift-dsvm-functional-nv/72ff46e/ : SUCCESS in 29m 12s (non-voting)\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/2/check/check-grenade-dsvm-neutron/669730a/ : SUCCESS in 47m 22s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-multinode-smoke/8a84b41/ : FAILURE in 21m 21s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/2/check/check-tempest-dsvm-neutron-multinode-smoke/74d421a/ : FAILURE in 21m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"839a08889c1c527892daebc9c1fc91478089a0d7","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-07 01:54:52.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nIan, thank you for your review \u0026 comments.","accounts_in_message":[],"_revision_number":2},{"id":"2132f4c5cb0900e35bd1a59f5e0b43e81c8d51fc","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-09 01:30:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ddb96525a711d708f449de20a4a74cfd868e1688","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-09 04:52:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8d5f929899ba70a5836dc4cda45130ac8d5a830e","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-09 07:08:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c5c250ab2d44d78e3f053d8e896b7bf8f050d842","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-09 08:08:05.000000000","message":"Patch Set 3:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/198646/3/3787/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":3},{"id":"4ae999baf3320ec49cbee85f1e5d7b18a57f3746","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-09 08:10:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-full/b9d56b8/ : SUCCESS in 50m 33s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-postgres-full/6b7ad68/ : SUCCESS in 40m 15s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-neutron/f49ecd4/ : SUCCESS in 33m 05s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-neutron-full/1587070/ : SUCCESS in 1h 00m 52s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/3/check/check-grenade-dsvm/8ef8360/ : SUCCESS in 43m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/3/check/gate-tempest-dsvm-large-ops/a93859d/ : SUCCESS in 34m 13s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/3/check/gate-tempest-dsvm-neutron-large-ops/4adeaa6/ : SUCCESS in 30m 41s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/3/check/gate-devstack-bashate/b197c76/ : SUCCESS in 22s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/3/check/gate-devstack-unit-tests/ef72789/ : SUCCESS in 18s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/3/check/check-devstack-dsvm-cells/62a479c/ : SUCCESS in 26m 38s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/3/check/check-grenade-dsvm-partial-ncpu/7f58c86/ : SUCCESS in 47m 45s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-ironic-pxe_ssh/92c8017/ : SUCCESS in 38m 32s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/3/check/check-devstack-dsvm-updown/23deb46/ : SUCCESS in 24m 59s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-f21/705368a/ : FAILURE in 49m 16s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-centos7/680468a/ : SUCCESS in 35m 07s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/3/check/gate-devstack-publish-docs/af579e5//doc/build/html/ : SUCCESS in 1m 46s\n- check-swift-dsvm-functional-nv http://logs.openstack.org/46/198646/3/check/check-swift-dsvm-functional-nv/f609aef/ : SUCCESS in 31m 45s (non-voting)\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/3/check/check-grenade-dsvm-neutron/d94eca5/ : SUCCESS in 54m 34s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-multinode-smoke/22b57d9/ : FAILURE in 24m 04s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/3/check/check-tempest-dsvm-neutron-multinode-smoke/63788d4/ : FAILURE in 21m 15s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"fb4cb14004f9108f41942a0e119e8a1421107c2d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-07-10 18:21:12.000000000","message":"Patch Set 3: Code-Review-1\n\nisset() should never have been a ting, it\u0027s a single test and doesn\u0027t add much value.\n\nA number of isset() invocations were missed however:\n\n* In function-common export_proxy_variables() I do thing that exporting the variable if it is set (even if a zero-length value) is the Right Thing.  isset can be replaced by [[ ! -v \"$1\" ]].\n\n* In stackrc, the isset call around ENABLED_SERVICES should be is_set().","accounts_in_message":[],"_revision_number":3},{"id":"4df6082685626cabe5c51cb65a5fe97cb80d3436","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-13 07:14:32.000000000","message":"Patch Set 3:\n\nHi Dean, thank you for your comment.\nI noticed my mistake.\nI forgot to change isset() -\u003e is_set() in functions-common export_proxy_variables().\nI wasn\u0027t aware that  isset() is called in stackrc.\nI\u0027ll fix these miss.","accounts_in_message":[],"_revision_number":3},{"id":"3b2036581783bf107bd53b289fdae66c94bbda2d","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-13 07:18:02.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"26d7bb0bee225bb9329e49f4fa79b945c2f24e79","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-13 08:12:41.000000000","message":"Patch Set 4:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/198646/4/4060/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":4},{"id":"a4d1895c316e3786cdf62d4390c311670c7f667f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-13 08:23:33.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-full/9df70de/ : SUCCESS in 41m 33s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-postgres-full/ebaca08/ : SUCCESS in 38m 56s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-neutron/af873c4/ : SUCCESS in 32m 16s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-neutron-full/12f0db5/ : SUCCESS in 47m 45s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/4/check/check-grenade-dsvm/aad814e/ : SUCCESS in 54m 05s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/4/check/gate-tempest-dsvm-large-ops/9f117cb/ : SUCCESS in 29m 32s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/4/check/gate-tempest-dsvm-neutron-large-ops/275fc49/ : SUCCESS in 31m 59s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/4/check/gate-devstack-bashate/d7d8866/ : FAILURE in 38s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/4/check/gate-devstack-unit-tests/8839eba/ : SUCCESS in 17s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/4/check/check-devstack-dsvm-cells/4fb168a/ : SUCCESS in 21m 24s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/4/check/check-grenade-dsvm-partial-ncpu/ccaa307/ : SUCCESS in 43m 01s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-ironic-pxe_ssh/633c32a/ : SUCCESS in 39m 27s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/4/check/check-devstack-dsvm-updown/bda2128/ : SUCCESS in 21m 07s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-f21/b7d36b6/ : FAILURE in 45m 22s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-centos7/c1300e7/ : SUCCESS in 29m 08s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/4/check/gate-devstack-publish-docs/08eb167//doc/build/html/ : SUCCESS in 2m 03s\n- check-swift-dsvm-functional-nv http://logs.openstack.org/46/198646/4/check/check-swift-dsvm-functional-nv/e63f971/ : SUCCESS in 33m 49s (non-voting)\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/4/check/check-grenade-dsvm-neutron/5f01ea9/ : SUCCESS in 43m 29s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-multinode-smoke/52f617f/ : FAILURE in 22m 03s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-neutron-multinode-smoke/23a9dc9/ : FAILURE in 22m 16s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"54bdd517b5e012d088d1152ebb7c312651dbeccd","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-13 08:34:00.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"183f13c9e43722b2c6b631a59ed50ef7029954bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-13 09:49:46.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-full/54ef380/ : SUCCESS in 43m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-postgres-full/b707db6/ : SUCCESS in 44m 18s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-neutron/42186aa/ : SUCCESS in 39m 26s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-neutron-full/42e01fe/ : SUCCESS in 50m 25s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/4/check/check-grenade-dsvm/8d34dbb/ : SUCCESS in 54m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/4/check/gate-tempest-dsvm-large-ops/e62b616/ : SUCCESS in 29m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/4/check/gate-tempest-dsvm-neutron-large-ops/896a85a/ : SUCCESS in 31m 04s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/4/check/gate-devstack-bashate/9bb9a0d/ : FAILURE in 50s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/4/check/gate-devstack-unit-tests/b1f7873/ : SUCCESS in 52s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/4/check/check-devstack-dsvm-cells/adb855a/ : SUCCESS in 26m 21s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/4/check/check-grenade-dsvm-partial-ncpu/e5c8e07/ : SUCCESS in 45m 44s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-ironic-pxe_ssh/5a0582f/ : SUCCESS in 40m 43s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/4/check/check-devstack-dsvm-updown/0597f38/ : SUCCESS in 25m 11s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-f21/a1e1836/ : FAILURE in 51m 20s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-centos7/a11070b/ : SUCCESS in 33m 35s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/4/check/gate-devstack-publish-docs/1436438//doc/build/html/ : SUCCESS in 1m 53s\n- check-swift-dsvm-functional-nv http://logs.openstack.org/46/198646/4/check/check-swift-dsvm-functional-nv/987504c/ : SUCCESS in 31m 26s (non-voting)\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/4/check/check-grenade-dsvm-neutron/083875b/ : SUCCESS in 48m 02s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-multinode-smoke/d5ee8f7/ : FAILURE in 22m 08s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/4/check/check-tempest-dsvm-neutron-multinode-smoke/5fcc95b/ : FAILURE in 22m 37s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"cb3b660962d1e725aee23a476cf129b8f3a8a795","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-13 15:51:24.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"6f7b6866c13c6ce00bc9335d9982b11277eea180","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-07-13 16:04:53.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)\n\nI still think export_proxy_variables() needs to maintain the old behaviour...","accounts_in_message":[],"_revision_number":5},{"id":"54c3f5fe790ba16ae4d1b30b5aa491a4c85627ef","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-13 16:53:33.000000000","message":"Patch Set 5:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/198646/5/4083/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":5},{"id":"908c21837606ef02d56c8b1b17aa6658ed1ed2c2","author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"date":"2015-07-13 21:05:48.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)\n\ncomments inline","accounts_in_message":[],"_revision_number":5},{"id":"bcf02444aeb9d9fa1710eec29936ae95aa73be95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-13 21:19:41.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-full/2417d58/ : SUCCESS in 56m 41s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-postgres-full/822baa0/ : SUCCESS in 53m 52s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-neutron/1e5b216/ : SUCCESS in 33m 19s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-neutron-full/2d497ff/ : SUCCESS in 1h 08m 52s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/5/check/check-grenade-dsvm/77188dd/ : SUCCESS in 46m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/5/check/gate-tempest-dsvm-large-ops/d68ecea/ : SUCCESS in 35m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/5/check/gate-tempest-dsvm-neutron-large-ops/e970b8c/ : SUCCESS in 33m 02s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/5/check/gate-devstack-bashate/0b9d141/ : SUCCESS in 0s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/5/check/gate-devstack-unit-tests/ec1ea7b/ : SUCCESS in 4s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/5/check/check-devstack-dsvm-cells/ac165e1/ : SUCCESS in 22m 47s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/5/check/check-grenade-dsvm-partial-ncpu/2dbd54d/ : SUCCESS in 52m 46s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-ironic-pxe_ssh/4e9d9e6/ : SUCCESS in 44m 12s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/5/check/check-devstack-dsvm-updown/9c28959/ : SUCCESS in 39m 34s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-f21/a20489c/ : FAILURE in 54m 50s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-centos7/59eea2c/ : SUCCESS in 31m 52s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/5/check/gate-devstack-publish-docs/a0867ce//doc/build/html/ : SUCCESS in 1m 33s\n- check-swift-dsvm-functional-nv http://logs.openstack.org/46/198646/5/check/check-swift-dsvm-functional-nv/9396ee7/ : SUCCESS in 34m 03s (non-voting)\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/5/check/check-grenade-dsvm-neutron/0bf1071/ : FAILURE in 58m 20s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-multinode-smoke/b0cd63c/ : FAILURE in 51m 32s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/5/check/check-tempest-dsvm-neutron-multinode-smoke/1264a39/ : FAILURE in 24m 52s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"6e7170bd3b5e7327023ef04d97ca3db4895009a7","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2015-07-13 21:29:48.000000000","message":"Patch Set 5:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-grenade-dsvm-neutron: https://bugs.launchpad.net/bugs/1355573\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":5},{"id":"94416b97ce57398a47d92ed19bcc9620d803e277","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-14 09:28:28.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"809a2f638e6efe245f47fc7d404043c57edc2171","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-14 09:58:30.000000000","message":"Patch Set 5:\n\nHi Dean, vigneshvar, thank you for your comments.\nI understood your thought. \nI fixed and added test of export_proxy_variables()[1] for assuring that the change doesn\u0027t break function.\n\n[1] https://review.openstack.org/#/c/201455","accounts_in_message":[],"_revision_number":5},{"id":"d04624ca9dfd9762a249ac574b15924be1aa732b","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-14 10:30:05.000000000","message":"Patch Set 6:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/198646/6/4168/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":6},{"id":"828e4b59aba08ca90efe3ebcf2cea8f90924c2da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-14 10:46:16.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-full/e3d1a10/ : SUCCESS in 50m 29s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-postgres-full/a7f26a0/ : SUCCESS in 46m 42s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-neutron/04f87a0/ : SUCCESS in 46m 13s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-neutron-full/34c7eb2/ : SUCCESS in 1h 09m 59s\n- check-grenade-dsvm http://logs.openstack.org/46/198646/6/check/check-grenade-dsvm/7fc89f0/ : SUCCESS in 46m 24s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/198646/6/check/gate-tempest-dsvm-large-ops/3a0cb52/ : SUCCESS in 27m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/198646/6/check/gate-tempest-dsvm-neutron-large-ops/a8a7f97/ : SUCCESS in 32m 11s\n- gate-devstack-bashate http://logs.openstack.org/46/198646/6/check/gate-devstack-bashate/64ece8f/ : SUCCESS in 17s\n- gate-devstack-unit-tests http://logs.openstack.org/46/198646/6/check/gate-devstack-unit-tests/874ffd3/ : SUCCESS in 18s\n- check-devstack-dsvm-cells http://logs.openstack.org/46/198646/6/check/check-devstack-dsvm-cells/f75cf12/ : SUCCESS in 34m 22s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/46/198646/6/check/check-grenade-dsvm-partial-ncpu/20ec72c/ : SUCCESS in 48m 14s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-ironic-pxe_ssh/2e2c358/ : SUCCESS in 45m 49s\n- check-devstack-dsvm-updown http://logs.openstack.org/46/198646/6/check/check-devstack-dsvm-updown/4a8d19f/ : SUCCESS in 27m 24s\n- check-tempest-dsvm-f21 http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-f21/edd9767/ : FAILURE in 51m 27s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-centos7/bba2d9a/ : SUCCESS in 31m 24s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/46/198646/6/check/gate-devstack-publish-docs/58f94fd//doc/build/html/ : SUCCESS in 1m 54s\n- check-swift-dsvm-functional-nv http://logs.openstack.org/46/198646/6/check/check-swift-dsvm-functional-nv/7aac677/ : SUCCESS in 35m 30s (non-voting)\n- check-grenade-dsvm-neutron http://logs.openstack.org/46/198646/6/check/check-grenade-dsvm-neutron/6b9e421/ : SUCCESS in 44m 51s\n- check-tempest-dsvm-multinode-smoke http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-multinode-smoke/5e3e2ff/ : FAILURE in 59s (non-voting)\n- check-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/46/198646/6/check/check-tempest-dsvm-neutron-multinode-smoke/7038bcf/ : FAILURE in 55s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"a7d216879f7fe3d9abf0e3f8943125812c5062da","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-07-14 15:18:49.000000000","message":"Patch Set 6: Code-Review-1\n\nThe new test is a great addition, however, for the proxy variables the test starting on line 241 is the wrong result.  Try the tests on the old isset() function and compare the difference.","accounts_in_message":[],"_revision_number":6},{"id":"6ccd9c4ba5444c86dfcc1ce06ef62626f6d234f7","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-14 23:53:47.000000000","message":"Patch Set 6: Code-Review-1\n\ni feel like the test-cases really duplicate the \"die_if_not_set\" testing done at the top of the file.  i guess it doesn\u0027t hurt but please at least move them together","accounts_in_message":[],"_revision_number":6},{"id":"3e4b7f4a7888cd1e11c2c5a59c05ecebd8a821fe","author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"date":"2015-07-16 06:18:26.000000000","message":"Patch Set 6:\n\nDean, Ian, thank you for your comment.\n\n\u003e Try the tests on the old isset() function and compare the difference.\n\nI\u0027m sorry that it is complexed.\nIn this patch, I removed isset() and added testing is_set() because there isn\u0027t testing is_set(). I reused testing isset() because is_set() included isset() algorithm (is_set() is \"isset + [ -n ${!1} ]\"(Is variable set and not empty ?)).\nI added \"Is variable not empty?\" test.\n\n\u003e i feel like the test-cases really duplicate the \"die_if_not_set\" testing done at the top of the file. i guess it doesn\u0027t hurt but please at least move them together\n\nI want to hear your ideas.\n\nTesting is_set()(old isset()) looks like to duplicate testing die_if_not_set(), however these  test intention are different. I don\u0027t seem to remove ether function\u0027s test.\nI think each function needs UnitTests because it is not only die_if_not_set() to use is_set(). is_set can be used from other functions.","accounts_in_message":[],"_revision_number":6},{"id":"05185782ec1c5da3ea3cbbb60f295acd854fafd6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-29 00:48:46.000000000","message":"Patch Set 6: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":6},{"id":"7f7bbd076d000199852268231b8fbacb52fcba67","author":{"_account_id":20992,"name":"Neel","email":"neel.raval@ericsson.com","username":"neelraval"},"date":"2016-03-21 19:55:57.000000000","message":"Patch Set 6: Code-Review-1","accounts_in_message":[],"_revision_number":6},{"id":"29eaa0d5f041a5014ff9d049f7dccc81da7a6945","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 05:21:17.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":6},{"id":"c461eb263a2ed743ae9bac5d62eb972f29202da4","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2018-03-19 17:06:48.000000000","message":"Abandoned\n\nThe patch has been in merge conflict for a long time, feel free to restore the patch and continue working on it","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"fd2470531116dafd95b5b18a3219ebfa2a1b9a2e","revisions":{"1db1c15427c7ed968b70c5b1fbf0994bd11d2476":{"kind":"REWORK","_number":1,"created":"2015-07-06 09:04:56.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/46/198646/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/198646/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/198646/1"}}},"commit":{"parents":[{"commit":"c1427fb5fedfbb02bbaca24dc03f884d31ac97b6","subject":"Merge \"Fix library runs.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1427fb5fedfbb02bbaca24dc03f884d31ac97b6"}]}],"author":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-03 06:53:24.000000000","tz":540},"committer":{"name":"Mahito OGURA","email":"m.ogura@ntt.com","date":"2015-07-06 09:01:27.000000000","tz":540},"subject":"Delete function of \"is_set\" \u0026 Rename \"isset\" to \"is_set\"","message":"Delete function of \"is_set\" \u0026 Rename \"isset\" to \"is_set\"\n\nThe function of \"is_set\" \u0026 \"isset\" is duplicated.\nThese functions check that variable is set, however \"is_set\" checks\nthat variable isn\u0027t empty too.\n\u0027is_set\u0027 meaning is not variable empty check but variable set check.\nThis patch delete function of \"is_set\" \u0026 rename \"isset\" to \"is_set\".\n\nChange-Id: Idcb0605330ba4680e40578603459f82c0e8377ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1db1c15427c7ed968b70c5b1fbf0994bd11d2476"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1db1c15427c7ed968b70c5b1fbf0994bd11d2476"}]},"branch":"refs/heads/master"},"05b529e6a187260256260539a01689584c2aea75":{"kind":"REWORK","_number":2,"created":"2015-07-07 00:22:58.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/46/198646/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/198646/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/198646/2"}}},"commit":{"parents":[{"commit":"c1427fb5fedfbb02bbaca24dc03f884d31ac97b6","subject":"Merge \"Fix library runs.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1427fb5fedfbb02bbaca24dc03f884d31ac97b6"}]}],"author":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-03 06:53:24.000000000","tz":540},"committer":{"name":"Mahito OGURA","email":"m.ogura@ntt.com","date":"2015-07-07 00:22:43.000000000","tz":540},"subject":"Delete function of \"is_set\" \u0026 Rename \"isset\" to \"is_set\"","message":"Delete function of \"is_set\" \u0026 Rename \"isset\" to \"is_set\"\n\nThe function of \"is_set\" \u0026 \"isset\" is duplicated.\nThese functions check that variable is set, however \"is_set\" checks\nthat variable isn\u0027t empty too.\n\u0027is_set\u0027 meaning is not variable empty check but variable set check.\nThis patch delete function of \"is_set\" \u0026 rename \"isset\" to \"is_set\".\n\nChange-Id: Idcb0605330ba4680e40578603459f82c0e8377ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/05b529e6a187260256260539a01689584c2aea75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/05b529e6a187260256260539a01689584c2aea75"}]},"branch":"refs/heads/master"},"25adae952942fee7edd4b2836373796e32eb9bd6":{"kind":"REWORK","_number":3,"created":"2015-07-09 07:08:46.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/46/198646/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/198646/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/198646/3"}}},"commit":{"parents":[{"commit":"c1427fb5fedfbb02bbaca24dc03f884d31ac97b6","subject":"Merge \"Fix library runs.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1427fb5fedfbb02bbaca24dc03f884d31ac97b6"}]}],"author":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-03 06:53:24.000000000","tz":540},"committer":{"name":"Mahito OGURA","email":"m.ogura@ntt.com","date":"2015-07-09 06:04:59.000000000","tz":540},"subject":"Delete function of \"isset\"","message":"Delete function of \"isset\"\n\nThe function of \"is_set\" \u0026 \"isset\" is duplicated.\nThis patch deletes function of \"isset\" and replaces \"isset\" with \"is_set\"\nwhere \"isset\" is called.\n\nChange-Id: Idcb0605330ba4680e40578603459f82c0e8377ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/25adae952942fee7edd4b2836373796e32eb9bd6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/25adae952942fee7edd4b2836373796e32eb9bd6"}]},"branch":"refs/heads/master"},"e13f0a3edbe5e2ce0fdbd93c6d9368fbb323a225":{"kind":"REWORK","_number":4,"created":"2015-07-13 07:18:02.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/46/198646/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/198646/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/198646/4"}}},"commit":{"parents":[{"commit":"d523a71514550a85657356ae7ffe4085800b42c6","subject":"Merge \"XenAPI: Update to a newer Cirros image\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d523a71514550a85657356ae7ffe4085800b42c6"}]}],"author":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-03 06:53:24.000000000","tz":540},"committer":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-13 07:17:21.000000000","tz":540},"subject":"Delete function of \"isset\"","message":"Delete function of \"isset\"\n\nThe function of \"is_set\" \u0026 \"isset\" is duplicated.\nThis patch deletes function of \"isset\" and replaces \"isset\" with \"is_set\"\nwhere \"isset\" is called.\n\nChange-Id: Idcb0605330ba4680e40578603459f82c0e8377ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e13f0a3edbe5e2ce0fdbd93c6d9368fbb323a225"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e13f0a3edbe5e2ce0fdbd93c6d9368fbb323a225"}]},"branch":"refs/heads/master"},"d84c814aa8a6e166fc336567c11412fcf31d1980":{"kind":"REWORK","_number":5,"created":"2015-07-13 15:51:24.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/46/198646/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/198646/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/198646/5"}}},"commit":{"parents":[{"commit":"d523a71514550a85657356ae7ffe4085800b42c6","subject":"Merge \"XenAPI: Update to a newer Cirros image\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d523a71514550a85657356ae7ffe4085800b42c6"}]}],"author":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-03 06:53:24.000000000","tz":540},"committer":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-13 15:49:41.000000000","tz":540},"subject":"Delete function of \"isset\"","message":"Delete function of \"isset\"\n\nThe function of \"is_set\" \u0026 \"isset\" is duplicated.\nThis patch deletes function of \"isset\" and replaces \"isset\" with \"is_set\"\nwhere \"isset\" is called.\n\nChange-Id: Idcb0605330ba4680e40578603459f82c0e8377ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d84c814aa8a6e166fc336567c11412fcf31d1980"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d84c814aa8a6e166fc336567c11412fcf31d1980"}]},"branch":"refs/heads/master"},"fd2470531116dafd95b5b18a3219ebfa2a1b9a2e":{"kind":"REWORK","_number":6,"created":"2015-07-14 09:28:28.000000000","uploader":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"ref":"refs/changes/46/198646/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/198646/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/198646/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/198646/6"}}},"commit":{"parents":[{"commit":"b673c832b3d871c5df272fa375164510c9f04c82","subject":"Add export_proxy_variables() tests to test_functions.sh","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b673c832b3d871c5df272fa375164510c9f04c82"}]}],"author":{"name":"Mahito","email":"m.ogura@ntt.com","date":"2015-07-03 06:53:24.000000000","tz":540},"committer":{"name":"Mahito OGURA","email":"m.ogura@ntt.com","date":"2015-07-14 09:26:40.000000000","tz":540},"subject":"Delete function of \"isset\"","message":"Delete function of \"isset\"\n\nThe function of \"is_set\" \u0026 \"isset\" is duplicated.\nThis patch deletes function of \"isset\" and replaces \"isset\" with \"is_set\"\nwhere \"isset\" is called.\n\nChange-Id: Idcb0605330ba4680e40578603459f82c0e8377ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fd2470531116dafd95b5b18a3219ebfa2a1b9a2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fd2470531116dafd95b5b18a3219ebfa2a1b9a2e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
