)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"61af756a2cab44571b31346bd19c5a618e89f39b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Davidge \u003cjodavidg@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 11:14:46 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix stack failure when default subnetpool is set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes failure by specifying subnetpool \u003d None during calls to"},{"line_number":10,"context_line":"subnet-create. Also introduces user-definable DEFAULT_SUBNNETPOOL_ID"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_0a290a9b","line":7,"updated":"2015-08-03 13:43:13.000000000","message":"Can you make it clear to say that default_ipv4_subnet_pool and/or default_ipv6_subnet_pool are defined in the conf file?","commit_id":"499ce3fff735bb1c28c1b0be961ce5d99a36a78c"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"22c04caf3a52021729edff968db5f850a94e01df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Davidge \u003cjodavidg@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 11:14:46 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix stack failure when default subnetpool is set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes failure by specifying subnetpool \u003d None during calls to"},{"line_number":10,"context_line":"subnet-create. Also introduces user-definable DEFAULT_SUBNNETPOOL_ID"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_90c72245","line":7,"in_reply_to":"3a50d1a3_0a290a9b","updated":"2015-08-03 15:43:07.000000000","message":"Done","commit_id":"499ce3fff735bb1c28c1b0be961ce5d99a36a78c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"61af756a2cab44571b31346bd19c5a618e89f39b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix stack failure when default subnetpool is set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes failure by specifying subnetpool \u003d None during calls to"},{"line_number":10,"context_line":"subnet-create. Also introduces user-definable DEFAULT_SUBNNETPOOL_ID"},{"line_number":11,"context_line":"option to local.conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I29b2d62a022b43f6623b127af2ca303f9de847b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_caf32272","line":10,"updated":"2015-08-03 13:43:13.000000000","message":"Since this is used in the subnet command, it could be either a name or ID. In the case of none-None value (and not for PD case), Introducing this  variable would require devstack to create corresponding subnetpool before using it in the subnet-create command. \n\nFor PD use case, I think it can be done in a more explicit way. For example, define a variable ENABLE_PD.","commit_id":"499ce3fff735bb1c28c1b0be961ce5d99a36a78c"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"22c04caf3a52021729edff968db5f850a94e01df","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix stack failure when default subnetpool is set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes failure by specifying subnetpool \u003d None during calls to"},{"line_number":10,"context_line":"subnet-create. Also introduces user-definable DEFAULT_SUBNNETPOOL_ID"},{"line_number":11,"context_line":"option to local.conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I29b2d62a022b43f6623b127af2ca303f9de847b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_9522b4b8","line":10,"in_reply_to":"3a50d1a3_caf32272","updated":"2015-08-03 15:43:07.000000000","message":"You\u0027re right, this variable overcomplicates things. I think it\u0027s safe to say for now at least that the default devstack subnets are always coming from the implicit (none) pool, and  therefore we can just stick with subnetpool \u003d none. Having devstack create a user-definable subnetpool can come in a future patch if we decide that\u0027s something we want it to do.","commit_id":"499ce3fff735bb1c28c1b0be961ce5d99a36a78c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"9520b65c31ec351bcb2199fe7ee22b7577fe1850","unresolved":false,"context_lines":[{"line_number":17,"context_line":"expects."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I29b2d62a022b43f6623b127af2ca303f9de847b0"},{"line_number":20,"context_line":"Fixes-Bug: #1472200"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_bd9bbbc8","line":20,"updated":"2015-08-11 03:48:25.000000000","message":"Ah - I missed this on my first pass through. I\u0027ve made this mistake a couple times myself. \n\nCloses-Bug: #1472200\n\nTo link it correctly.","commit_id":"080468d5b33a4882792331d3c855389ad1df11f3"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"1f87116c41725bac9366376d22c86996b06c7b45","unresolved":false,"context_lines":[{"line_number":17,"context_line":"expects."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I29b2d62a022b43f6623b127af2ca303f9de847b0"},{"line_number":20,"context_line":"Fixes-Bug: #1472200"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_5c185e84","line":20,"in_reply_to":"1a4dcd0f_bd9bbbc8","updated":"2015-08-11 13:37:34.000000000","message":"Haha! Good catch, thanks.","commit_id":"080468d5b33a4882792331d3c855389ad1df11f3"}],"exercises/neutron-adv-test.sh":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"875baa7add32dea9f8b24d0c4a486aebca8f237a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    source $TOP_DIR/openrc $TENANT $TENANT"},{"line_number":226,"context_line":"    local NET_ID\u003d$(neutron net-create --tenant-id $TENANT_ID $NET_NAME $EXTRA| grep \u0027 id \u0027 | awk \u0027{print $4}\u0027 )"},{"line_number":227,"context_line":"    die_if_not_set $LINENO NET_ID \"Failure creating NET_ID for $TENANT_ID $NET_NAME $EXTRA\""},{"line_number":228,"context_line":"    neutron subnet-create --ip-version 4 --tenant-id $TENANT_ID --gateway $GATEWAY --subnetpool \u0027None\u0027 $NET_ID $CIDR"},{"line_number":229,"context_line":"    neutron_debug_admin probe-create --device-owner compute $NET_ID"},{"line_number":230,"context_line":"    source $TOP_DIR/openrc demo demo"},{"line_number":231,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a4dcd0f_b3090334","line":228,"updated":"2015-08-03 17:39:59.000000000","message":"Nit: does None need to be quoted?","commit_id":"afaed45c2fc9b188bef554b99ff634366750912c"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"9b3ab135fb39da777d58362e2df41accae84c7dd","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    source $TOP_DIR/openrc $TENANT $TENANT"},{"line_number":226,"context_line":"    local NET_ID\u003d$(neutron net-create --tenant-id $TENANT_ID $NET_NAME $EXTRA| grep \u0027 id \u0027 | awk \u0027{print $4}\u0027 )"},{"line_number":227,"context_line":"    die_if_not_set $LINENO NET_ID \"Failure creating NET_ID for $TENANT_ID $NET_NAME $EXTRA\""},{"line_number":228,"context_line":"    neutron subnet-create --ip-version 4 --tenant-id $TENANT_ID --gateway $GATEWAY --subnetpool \u0027None\u0027 $NET_ID $CIDR"},{"line_number":229,"context_line":"    neutron_debug_admin probe-create --device-owner compute $NET_ID"},{"line_number":230,"context_line":"    source $TOP_DIR/openrc demo demo"},{"line_number":231,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a4dcd0f_ce40a60a","line":228,"in_reply_to":"1a4dcd0f_b3090334","updated":"2015-08-03 17:47:44.000000000","message":"Ah I thought I\u0027d removed this, fixed.","commit_id":"afaed45c2fc9b188bef554b99ff634366750912c"}]}